From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34C39C19F2D for ; Tue, 9 Aug 2022 09:08:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FA258E0001; Tue, 9 Aug 2022 05:08:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A8C46B0072; Tue, 9 Aug 2022 05:08:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821F18E0001; Tue, 9 Aug 2022 05:08:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 72F5C6B0071 for ; Tue, 9 Aug 2022 05:08:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4101E8025E for ; Tue, 9 Aug 2022 09:08:46 +0000 (UTC) X-FDA: 79779479052.06.8C85A3D Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf15.hostedemail.com (Postfix) with ESMTP id 3397AA0165 for ; Tue, 9 Aug 2022 09:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660036124; x=1691572124; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=O9MQXe84PzJNZADen1OUsbNGgsclg/pkvVH/WRSaDhU=; b=XpfxKvJxq6tq/kD1ua9JcqgkldIzNVPXOWfsgbeozzIWKdNQU51gCcSI w9Z+h4kFgUVi++fkq+PxzKmlbfUaqteNRwy7lhxog/BWrb+UFMAk6hxaq SSs9sb2H9BMV094wGVQEzYFx0/kAg7zBB+hMgt3t3buPRTUMuAyzID42w qQXnoiv+G7xT4KhLM5GTYgbs9DTcH2EXU9lKPpcqiBJdLaZn0++R/xW+4 e4Ssc1FVZjG6MgwumIjYx/8ZIa9o3RY1e/hP4kZEjTm6P9gZQoQhnpXcJ yfzxb9ZtiF8nuBov3bVV358KfOcmy6OcoKfwtmc1RRmCsHwpcVasENhWb g==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="354792832" X-IronPort-AV: E=Sophos;i="5.93,224,1654585200"; d="scan'208";a="354792832" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 02:08:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,224,1654585200"; d="scan'208";a="672817800" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 09 Aug 2022 02:08:42 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 9 Aug 2022 02:08:42 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 9 Aug 2022 02:08:41 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 9 Aug 2022 02:08:41 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 9 Aug 2022 02:08:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QD8Z5IHtr7wrZQ9+jCjOIBKnrfIfwkzNxTJjlqfhK7N2DbJ9ZNdPCZrflMr8ym6WIcP5JpR2KJuO8a683BPiKkI/WMGXyGlqDCIbdEJyygQ9kKyb//mxc8kh5FJW3ZV5n44V4W/NZLXVb5cxTIUCVMetMoHCUuSzFgxAq6GblbOtL/QcYpbB25IRZ5NLV0RLpKMd1QZrXxnWlbPBzc7GN6n2RSx7mqlNSKDV3P4eVLCy8m/xG8PaTQDGEpO+hfvNe+afqYGC2efbKhUv3zKyDPA6kDmpJkQaLTgjS1cPN0dy0f4M6vAJQZUUTq09Z97Id1TV5/V3LHbJoy7lX9T69w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OqAClqh1cl8WzPUuOusyBAFbT2U6Gq2X4CaFA2MqzDo=; b=dKjoBgJrhGVpNCgkyOvrryy3drZUkRtMlPKzbTrv+3Lw9LVDNKbtGAKxTo52W9ft6pQqopFJlKhrtcZOF1+fct4Eud9GDvSCRXQAsuTzRMJsToXQbvNBEGg1SrACAqcnuO13mJLHz7T3qUguu7+ruH3F9hoo0iTAThlTi9ey1uf2x69uOvnFdDYizY0LjD794DU+dclkur+cBL3GOOgYCE1STdz14+ooO85fTdN+T5Q5eSjGNKGgEUZyp7ztbiklE0vpOD1QFevb7oSkBG1OmSIdo9+IYuuaUUg71fov4VMqPoYf3LSUgSrp5d5KJ2YVHUV4gNDDSQzhNFyJ+HvvMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3062.namprd11.prod.outlook.com (2603:10b6:a03:92::18) by DM5PR11MB1593.namprd11.prod.outlook.com (2603:10b6:4:6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 9 Aug 2022 09:08:39 +0000 Received: from BYAPR11MB3062.namprd11.prod.outlook.com ([fe80::756c:27f:6d51:bdda]) by BYAPR11MB3062.namprd11.prod.outlook.com ([fe80::756c:27f:6d51:bdda%5]) with mapi id 15.20.5525.010; Tue, 9 Aug 2022 09:08:39 +0000 Date: Tue, 9 Aug 2022 17:08:22 +0800 From: Aaron Lu To: Yin Fengwei CC: Yang Shi , , , , , , Subject: Re: [PATCH v2] mm: release private data before split THP Message-ID: References: <20220805062844.439152-1-fengwei.yin@intel.com> <9c16b712-b5e7-df79-e7de-0259086bb3a9@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9c16b712-b5e7-df79-e7de-0259086bb3a9@intel.com> X-ClientProxiedBy: SG2PR04CA0202.apcprd04.prod.outlook.com (2603:1096:4:187::20) To BYAPR11MB3062.namprd11.prod.outlook.com (2603:10b6:a03:92::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90551aa9-0bf9-4b40-1e9f-08da79e6bf0f X-MS-TrafficTypeDiagnostic: DM5PR11MB1593:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vcsSDYCwnav9nQK2Q5IuSwm4bv9roSdDs/cGrBZhqEOdC28RIjpxT2XafEkYOuyUpbrTq/KEaBcC3Qn02+sWCBajHbxiZ3AvrD91jakDyVM1hAydLxh69A/3ycPm8+r4+dss3JS26Y9i61jJHIJWcdptX+MIFXWNRBM7eSj0CU7++ja39wr9ipzjGWWG2nzu26kGRXBbI9S6FUv3jbrhvI8J10Z2TiV0c6gEptQLMRTUyCSB1hBC2ZIoTsXme4GT/azoMPHuVM2kCs2Jr5brnPn77pzcQAVt/9+3BofS/Kel6cXTRUY12QMnNuiwm3XunPkIHhwxUfSYVogzacmEhj2rPI46nZeZXmoIAj0vkxwDsl9xgFP6BbGyQ4eH200+5q8yoGdKr+6QDqJSTcx4KKOGTrCoPb40MCw85qDRe1MoC1pTKgGm7tkPk5JZ5ZnZJC0wzNmwfDorMvpRfnza45BUQYwVspbnUBgm6juoF6VKxCpdKyCfBlDzc5J8e6KlxLx7y3tHquEc1eR4aTNsjBeC4GRLYNHUviXNTbqhWW0giad0pygDz461255GLu2FKGENQq5go6Rpbu40ZBp9IU6hhK5kKfliAidqSxPQsf75ss31trPRPsIwKVRfMbSYSurkWbnd8VxcuYj8bvN0i7kJpCHpXLnBghn8YXuYKeJZc9BhfXy8Xd9yHsOFPP1OLU9T5JembAJbbvpt/Ulgp1Y5VEM2POD4qTZFjJ1LsdvtCCozmqGc9cLRfGc6dNus X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3062.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(346002)(376002)(39860400002)(396003)(136003)(366004)(66556008)(8676002)(33716001)(66476007)(4326008)(44832011)(2906002)(66946007)(53546011)(478600001)(6636002)(316002)(38100700002)(82960400001)(6486002)(26005)(41300700001)(9686003)(6666004)(86362001)(6512007)(6506007)(8936002)(6862004)(5660300002)(107886003)(186003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s3ra5hkLo5H33B/Fx3N3A480KucAwQcxqV4OZtKOlVDZE41cLKXhH+2M2J5T?= =?us-ascii?Q?iPdVSujcp5kQ9pN5rht66XGScE3XSUlrtgzpiNw2OqzC7jRzDx9VcQvFw4qL?= =?us-ascii?Q?SlGdmQvAsDFHU6CPLI3wFuHqcMKGTOJNuvmaNltSXVtQ+bsjE6lcBpgXK0y8?= =?us-ascii?Q?BOZnLmZyibl/EeXmQd/VnQcckMLHDLiu73y18bX77/8A7Pe2/MuMelp7lyQm?= =?us-ascii?Q?3hqlG4LF1LHsrL3cSL0nyU8pGFLE8P0nYamHNv5JwaI7j6TtNzyH70FOsivC?= =?us-ascii?Q?E+CSl5wa7FIqPdmMCIcGF2M8qbMxevjrEDkfcFjjRxPGsAMhFabbvT3Jqh0Q?= =?us-ascii?Q?Zi1qavQ01KtB53fR97BsJxCLzhrhRRrGXr8gslaZQk+LY3wtuqNjsHivnB4T?= =?us-ascii?Q?b9PTSYZr+8r/PU17fJiI5nRuSaby5MZuE8lS+fTw+93OmNOwcRiGu80SAFfu?= =?us-ascii?Q?D2yyCX74ZNpAERmREB0ILaW+nFTTC0XlvW8tLNmHUMhQvg4OdM5DsBTVg0NQ?= =?us-ascii?Q?16OAWWQcy4ApUHczQj/k1cd1AP4FoCzb52sjBviRiQPlakkO94hbrZkXFZU3?= =?us-ascii?Q?Mz5jRPjIjwfnHqMTfzRcK4PTfox0qP2xzAbxXveWXlxJqQpgHF6MeFatER44?= =?us-ascii?Q?xDXcYJsBXxRT3eqXu1S14joBhYXo8hYkWT1F9ZXerF/Jr2uWKFg9ChWMh7QI?= =?us-ascii?Q?6Gd24EDwMzq86BPt4+lw4NNeLtq3IOV98q+zRWhtvWEPBlet5y2/WVUQCbv2?= =?us-ascii?Q?CLS8nkKvS373C3nXOi3PTMop7wUGzBTnkh90Sz12F9xVjGPePe+qXmcPN3VI?= =?us-ascii?Q?VcBqh1ArVBdnAyCSbR3j9p0V3I/3Kc1sSCchFPOOJ79tSEZ6C+kTtSMLS2FR?= =?us-ascii?Q?rWafudYk4HhWyYin3Y0CbqazRQoOCHCr/Zv5Eall8R8R4kHunZQJNUBLCKjN?= =?us-ascii?Q?lWx5qSiSPntFSAaVUT7bMU6+xNZx/p17SRmJ534ErjCT3A0lBkCKgBh50xwi?= =?us-ascii?Q?6FWhSlDBKuGDgemoTCuVLJRRcPZXeN+nGx+1Av1vp+wAY8nWVXNRtPaZspbl?= =?us-ascii?Q?5ZlEjVOpsuzkqvD3dJlX2gq5Vz7q2hQrHwB5/JEt7U1OD5reIbxdxOQ7wo8m?= =?us-ascii?Q?1+AcnE5zC37W7Y3+Cx6zk621Wr++5yc+uxO8OTvSxi12OmvpuLqGEJSZRTKJ?= =?us-ascii?Q?vQT0B0SbIyHBJiSUNLpZ6dXgRL9cUj+sQUwLjDLgYJM+vQnRmkBNt/J6YObh?= =?us-ascii?Q?0lmLUvLKzYw0KwVU5HaVw4xPcexOD/UrORayvZsAmrmt/H6SNDdCeaQUlMOn?= =?us-ascii?Q?PPbdkyaJ6gVqOT/mh7EK8hMJShcUdLCam97s42V+XxdWgLFryCA1VE14p6fN?= =?us-ascii?Q?h9wusGmKsk5ArF/4Q7SYJfe0bF6GytOiD5MM0q5uZ5IWeFopFaomT9lAcMl/?= =?us-ascii?Q?1YdYtnujcbE+xUwNsQaUinlg1qf4owRk+29REDKjor16w0ibDh1nZhX/D0cg?= =?us-ascii?Q?X9jAJeDWrXEZaDbOdaQlJzlaeKWRNGZuIZNsB5VPMdUl+bujmc6gUeY2CMPy?= =?us-ascii?Q?lG8drAr6cdhU4+JqDqZh+HU2/yBb9/NLR7Au0ylJ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 90551aa9-0bf9-4b40-1e9f-08da79e6bf0f X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 09:08:39.1692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vWwG58QcjY2fBV9+67hIpTNOcQLVV5a2QKMvQDiWja1MKI2gJH63z4Ndr/qeWKAQq9zEj1T3Sq4uBuALcPTlIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1593 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1660036125; a=rsa-sha256; cv=fail; b=A7o8dK3ufsR47YVM+4QmVDPd+YiUTZnk5CFgeHAUBwo4m5Ov6zfJnskt35PY4y0ZLnio/+ Xwx510dPiRaSQzkfr7dkR4x24dn45SQUeionw77bhk00rV3eBlBOG9FYOJMGKVInwKFms2 9N9nVvJXU8tLWFo894v5q9g38RupauU= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=XpfxKvJx; spf=pass (imf15.hostedemail.com: domain of aaron.lu@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=aaron.lu@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660036125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OqAClqh1cl8WzPUuOusyBAFbT2U6Gq2X4CaFA2MqzDo=; b=zAfWtdztJLT4suikGjIQiglkr1nmQo7jT4DNe1HL4KgoH+dpTXAQS22As8wrUh8gvoVYfL GX22rV4pQyEovVqay3OkVuEhZ740BUkT1Mb9/0xjA1Sd/dVkDvd0Z/Ds7tqWDWvPnX8VLJ DfkBB0bcbLW+rgORjaPCZPiLqGUT56o= X-Rspamd-Queue-Id: 3397AA0165 X-Rspam-User: X-Rspamd-Server: rspam11 Authentication-Results: imf15.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=XpfxKvJx; spf=pass (imf15.hostedemail.com: domain of aaron.lu@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=aaron.lu@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: phobxkeqc84efpjazg111ouo83s4cn4y X-HE-Tag: 1660036123-132681 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 09, 2022 at 09:12:57AM +0800, Yin Fengwei wrote: > Hi Yang, > > On 2022/8/9 01:49, Yang Shi wrote: > > The GFP_KERNEL is fine for most THP split callsites except for the > > memory reclaim path since it might not allow certain flags to avoid > > recursion, for example, nested reclaim, issue I/O, etc. The most > > filesystems clear __GFP_FS. However it should not be a real life > > problem now since AFAIK just xfs supports large folios for now and xfs > > uses iomap release_folio() method which actually ignores gfp flags. > Thanks a lot for the valuable comments. > > > > > > So it sounds safer to follow the gfp convention used by > > xas_split_alloc() in the below. The best way is to pass in the gfp > > flag from the reclaimer IMO, but it seems overkilling at the moment. > > It's possible that the gfp used by xas_split_alloc has __GFP_FS/IO set. > What about to use current_gfp_context(gfp_as_xas_split_alloc)? > Sounds reasonable to me. Also, the gfp used by xas_split_alloc() should also be modified to: current_gfp_context(mapping_gfp_mask(mapping) & GFP_RECLAIM_MASK)? Since they are in the same context.