From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57B8C25B08 for ; Tue, 9 Aug 2022 01:38:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 078058E0001; Mon, 8 Aug 2022 21:38:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F41EA6B0072; Mon, 8 Aug 2022 21:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE2E18E0001; Mon, 8 Aug 2022 21:38:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CB3436B0071 for ; Mon, 8 Aug 2022 21:38:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9518E1601EA for ; Tue, 9 Aug 2022 01:38:11 +0000 (UTC) X-FDA: 79778343582.15.2CA6182 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 0C40920162 for ; Tue, 9 Aug 2022 01:38:10 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id h28so9553042pfq.11 for ; Mon, 08 Aug 2022 18:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fD9PUstcGRUBFynoiYi6wXsqyCc6A0j4pDygBUDI0CM=; b=fJScjxlYFlYmg00s0gheP2AnAUhjAZCsjv6KW5gXPYxrlwqb0jB2B+MAS3Zi7ry2lw 0ByFq1h38n7N+r9zjriuEG9XcDSOSndOKEAlND9w+zkLVaTGi+7BnRXloJtjIlNuFJnE wcOOsxCVwpJNtgoOP0t/PJIrhv84hlxj0rVJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fD9PUstcGRUBFynoiYi6wXsqyCc6A0j4pDygBUDI0CM=; b=eb43d0zsT9GasOAWlx836XHuUOw7pE07urzwmKBsgSzDdOBELou1I4XPT7z5wCbmPp TzkbgHM9eJ5rmr/3CUX/OICAtG9URurgOdV7hmDfeImiVQh5dpS0IYAP9IyMuCfHRTvg 5FciavVgyBT6KptM3mAOXAATy38ddANlWJjY5XOO/ldmakok/NtKM+MkeKZxvG6C/8FF wQygGoH/Gn4M5YMD+tzRtJIDXNsApgn5+JU+4Axa6UU9ztspkiDRoNdidUk+QqAgVj29 leVciM1+DX1FCMTIp+ZW3sMjlkZNoMgmIu9ISNAy9KwntItTiaE21twHy71ZasWnYbsN 8TXA== X-Gm-Message-State: ACgBeo1c1GdAh+p0LwHMkUWpI6sh9gA4/zEGxlPq4rAfv9VL9Zi1DEkl ZlBZRpDp0YjXOnBzpTZ4A3Ux4Q== X-Google-Smtp-Source: AA6agR5wUBA+PoJFs2fkTCcZmbENnHalWLsK8WBJ7azQloMCGIqsyzAJpkzotkg2K+5Ci/M0SGE+Og== X-Received: by 2002:a62:7bd6:0:b0:52d:4773:a3de with SMTP id w205-20020a627bd6000000b0052d4773a3demr20792726pfc.70.1660009089913; Mon, 08 Aug 2022 18:38:09 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:8d43:c739:457a:5504]) by smtp.gmail.com with ESMTPSA id c126-20020a621c84000000b005289627ae6asm9302567pfc.187.2022.08.08.18.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 18:38:09 -0700 (PDT) Date: Tue, 9 Aug 2022 10:38:04 +0900 From: Sergey Senozhatsky To: Brian Geffon Cc: Andrew Morton , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Suleiman Souhlal , linux-mm@kvack.org Subject: Re: [RFC PATCH 1/1] zram: Allow rw_page when page isn't written back. Message-ID: References: <20220808165006.2451180-1-bgeffon@google.com> <20220808165006.2451180-2-bgeffon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220808165006.2451180-2-bgeffon@google.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660009091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fD9PUstcGRUBFynoiYi6wXsqyCc6A0j4pDygBUDI0CM=; b=sFC6DvtmOpjdNU1WCGZv/h8svOg9e4xKjRj9MAru+2pu1sky4CjQ7Kj0jS6KvURQ/JHv7J 33TRWb5jkyUXBIpUP/DLsN6rkkjmUCkRfEtYtTQ2ganY9N/m7u9t8kmFJbWQcBF1qVQxXE kmoukXK+RbAzASRfqJAsMNMiUwnJjGQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fJScjxlY; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660009091; a=rsa-sha256; cv=none; b=3GVOQz8tzCSzeEumDeXTw7JxzwWQ6dDjsPYJShfsl+G81ieDC2CQMEUjqUHhSFSbD89cSv mA4cYRCd0KJhMECpfSqRlNASl/stqGSJSmTgNMIxmF1S/xh559CNBp+6yYthi+qY4/jPM+ Wpo88VQGOc1KjXiMJWtgzvQU+/Sy80Y= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fJScjxlY; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspamd-Server: rspam02 X-Stat-Signature: fi6xboyf5t56owccpm8pfeo3mkojhen3 X-Rspamd-Queue-Id: 0C40920162 X-Rspam-User: X-HE-Tag: 1660009090-613471 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000652, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/08/08 12:50), Brian Geffon wrote: [..] > > pr_info("setup backing device %s\n", file_name); > @@ -722,7 +707,8 @@ static ssize_t writeback_store(struct device *dev, > > if (zram_test_flag(zram, index, ZRAM_WB) || > zram_test_flag(zram, index, ZRAM_SAME) || > - zram_test_flag(zram, index, ZRAM_UNDER_WB)) > + zram_test_flag(zram, index, ZRAM_UNDER_WB) || > + zram_test_flag(zram, index, ZRAM_NO_WB)) > goto next; mark_idle() probably should also test ZRAM_NO_WB bit.