From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFFFC25B0C for ; Mon, 8 Aug 2022 19:28:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 654E86B0073; Mon, 8 Aug 2022 15:28:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 604316B0074; Mon, 8 Aug 2022 15:28:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A5D28E0001; Mon, 8 Aug 2022 15:28:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C5D36B0073 for ; Mon, 8 Aug 2022 15:28:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BDA9A79EF for ; Mon, 8 Aug 2022 19:28:10 +0000 (UTC) X-FDA: 79777411140.17.B937D25 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 6D92910002D for ; Mon, 8 Aug 2022 19:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659986887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FKLyUQGyxiB0I8xVy9lbNQivmteb6Wpnt1Hf2TvWtBo=; b=UnFUxJY6/quB6xRwOWmJTyeDpl+B0sAbyyMQPrJJYTVWrF0BwAoDQ7JhsD1MTKuZpddh5a iy70gQAN9CSPgYTa830jvmDXyMpBNU+a3MxyEoEMXENM8OknusPml3Zg90vAK/n+qU0iPh 1p62Rq0T5NBzQoBAstp8UpeRcZyoGcE= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-383-60jEllKoMluF9g4NA2IQZQ-1; Mon, 08 Aug 2022 15:28:06 -0400 X-MC-Unique: 60jEllKoMluF9g4NA2IQZQ-1 Received: by mail-io1-f71.google.com with SMTP id l18-20020a6bd112000000b0067cb64ad9b2so5163448iob.20 for ; Mon, 08 Aug 2022 12:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=FKLyUQGyxiB0I8xVy9lbNQivmteb6Wpnt1Hf2TvWtBo=; b=Tm9WhoYa6wDoYnOvuKXOWWxM/5weO+Pus4Iy29CuALIbgrVIcnA0NRaNhQHh5vWcNX preVxwbIDGYjn84UtFufXU/KRbmW3+Nq4pZK3eK4gbrlHptxzdtgc00XzKaRuWYoDKwZ nwc7mOsj/FRK0jKk2aUvDsdDXpT0SNWBuYxqAT8XE7cSwUcfFfWyarwfVhOzOqY3YAMy f11iPfThHDdr6mQRv8Dg+1c8bF63dK8RTruye8VQz6Gp2u5ubtQQ2b0pURriwUihGEJk 15oawpH0BWUV1SWD+8rhJAT75nBvobwrbYhHWPLKB11xMBTdHO6pd/uMfMDM7M323wRb KpeQ== X-Gm-Message-State: ACgBeo0f5+udijR7auG6clBaXvD7UINA736nFgpLMLl7YPmYHVZRAkZC BoaIP9LQmlgr5O2JopvexREzxZkQsvI3zNwO9P5EW0LZrj5ROEyBRUnpKrKdRK/R30f5Nq9ugH5 6zAQcXhs3hgM= X-Received: by 2002:a05:6602:1493:b0:67c:498f:6297 with SMTP id a19-20020a056602149300b0067c498f6297mr8018121iow.19.1659986886048; Mon, 08 Aug 2022 12:28:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR6cjNWPmiHP9dSCLeVdoD8+pkHqAUBj7IxWRFHwftxGib/s/HCg7uOu95cJaOUnPFCTBHJyZA== X-Received: by 2002:a05:6602:1493:b0:67c:498f:6297 with SMTP id a19-20020a056602149300b0067c498f6297mr8018116iow.19.1659986885839; Mon, 08 Aug 2022 12:28:05 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id q21-20020a02a315000000b0034272baf43esm5445764jai.168.2022.08.08.12.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 12:28:05 -0700 (PDT) Date: Mon, 8 Aug 2022 15:28:03 -0400 From: Peter Xu To: David Hildenbrand Cc: Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muchun Song , Peter Feiner , "Kirill A . Shutemov" , stable@vger.kernel.org Subject: Re: [PATCH v1 1/2] mm/hugetlb: fix hugetlb not supporting write-notify Message-ID: References: <20220805110329.80540-1-david@redhat.com> <20220805110329.80540-2-david@redhat.com> <73050e64-e40f-0c94-be96-316d1e8d5f3b@redhat.com> <36bcc1f5-40e9-2d2b-3e94-18994bf62ca4@redhat.com> MIME-Version: 1.0 In-Reply-To: <36bcc1f5-40e9-2d2b-3e94-18994bf62ca4@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659986888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FKLyUQGyxiB0I8xVy9lbNQivmteb6Wpnt1Hf2TvWtBo=; b=j2GFrsnegt2WtaFZ075KGSoatwPde1Mu1BF7XQEqfy+rNoZyOiDPYDArdW+WWG2Q9HAQ6D FBa0HakAptq7mzisROY1Y8Bs6CMGk7EbSfwJ3FtIvgDaHhmmMPA/r/dDqlAdGhvppu4mNq yQS1M4Y8sDb3d11q3LEcde9yJetkyIU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UnFUxJY6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659986888; a=rsa-sha256; cv=none; b=khnY4ZDS2FN2dxNRYgtY0p4q/ZaoEVl5qkHbbvhXKsvaMEjBnoEkYbRaaaG40skxxWk1AZ 52BtaFSmCpOgEqlNUIl3B3xQyQRXd/jMvCVwABSOn60Z/a9aJaYVDiHYIQp+qxz0Iz3AGa D/9QNGpmCnEHV/mhGsaXvbzQapvgZ8M= X-Rspamd-Queue-Id: 6D92910002D Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UnFUxJY6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: uhbqsgcm9mq7nhirosh8d5usi6459zkb X-HE-Tag: 1659986888-467058 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 08, 2022 at 06:36:58PM +0200, David Hildenbrand wrote: > Well, because the write-fault handler as is cannot deal with > write-faults in shared mappings. It cannot possibly work or ever have > worked. Trivially - maybe drop the word "require" in "Hugetlb does not require/support writenotify"? -- Peter Xu