From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0003FC25B0E for ; Mon, 8 Aug 2022 01:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4988A8E0002; Sun, 7 Aug 2022 21:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4474D8E0001; Sun, 7 Aug 2022 21:28:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30F0C8E0002; Sun, 7 Aug 2022 21:28:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 22D9D8E0001 for ; Sun, 7 Aug 2022 21:28:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E3B66140439 for ; Mon, 8 Aug 2022 01:28:45 +0000 (UTC) X-FDA: 79774691010.28.2E8B156 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf25.hostedemail.com (Postfix) with ESMTP id 7D40FA0057 for ; Mon, 8 Aug 2022 01:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659922124; x=1691458124; h=date:from:to:cc:subject:message-id:mime-version: in-reply-to; bh=st6LjRLZeNJRrMDZN58ZGP4OS0SXLS7Z3FGsNNKPEH0=; b=ELnrvqZvVwRgggd0enuB6vvUGXclJUTukMI8AL2xcNzKkr7TmpJcn4D0 Qoq4QJRUCfrROdWbf/3fCJSGKqWALpwd98R8I19KH36MqyoMuLkda2WlQ JejDqFUVg5zB4SPujuJ0y7uwSNvT4Z874nG9cakLumpgnLXB1wtTlvQuu wvc0GtRKRpiLd4VcNgcki7GN30P/CZh3V8H5Yy4OIifTUuGd+VZJYhAPz Cj6AiESaOW2Kix1N0BVdxUk8n/gtQZoxdZfzJ05KSefkGK06X3pj4cjDg IhrkhCkktsdoXVeQZvVCRCv042IOCmX4GXINNc4CwwCPjS5pSQBLILkuB g==; X-IronPort-AV: E=McAfee;i="6400,9594,10432"; a="376772469" X-IronPort-AV: E=Sophos;i="5.93,221,1654585200"; d="scan'208";a="376772469" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2022 18:28:42 -0700 X-IronPort-AV: E=Sophos;i="5.93,221,1654585200"; d="scan'208";a="931844646" Received: from rongch2-desk.sh.intel.com (HELO localhost) ([10.239.159.175]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2022 18:28:36 -0700 Date: Mon, 8 Aug 2022 09:28:34 +0800 From: kernel test robot To: Markuss Broks , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Markuss Broks , Jonathan Corbet , Ard Biesheuvel , Greg Kroah-Hartman , Jiri Slaby , Helge Deller , "Paul E. McKenney" , Borislav Petkov , Kees Cook , Andrew Morton , Linux Memory Management List , Randy Dunlap , Damien Le Moal , Thomas Zimmermann , Michal Suchanek , Javier Martinez Canillas , Arnd Bergmann , Maarten Lankhorst , Wei Ming Chen , Bartlomiej Zolnierkiewicz , Tony Lindgren , linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring Subject: Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220806163255.10404-2-markuss.broks@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659922125; a=rsa-sha256; cv=none; b=TRb9MNCsRbHjRgtGFD3FoK2N+mAe7GDlaWnqMvZM4qy5ze7x1Uebf6BrA2qTytnUjFzKZl cMkMstzMHPQp1hgNlRlZ76cT8yZFtS1FNPybAkWq+/+TBJMBou8HH38hW/kSxStaebGYtn /70dyanC0QIeHnYR02ied0T0Z30LxSo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ELnrvqZv; spf=pass (imf25.hostedemail.com: domain of rong.a.chen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=rong.a.chen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659922125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=bsyAfXPijOmn0ao0Oamm8r/HvklLnQdj7aYaNrWJmBA=; b=Ez2Lwpswoq2BjhAfgRuiww1m4S3Lgrq/kIex/6Xh5Ngxwtv1kSIfpK5PmPuAPZN9iw2wuE 23l0Fkr+DG2bv3wuRZaLiD6lUBJ5C9Pio+RPO3CUvBDPoUWgULjLRMlojyHnTW71E1cCkV /0JKC7T/es2Jb3/s6YjdxgNQ0qLzNUc= X-Rspamd-Queue-Id: 7D40FA0057 Authentication-Results: imf25.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ELnrvqZv; spf=pass (imf25.hostedemail.com: domain of rong.a.chen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=rong.a.chen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: tgy8nhaitip6uyzuud16rupxs4w3patn X-HE-Tag: 1659922124-257771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Markuss, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on efi/next staging/staging-testing usb/usb-testing linus/master v5.19 next-20220805] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220807/202208071111.oWn8uZfx-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/dedd7c138e9492439eeda05fa75a18bf19883a08 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 git checkout dedd7c138e9492439eeda05fa75a18bf19883a08 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/tty/serial/earlycon.c:246:12: error: conflicting types for 'of_setup_earlycon' int __init of_setup_earlycon(const struct earlycon_id *match, ^ include/linux/serial_core.h:708:12: note: previous declaration is here extern int of_setup_earlycon(const struct earlycon_id *match, ^ 1 error generated. vim +/of_setup_earlycon +246 drivers/tty/serial/earlycon.c 8477614d9f7c5c Peter Hurley 2016-01-16 245 c90fe9c0394b06 Peter Hurley 2016-01-16 @246 int __init of_setup_earlycon(const struct earlycon_id *match, dedd7c138e9492 Markuss Broks 2022-08-06 247 int offset, 4d118c9a866590 Peter Hurley 2016-01-16 248 const char *options) b0b6abd34c1b50 Rob Herring 2014-03-27 249 { b0b6abd34c1b50 Rob Herring 2014-03-27 250 int err; b0b6abd34c1b50 Rob Herring 2014-03-27 251 struct uart_port *port = &early_console_dev.port; 088da2a17619cf Peter Hurley 2016-01-16 252 const __be32 *val; 088da2a17619cf Peter Hurley 2016-01-16 253 bool big_endian; c90fe9c0394b06 Peter Hurley 2016-01-16 254 u64 addr; b0b6abd34c1b50 Rob Herring 2014-03-27 255 65e20e8cbbccaf Michael Walle 2022-06-28 256 if (early_con.flags & CON_ENABLED) 65e20e8cbbccaf Michael Walle 2022-06-28 257 return -EALREADY; 65e20e8cbbccaf Michael Walle 2022-06-28 258 e1dd3bef6d03c9 Geert Uytterhoeven 2015-11-27 259 spin_lock_init(&port->lock); b0b6abd34c1b50 Rob Herring 2014-03-27 260 port->iotype = UPIO_MEM; dedd7c138e9492 Markuss Broks 2022-08-06 261 addr = of_flat_dt_translate_address(offset); c90fe9c0394b06 Peter Hurley 2016-01-16 262 if (addr == OF_BAD_ADDR) { c90fe9c0394b06 Peter Hurley 2016-01-16 263 pr_warn("[%s] bad address\n", match->name); c90fe9c0394b06 Peter Hurley 2016-01-16 264 return -ENXIO; c90fe9c0394b06 Peter Hurley 2016-01-16 265 } b0b6abd34c1b50 Rob Herring 2014-03-27 266 port->mapbase = addr; b0b6abd34c1b50 Rob Herring 2014-03-27 267 dedd7c138e9492 Markuss Broks 2022-08-06 268 val = of_get_flat_dt_prop(offset, "reg-offset", NULL); 088da2a17619cf Peter Hurley 2016-01-16 269 if (val) 088da2a17619cf Peter Hurley 2016-01-16 270 port->mapbase += be32_to_cpu(*val); 1f66dd36bb1843 Greentime Hu 2018-02-13 271 port->membase = earlycon_map(port->mapbase, SZ_4K); 1f66dd36bb1843 Greentime Hu 2018-02-13 272 dedd7c138e9492 Markuss Broks 2022-08-06 273 val = of_get_flat_dt_prop(offset, "reg-shift", NULL); 088da2a17619cf Peter Hurley 2016-01-16 274 if (val) 088da2a17619cf Peter Hurley 2016-01-16 275 port->regshift = be32_to_cpu(*val); dedd7c138e9492 Markuss Broks 2022-08-06 276 big_endian = of_get_flat_dt_prop(offset, "big-endian", NULL) != NULL || 088da2a17619cf Peter Hurley 2016-01-16 277 (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) && dedd7c138e9492 Markuss Broks 2022-08-06 278 of_get_flat_dt_prop(offset, "native-endian", NULL) != NULL); dedd7c138e9492 Markuss Broks 2022-08-06 279 val = of_get_flat_dt_prop(offset, "reg-io-width", NULL); 088da2a17619cf Peter Hurley 2016-01-16 280 if (val) { 088da2a17619cf Peter Hurley 2016-01-16 281 switch (be32_to_cpu(*val)) { 088da2a17619cf Peter Hurley 2016-01-16 282 case 1: 088da2a17619cf Peter Hurley 2016-01-16 283 port->iotype = UPIO_MEM; 088da2a17619cf Peter Hurley 2016-01-16 284 break; 088da2a17619cf Peter Hurley 2016-01-16 285 case 2: 088da2a17619cf Peter Hurley 2016-01-16 286 port->iotype = UPIO_MEM16; 088da2a17619cf Peter Hurley 2016-01-16 287 break; 088da2a17619cf Peter Hurley 2016-01-16 288 case 4: 088da2a17619cf Peter Hurley 2016-01-16 289 port->iotype = (big_endian) ? UPIO_MEM32BE : UPIO_MEM32; 088da2a17619cf Peter Hurley 2016-01-16 290 break; 088da2a17619cf Peter Hurley 2016-01-16 291 default: 088da2a17619cf Peter Hurley 2016-01-16 292 pr_warn("[%s] unsupported reg-io-width\n", match->name); 088da2a17619cf Peter Hurley 2016-01-16 293 return -EINVAL; 088da2a17619cf Peter Hurley 2016-01-16 294 } 088da2a17619cf Peter Hurley 2016-01-16 295 } 088da2a17619cf Peter Hurley 2016-01-16 296 dedd7c138e9492 Markuss Broks 2022-08-06 297 val = of_get_flat_dt_prop(offset, "current-speed", NULL); 31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 298 if (val) 31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 299 early_console_dev.baud = be32_to_cpu(*val); 31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 300 dedd7c138e9492 Markuss Broks 2022-08-06 301 val = of_get_flat_dt_prop(offset, "clock-frequency", NULL); 814453adea7d08 Michal Simek 2018-04-10 302 if (val) 814453adea7d08 Michal Simek 2018-04-10 303 port->uartclk = be32_to_cpu(*val); 814453adea7d08 Michal Simek 2018-04-10 304 4d118c9a866590 Peter Hurley 2016-01-16 305 if (options) { 31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 306 early_console_dev.baud = simple_strtoul(options, NULL, 0); 4d118c9a866590 Peter Hurley 2016-01-16 307 strlcpy(early_console_dev.options, options, 4d118c9a866590 Peter Hurley 2016-01-16 308 sizeof(early_console_dev.options)); 4d118c9a866590 Peter Hurley 2016-01-16 309 } 05d961320ba624 Peter Hurley 2016-01-16 310 earlycon_init(&early_console_dev, match->name); 4d118c9a866590 Peter Hurley 2016-01-16 311 err = match->setup(&early_console_dev, options); f28295cc8ce14b Hsin-Yi Wang 2020-09-15 312 earlycon_print_info(&early_console_dev); b0b6abd34c1b50 Rob Herring 2014-03-27 313 if (err < 0) b0b6abd34c1b50 Rob Herring 2014-03-27 314 return err; b0b6abd34c1b50 Rob Herring 2014-03-27 315 if (!early_console_dev.con->write) b0b6abd34c1b50 Rob Herring 2014-03-27 316 return -ENODEV; b0b6abd34c1b50 Rob Herring 2014-03-27 317 b0b6abd34c1b50 Rob Herring 2014-03-27 318 b0b6abd34c1b50 Rob Herring 2014-03-27 319 register_console(early_console_dev.con); b0b6abd34c1b50 Rob Herring 2014-03-27 320 return 0; b0b6abd34c1b50 Rob Herring 2014-03-27 321 } 8477614d9f7c5c Peter Hurley 2016-01-16 322 -- 0-DAY CI Kernel Test Service https://01.org/lkp