From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BACAAC32772 for ; Wed, 17 Aug 2022 17:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C02B6B0073; Wed, 17 Aug 2022 13:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 570318D0001; Wed, 17 Aug 2022 13:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 438BE6B0078; Wed, 17 Aug 2022 13:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36F4E6B0073 for ; Wed, 17 Aug 2022 13:24:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 07EF21A0AE4 for ; Wed, 17 Aug 2022 17:24:32 +0000 (UTC) X-FDA: 79809758700.10.F6D16F8 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id 0F15FC0096 for ; Wed, 17 Aug 2022 17:24:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 27358CE1E23; Wed, 17 Aug 2022 17:24:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED61DC433C1; Wed, 17 Aug 2022 17:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660757065; bh=8IUBrB+1MZ1RU6K14HLmH1UWa9YswW4BC8mMkpv1lg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uk33DHdVpYc32yAuX/v119SAuWyEhZ/UhCkJmtLyVwn0wOQmDQAPfOoKi/WQLv2jA d90/Oy5TvrcV1xqClFFFO1TbwdT4d49QyZgc26VZctcc+F85OKE9RqAzzmINKhgB69 qNHaSdwIMwurET7dX5JJtzryvhpLyR7N3UBdbEgU= Date: Wed, 17 Aug 2022 19:24:23 +0200 From: Greg Kroah-Hartman To: Marco Elver Cc: stable@vger.kernel.org, Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Will Deacon , Catalin Marinas , Yee Lee , Max Schulze Subject: Re: [PATCH 5.19.y] Revert "mm: kfence: apply kmemleak_ignore_phys on early allocated pool" Message-ID: References: <20220816163641.2359996-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Uk33DHdV; spf=pass (imf28.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660757071; a=rsa-sha256; cv=none; b=kVutTZKbqRNrvLXQFr+o46923oH7NUu+o4j8Va+2uHlq080uBSsSzPsHr0DG2trRPR9VRv YjKvDLK8ZJTXk6W2cUB59yq+q9iwonzqRpQihX65sM5BOa7IFGNywCgsOVjmqIXu+J6l0P orhcHYamhEHVBpgQMIF2CskUOKhagAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660757071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vLaPO5doVC7HHM7jnBeiSMKGX2zBCQhfl8h75emFA4o=; b=mMVMULv7Ez3fvmZ3/FBYSrhbKc4VDDGxdo+BVYodkGyIy2GFenzjv0gqUQb6sh0//a3CVO 3hp1npnp+suD9f7nSV+vvlOS7oMEBg/+me8SfPBAN2yUcLbPSqxfMwUgg4UroTyqdz7luk VfKY3aZl1YX89FnvchckM0eYvySD8rY= Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Uk33DHdV; spf=pass (imf28.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: sfq63euah6q534yxau48ggf3thks9yoe X-Rspamd-Queue-Id: 0F15FC0096 X-HE-Tag: 1660757070-99435 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 06:42:46PM +0200, Marco Elver wrote: > On Tue, 16 Aug 2022 at 18:37, Marco Elver wrote: > > > > This reverts commit 07313a2b29ed1079eaa7722624544b97b3ead84b. > > > > Commit 0c24e061196c21d5 ("mm: kmemleak: add rbtree and store physical > > address for objects allocated with PA") is not yet in 5.19 (but appears > > in 6.0). Without 0c24e061196c21d5, kmemleak still stores phys objects > > and non-phys objects in the same tree, and ignoring (instead of freeing) > > will cause insertions into the kmemleak object tree by the slab > > post-alloc hook to conflict with the pool object (see comment). > > > > Reports such as the following would appear on boot, and effectively > > disable kmemleak: > > > > | kmemleak: Cannot insert 0xffffff806e24f000 into the object search tree (overlaps existing) > > | CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.19.0-v8-0815+ #5 > > | Hardware name: Raspberry Pi Compute Module 4 Rev 1.0 (DT) > > | Call trace: > > | dump_backtrace.part.0+0x1dc/0x1ec > > | show_stack+0x24/0x80 > > | dump_stack_lvl+0x8c/0xb8 > > | dump_stack+0x1c/0x38 > > | create_object.isra.0+0x490/0x4b0 > > | kmemleak_alloc+0x3c/0x50 > > | kmem_cache_alloc+0x2f8/0x450 > > | __proc_create+0x18c/0x400 > > | proc_create_reg+0x54/0xd0 > > | proc_create_seq_private+0x94/0x120 > > | init_mm_internals+0x1d8/0x248 > > | kernel_init_freeable+0x188/0x388 > > | kernel_init+0x30/0x150 > > | ret_from_fork+0x10/0x20 > > | kmemleak: Kernel memory leak detector disabled > > | kmemleak: Object 0xffffff806e24d000 (size 2097152): > > | kmemleak: comm "swapper", pid 0, jiffies 4294892296 > > | kmemleak: min_count = -1 > > | kmemleak: count = 0 > > | kmemleak: flags = 0x5 > > | kmemleak: checksum = 0 > > | kmemleak: backtrace: > > | kmemleak_alloc_phys+0x94/0xb0 > > | memblock_alloc_range_nid+0x1c0/0x20c > > | memblock_alloc_internal+0x88/0x100 > > | memblock_alloc_try_nid+0x148/0x1ac > > | kfence_alloc_pool+0x44/0x6c > > | mm_init+0x28/0x98 > > | start_kernel+0x178/0x3e8 > > | __primary_switched+0xc4/0xcc > > > > Reported-by: Max Schulze > > Signed-off-by: Marco Elver > > The discussion is: > > Link: https://lore.kernel.org/all/b33b33bc-2d06-1bcd-2df7-43678962b728@online.de/ > > > --- > > mm/kfence/core.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > > index 6aff49f6b79e..4b5e5a3d3a63 100644 > > --- a/mm/kfence/core.c > > +++ b/mm/kfence/core.c > > @@ -603,6 +603,14 @@ static unsigned long kfence_init_pool(void) > > addr += 2 * PAGE_SIZE; > > } > > > > + /* > > + * The pool is live and will never be deallocated from this point on. > > + * Remove the pool object from the kmemleak object tree, as it would > > + * otherwise overlap with allocations returned by kfence_alloc(), which > > + * are registered with kmemleak through the slab post-alloc hook. > > + */ > > + kmemleak_free(__kfence_pool); > > + > > return 0; > > } > > > > @@ -615,16 +623,8 @@ static bool __init kfence_init_pool_early(void) > > > > addr = kfence_init_pool(); > > > > - if (!addr) { > > - /* > > - * The pool is live and will never be deallocated from this point on. > > - * Ignore the pool object from the kmemleak phys object tree, as it would > > - * otherwise overlap with allocations returned by kfence_alloc(), which > > - * are registered with kmemleak through the slab post-alloc hook. > > - */ > > - kmemleak_ignore_phys(__pa(__kfence_pool)); > > + if (!addr) > > return true; > > - } > > > > /* > > * Only release unprotected pages, and do not try to go back and change > > -- > > 2.37.1.595.g718a3a8f04-goog > > Now queued up, thanks. greg k-h