From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6569C28B2B for ; Fri, 19 Aug 2022 17:10:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FB748D0003; Fri, 19 Aug 2022 13:10:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A9CC8D0002; Fri, 19 Aug 2022 13:10:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 472678D0003; Fri, 19 Aug 2022 13:10:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 378C48D0002 for ; Fri, 19 Aug 2022 13:10:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0E107A1A2B for ; Fri, 19 Aug 2022 17:10:30 +0000 (UTC) X-FDA: 79816981020.04.DCBDD38 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf21.hostedemail.com (Postfix) with ESMTP id BBDE51C0018 for ; Fri, 19 Aug 2022 17:10:29 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id k14so4881592pfh.0 for ; Fri, 19 Aug 2022 10:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc; bh=7WjX18+SJwTo5iBm+RDyyQ38vzw7KWPpCCkeot28T3I=; b=S2LQx7r114T3Une2zfGFyLwMrHa53oIGdjnC12/4bfWAbMWUv2OE+868ZxwJnKnTK5 gIVgFaQYliBJlbsl93dYwckLq4nOrsq10YPb+jlSAjq9Umnyphckr+qnSL2aQVpzGVto vewKy7me+Lzo+L3NyBQSpckbYXsXXPhMFBybX8rTpvLr/JylVeX0hnH49TJcdqZADlz/ EAdt9R3Hp5ulkjlW1/sWG3jBtntFH3F7J/pb/QIn81PIGqEbXw1nDsCA6B2zLes55j0a lqyzknuwoXDpW3Yokmnj3pI8Unzw9HnSTknRp/Z9t7fKbEETpV2Eg4zTWPxQK3Pq9zlH pV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc; bh=7WjX18+SJwTo5iBm+RDyyQ38vzw7KWPpCCkeot28T3I=; b=m4rwKNSfFCqOzv1WA56xoZ6Y3aYi4MYLQo7eYfnE/fjMkGH/ZzDu0tctHdCWoJoTua /1/iglsaLQaiRRoJz6S9T4MDRvUVH9PfzpfLTUJupP3ncKFKeZDMCkEs3X15RjyasUCK fkFxHjy1HBc4pLvSGXn6rmqPRDzB2MaaqY/6HLEgWbrHUTC9KS/vy1RVjh8U8c1HbK1f dLnyD5RCinuoLNkG9Laqy+JAQPyhI2Skvy23qgmBLH2SqKO0KMoLFNRcJPyngHwOzhjC TADC1Q7uro0X65sTAQh9c7B/eCRlmG/8gFgTkVL/AQyxUJ8YUOLnOV6gdEad2qH4MIgj ASUg== X-Gm-Message-State: ACgBeo24G3naZHl3oddKA+GjEGjSpdjaaTXwuRqtT0Ms7/UUs4OHLkuO mbgByGVGBRAOwTwCi14SChg= X-Google-Smtp-Source: AA6agR4N4u7pHPc2TIUiawaqfkhsiNKVDn/EG+sF93jrjzRMMKCrNOEKARKB8/S+80/4KDYKfmdAPw== X-Received: by 2002:a65:6854:0:b0:41c:feab:e17c with SMTP id q20-20020a656854000000b0041cfeabe17cmr7097086pgt.256.1660929028734; Fri, 19 Aug 2022 10:10:28 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:db7d]) by smtp.gmail.com with ESMTPSA id f23-20020a17090a121700b001f94d25bfabsm5451928pja.28.2022.08.19.10.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 10:10:28 -0700 (PDT) Date: Fri, 19 Aug 2022 07:10:26 -1000 From: Tejun Heo To: Shakeel Butt Cc: "zhaoyang.huang" , Johannes Weiner , Michal Hocko , Zhaoyang Huang , Linux MM , LKML , Cgroups , ke.wang@unisoc.com, Zefan Li , Roman Gushchin , Muchun Song Subject: Re: [RFC PATCH] memcg: use root_mem_cgroup when css is inherited Message-ID: References: <1660908562-17409-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S2LQx7r1; spf=pass (imf21.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660929029; a=rsa-sha256; cv=none; b=qq75xglaoUqev5BWXo4zYJrfAvK+pZFSqamNyUSjUyWbMiaaQye40s4y6YBXhvTQKJBxRt 0KjlNbDGKP+7YxE8EyqUj48oJ89zzo46+u2AzowX7nYy+C24II+eSHhDqmbFpepoPV/ayN cH8yVgss7O6uvvEk6DY8Hsuda8s67RQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660929029; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7WjX18+SJwTo5iBm+RDyyQ38vzw7KWPpCCkeot28T3I=; b=gDufEV9vRN2y/0WViYGaKvZ60i/8BAEG3gD+9Go+TGJRHmRkrLiTSDqCApLK2kiadBfKAA KfrrfQG0lfIhDZg4ONmXN3Rt6WaulAiVZ4FBiPuWNzGr4YbCUSmuGT4ABkQ/CyUQ8RUtDq JzYXaZXfL3gtrAGUARVi4vLKicHVWhM= X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S2LQx7r1; spf=pass (imf21.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam02 X-Stat-Signature: fbkhf88rarn3gytstd4zs1hnig4dzs8c X-Rspamd-Queue-Id: BBDE51C0018 X-HE-Tag: 1660929029-837042 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 19, 2022 at 10:08:59AM -0700, Shakeel Butt wrote: > On Fri, Aug 19, 2022 at 9:29 AM Tejun Heo wrote: > > > > On Fri, Aug 19, 2022 at 07:29:22PM +0800, zhaoyang.huang wrote: > > > From: Zhaoyang Huang > > > > > > It is observed in android system where per-app cgroup is demanded by freezer > > > subsys and part of groups require memory control. The hierarchy could be simplized > > > as bellowing where memory charged on group B abserved while we only want have > > > group E's memory be controlled and B's descendants compete freely for memory. > > > This should be the consequences of unified hierarchy. > > > Under this scenario, less efficient memory reclaim is observed when comparing > > > with no memory control. It is believed that multi LRU scanning introduces some > > > of the overhead. Furthermore, page thrashing is also heavier than global LRU > > > which could be the consequences of partial failure of WORKINGSET mechanism as > > > LRU is too short to protect the active pages. > > > > > > A(subtree_control = memory) - B(subtree_control = NULL) - C() > > > \ D() > > > - E(subtree_control = memory) - F() > > > \ G() > > > > > > Signed-off-by: Zhaoyang Huang > > > > Just in case it wasn't clear. > > > > Nacked-by: Tejun Heo > > > > Thanks. > > > > Was there a previous discussion on this? The commit message is unreadable. http://lkml.kernel.org/r/1660298966-11493-1-git-send-email-zhaoyang.huang@unisoc.com Thanks. -- tejun