linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Zhaoyang Huang <huangzhaoyang@gmail.com>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	ke.wang@unisoc.com, Zefan Li <lizefan.x@bytedance.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Muchun Song <songmuchun@bytedance.com>
Subject: Re: [RFC PATCH] memcg: use root_mem_cgroup when css is inherited
Date: Fri, 19 Aug 2022 07:10:26 -1000	[thread overview]
Message-ID: <Yv/EArPDTcCrGqJh@slm.duckdns.org> (raw)
In-Reply-To: <CALvZod7QdLSMdBoD2WztL72qS8kJe7F79JuCH6t19rRcw6Pn1w@mail.gmail.com>

On Fri, Aug 19, 2022 at 10:08:59AM -0700, Shakeel Butt wrote:
> On Fri, Aug 19, 2022 at 9:29 AM Tejun Heo <tj@kernel.org> wrote:
> >
> > On Fri, Aug 19, 2022 at 07:29:22PM +0800, zhaoyang.huang wrote:
> > > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> > >
> > > It is observed in android system where per-app cgroup is demanded by freezer
> > > subsys and part of groups require memory control. The hierarchy could be simplized
> > > as bellowing where memory charged on group B abserved while we only want have
> > > group E's memory be controlled and B's descendants compete freely for memory.
> > > This should be the consequences of unified hierarchy.
> > > Under this scenario, less efficient memory reclaim is observed when comparing
> > > with no memory control. It is believed that multi LRU scanning introduces some
> > > of the overhead. Furthermore, page thrashing is also heavier than global LRU
> > > which could be the consequences of partial failure of WORKINGSET mechanism as
> > > LRU is too short to protect the active pages.
> > >
> > > A(subtree_control = memory) - B(subtree_control = NULL) - C()
> > >                                                       \ D()
> > >                           - E(subtree_control = memory) - F()
> > >                                                         \ G()
> > >
> > > Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> >
> > Just in case it wasn't clear.
> >
> > Nacked-by: Tejun Heo <tj@kernel.org>
> >
> > Thanks.
> >
> 
> Was there a previous discussion on this? The commit message is unreadable.

http://lkml.kernel.org/r/1660298966-11493-1-git-send-email-zhaoyang.huang@unisoc.com

Thanks.

-- 
tejun


  reply	other threads:[~2022-08-19 17:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 11:29 zhaoyang.huang
2022-08-19 16:29 ` Tejun Heo
2022-08-19 17:08   ` Shakeel Butt
2022-08-19 17:10     ` Tejun Heo [this message]
     [not found]       ` <YwNpI1ydy0yDnBH0@dhcp22.suse.cz>
2022-08-23  2:31         ` Zhaoyang Huang
     [not found]           ` <YwRjyx6wFLk8WTDe@dhcp22.suse.cz>
2022-08-23  6:03             ` Zhaoyang Huang
2022-08-23  8:33               ` Michal Hocko
2022-08-23  9:20                 ` Zhaoyang Huang
2022-08-23 11:51                   ` Michal Hocko
2022-08-23 16:21                     ` Suren Baghdasaryan
2022-08-24  7:59                       ` Michal Hocko
2022-08-24 17:13                         ` Suren Baghdasaryan
2022-08-24  2:23                     ` Zhaoyang Huang
2022-08-24  7:50                       ` Michal Hocko
2022-08-24  9:34                         ` Zhaoyang Huang
2022-08-24 10:27                           ` Michal Hocko
2022-08-25  0:43                             ` Zhaoyang Huang
2022-08-25  6:40                               ` Michal Hocko
2022-08-25  8:34                                 ` Zhaoyang Huang
2022-08-25  8:50                                   ` Michal Hocko
2022-08-25 10:11                                     ` Zhaoyang Huang
2022-08-25 13:35                                       ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv/EArPDTcCrGqJh@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=huangzhaoyang@gmail.com \
    --cc=ke.wang@unisoc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mhocko@kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=songmuchun@bytedance.com \
    --cc=zhaoyang.huang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox