From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8373EC19F2B for ; Wed, 3 Aug 2022 21:47:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF0B18E0002; Wed, 3 Aug 2022 17:47:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA0748E0001; Wed, 3 Aug 2022 17:47:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 940DD8E0002; Wed, 3 Aug 2022 17:47:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 847E18E0001 for ; Wed, 3 Aug 2022 17:47:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 56B6A1416B5 for ; Wed, 3 Aug 2022 21:47:49 +0000 (UTC) X-FDA: 79759619058.02.21CD3BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id CF21F1C004C for ; Wed, 3 Aug 2022 21:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659563268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g5uD7GSiugR//AbWEYTlGaC1DztD7rLesYw/5UTNxzU=; b=A/bSjWP8GK9d9Edsb7UaFg6mOeuTN2bBiEZYx80PLIQekj1fFeYX561mgc4m1W6pCFIcEZ 1TdqRKssL6nPEonWEgwZjkNSV1ZPv9gBVPLd5mH3cbUilHLxsfVP13gHKwfchFSQtECk6c Dqm3Z9+xrGv9v3xV/VALj95SyLxWFcM= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-463-w86u5VFfMOOUFJPktSP-8Q-1; Wed, 03 Aug 2022 17:47:47 -0400 X-MC-Unique: w86u5VFfMOOUFJPktSP-8Q-1 Received: by mail-qt1-f200.google.com with SMTP id t9-20020ac85309000000b0031ee055ad11so11849263qtn.12 for ; Wed, 03 Aug 2022 14:47:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g5uD7GSiugR//AbWEYTlGaC1DztD7rLesYw/5UTNxzU=; b=WgMPBCfZ55jo4aBL313yysFwsqWO2T3QsiPofxAZ4dtjTmY0jWRoGQ7Bs/58Pk608Y Aj3l3zMRO6CGKfDKKmvlFRm4d+a5CAa4OJBbKrXRBJ93h4rG4Zi0TMVL3WeMZZu70UDi h/Hl9Fa0TkXVQRkUOcdoz3r2d9mCVd0srDiffN8L66VsOCJA19NA5qMvtJ8FT1ws0M47 wfr+gkR8+KMl5hqipdiFetiy2kO1/3lGmb50EILJDtMd2bFzYlRp5FTm1WC9oN1raeVm MjhS2vDwLX8K+DyGkry9l+sx+OcaXBqIFc6VrJVyL5k1wnVpULBabevE9InjLGh2NWDc /ytg== X-Gm-Message-State: ACgBeo2IL3oA07i+z2YvoAy55J0yeAjh0/Ha1mqniLLzfBslIdC3Afkr E3EysYLfHai3k61asOZMJ3pBa+I6ybIxVGDSX8qO6YJNbi5jvs4LUJJU8pM3hzjYNpyQ09m+Ot7 B2IPMRiNgjCI= X-Received: by 2002:a0c:9124:0:b0:473:be1e:b11d with SMTP id q33-20020a0c9124000000b00473be1eb11dmr24163956qvq.20.1659563266912; Wed, 03 Aug 2022 14:47:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR6/gRpPz8gLgLfIEYyRXhCQb2VYGd3wNqztIznBSwaTIiI4cLk8hTAC1nnQQJ0h//cPezJe6w== X-Received: by 2002:a0c:9124:0:b0:473:be1e:b11d with SMTP id q33-20020a0c9124000000b00473be1eb11dmr24163938qvq.20.1659563266681; Wed, 03 Aug 2022 14:47:46 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id h10-20020a05620a284a00b006b5cb0c512asm13963191qkp.101.2022.08.03.14.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 14:47:46 -0700 (PDT) Date: Wed, 3 Aug 2022 17:47:44 -0400 From: Peter Xu To: kernel test robot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kbuild-all@lists.01.org, Andrea Arcangeli , Andi Kleen , Andrew Morton , David Hildenbrand , Hugh Dickins , Huang Ying , Nadav Amit , "Kirill A . Shutemov" , Vlastimil Babka Subject: Re: [PATCH 2/2] mm: Remember young bit for page migrations Message-ID: References: <20220803012159.36551-3-peterx@redhat.com> <202208032031.PVcMB0Hr-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202208032031.PVcMB0Hr-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659563268; a=rsa-sha256; cv=none; b=i5PI1FDrEO40Qns4v/XpFDClYYfUz3szkogKG5MitrN3E7TLWF++Os5fFZ1LUZFtQz2RyF 8Gkackz07gDr4uQqwdGSlv5j658fPHVwfXZdIqhy/vFB8bcx/OZAxrmmxZvtDtmOb8lDPW 7d/i6FAwD0o+0i23SsI0IT/SY2paftk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="A/bSjWP8"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659563268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g5uD7GSiugR//AbWEYTlGaC1DztD7rLesYw/5UTNxzU=; b=0ua9qYFdOdJr6LjAESQ3P4p7BevB+EcZozpAoM/GMLAQkvqEC8p5/WDe0wnjAcrffKxZtP AY1IVYu8fXTs7LIJtRVBW+B99UuxitJqaA5cn9t4xQasQrWDH04MIO6AC6+fA9q7iKTQNz h94EcgxQS7QMz88HW9K9aP8eICIei94= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="A/bSjWP8"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CF21F1C004C X-Rspam-User: X-Stat-Signature: koda7ykhkeymo9twsbm4nj3hchpy4fja X-HE-Tag: 1659563268-686265 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 03, 2022 at 08:21:43PM +0800, kernel test robot wrote: > Hi Peter, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-Remember-young-bit-for-migration-entries/20220803-092311 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > config: openrisc-randconfig-r016-20220803 (https://download.01.org/0day-ci/archive/20220803/202208032031.PVcMB0Hr-lkp@intel.com/config) > compiler: or1k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/2fca6cb25745d1404fc34e0ec2ea89b6195a8c27 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Peter-Xu/mm-Remember-young-bit-for-migration-entries/20220803-092311 > git checkout 2fca6cb25745d1404fc34e0ec2ea89b6195a8c27 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > or1k-linux-ld: mm/rmap.o: in function `migration_entry_supports_young': > >> include/linux/swapops.h:288: undefined reference to `max_swapfile_size' > include/linux/swapops.h:288:(.text+0x31a0): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `max_swapfile_size' > or1k-linux-ld: mm/migrate.o: in function `migration_entry_supports_young': > >> include/linux/swapops.h:288: undefined reference to `max_swapfile_size' > include/linux/swapops.h:288:(.text+0x158): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `max_swapfile_size' Hmm, a bit surprised to know swapops.h will be used without CONFIG_SWAP.. I'll squash this in the next version (if not going via a page flag based approach): diff --git a/include/linux/swapops.h b/include/linux/swapops.h index 9ddede3790a4..d689f59479c3 100644 --- a/include/linux/swapops.h +++ b/include/linux/swapops.h @@ -285,7 +285,11 @@ static inline bool migration_entry_supports_young(void) * entry has the offset larger than storing the PFN value, then it * means there's extra bit(s) where we can store the young bit. */ +#ifdef CONFIG_SWAP return max_swapfile_size() > SWP_MIG_YOUNG_BIT; +#else + return false; +#endif } static inline swp_entry_t make_migration_entry_young(swp_entry_t entry) -- Peter Xu