From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Hugh Dickins <hughd@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH] mm: vmscan: fix extreme overreclaim and swap floods
Date: Wed, 3 Aug 2022 09:28:19 -0400 [thread overview]
Message-ID: <Yup386Bq8Ek1VHJq@cmpxchg.org> (raw)
In-Reply-To: <20220802170619.250e1a0b475222a82e7077b3@linux-foundation.org>
On Tue, Aug 02, 2022 at 05:06:19PM -0700, Andrew Morton wrote:
> On Tue, 2 Aug 2022 12:28:11 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> > Change the code such that only one SWAP_CLUSTER_MAX-sized nudge toward
> > the larger LRU lists is made before bailing out on a met reclaim goal.
>
> It seems rash to jam this into 5.20-rc1 at this stage. I'm thinking
> 5.21-rc1 with a cc:stable?
Yeah, 5.20-rc1 sounds fast. Let's wait for reviews first and see how
much confidence we get on that change. I can't help but feel, reading
logs and comments (commit 1a501907bbea8e6ebb0b16cf6db9e9cbf1d2c813),
that my fix is how the code was intended to work from the start.
5.21 does sound a biiiit on the long side for fixing such extreme
misbehavior, IMO, once it's proven to affect production workloads in
the wild. I was hoping -rc2 or so...
next prev parent reply other threads:[~2022-08-03 13:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 16:28 Johannes Weiner
2022-08-03 0:06 ` Andrew Morton
2022-08-03 13:28 ` Johannes Weiner [this message]
2022-08-03 17:27 ` Rik van Riel
2022-08-04 9:38 ` Mel Gorman
2022-08-08 13:54 ` Yosry Ahmed
2022-08-08 14:07 ` Yosry Ahmed
2022-08-12 1:59 ` Joonsoo Kim
2022-11-12 22:48 ` Johannes Weiner
2022-09-20 6:12 ` Hongchen Zhang
2022-11-12 14:23 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yup386Bq8Ek1VHJq@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox