From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06415C00144 for ; Tue, 2 Aug 2022 02:54:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FEFD6B0071; Mon, 1 Aug 2022 22:54:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AF8C6B0072; Mon, 1 Aug 2022 22:54:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7767A8E0001; Mon, 1 Aug 2022 22:54:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 680D56B0071 for ; Mon, 1 Aug 2022 22:54:21 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 46E7540B5A for ; Tue, 2 Aug 2022 02:54:21 +0000 (UTC) X-FDA: 79753133922.26.0801A4F Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf22.hostedemail.com (Postfix) with ESMTP id E0432C0042 for ; Tue, 2 Aug 2022 02:54:20 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id 17so12374708pfy.0 for ; Mon, 01 Aug 2022 19:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VepS0pf6a4atZd971NuWbFl/YxaIYnEeNRklOESYwoQ=; b=aIMgFg5Mcp5VAH1+yGXzr6Wiq2zIyP2mAIKIpFmhkSFnrJWTYN0+u/YWcyFdKxpg2N P0Grm14hQzdZNpaNQ2NfJroY050rOKORL0QwOljWu5+FIkLI7cvTSmkKg9GAuDnHQ0L7 9JRAAkbbipcStDA3nG9C42x072PHKd9zo01XVX5ZVuUJDP5al22lsXkhuU2c6OqsD8Ik eD0xBQ4xM4Prx98nIriLb+8NaoHolPZShxdz4p39gAvZHvRnfl3nle2h5D1LMUGcAAT6 R1wkp5gKCphmr+9C8QaVYvJALbLi92drgtGo9fwIWJLWhgzWZxBDpCWwQ3WCxp5jwEAm //3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VepS0pf6a4atZd971NuWbFl/YxaIYnEeNRklOESYwoQ=; b=iaIVI8UZ3cWOg6OSiqnp4pqtUWpkaNxmZO18ZYyVwjS16NFUvxgQKbdOn3Mr164dRB 8YK58t6g7ro+vBAbNKXt1mhqLeoEKc+9SeD0CODWgFHmOqcOcj5cYkjMIKYc2OVXX8LD PtFEY6r+YwXWhQZadLzzd1UOsEkUkccNCH8WQtAnLO75FJCcqRu3ckZ4TIT4Ljs5bZwN giirBrGnSdFBf/DaqW+eKOeyXPg3aL48TfC0ibOMvimsp4FWCCnofkxQORyfjWxNOdU2 xwTHXXoziwk4T8LmRaA5MKIOtKdEcjAk3Y4sm1m+rdyOXQPuOrcqojVuye8Nm0LPjjUw ojDA== X-Gm-Message-State: AJIora9aE5LbK7J9gtufAbB/gwFAcsGauv1Ovn9328ooEPmxvvczDMcu hgQfHcspQPFr4cyiQV9a1QE= X-Google-Smtp-Source: AGRyM1v71zSrDIYf2Hqz2GlUg2dfTbZQDOwslUWYS1u1LGpDxUyHOairM1PxsNobGHx20I9U413IyA== X-Received: by 2002:a05:6a00:815:b0:52b:8895:a0bd with SMTP id m21-20020a056a00081500b0052b8895a0bdmr18917138pfk.57.1659408859816; Mon, 01 Aug 2022 19:54:19 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id d25-20020a656219000000b0041c3ab14ca1sm1836514pgv.0.2022.08.01.19.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 19:54:19 -0700 (PDT) Date: Tue, 2 Aug 2022 11:54:10 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Joe Perches , Vasily Averin , Matthew WilCox , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 06/15] mm/slab_common: fold kmalloc_order_trace() into kmalloc_large() Message-ID: References: <20220712133946.307181-1-42.hyeyoo@gmail.com> <20220712133946.307181-7-42.hyeyoo@gmail.com> <2e252179-0ffe-0d9c-9340-77e46f6ffdfd@suse.cz> <0ca2f22a-8247-8419-3f99-4456a4c7344a@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ca2f22a-8247-8419-3f99-4456a4c7344a@suse.cz> ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aIMgFg5M; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659408860; a=rsa-sha256; cv=none; b=dCPpFkj/EWU1V6vVXLv2ZOK+bm3PBpvwoaAj+0JiBQuHdxON24ZcxEXjYbdm1F3X5OFFiG CJ2b+Zhz+/bX1bHVDdd1vk9GsJcYNGq3rNbqViJNJkj+nyo+lCotFtTfDEnwxHx3XV0p0/ Q2a8w80d6qKeW3+M1EWkx9v4cS+V9vk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659408860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VepS0pf6a4atZd971NuWbFl/YxaIYnEeNRklOESYwoQ=; b=fhCyxde8Xx2uLMkH7F8tzQpY3jv1ltTvfM4jrj4DWkno8RlSz50i+aVcnaqhuuDCfmOlex ZrSob5KSdIn7/IVhRYyKQKdsyLOa9uhFq/LmQPRbr2N45zDLOqx95AiK4tWDVtLG+DrIGj E9iexUHIdriHB3A4DlVOC0tCwxh9nEQ= X-Stat-Signature: trsfstikps575d5m88gqf3q3yyowma93 X-Rspamd-Queue-Id: E0432C0042 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aIMgFg5M; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1659408860-120718 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 01, 2022 at 03:36:48PM +0200, Vlastimil Babka wrote: > On 8/1/22 15:26, Hyeonggon Yoo wrote: > > On Thu, Jul 28, 2022 at 05:23:29PM +0200, Vlastimil Babka wrote: > >> On 7/12/22 15:39, Hyeonggon Yoo wrote: > >> > There is no caller of kmalloc_order_trace() except kmalloc_large(). > >> > Fold it into kmalloc_large() and remove kmalloc_order{,_trace}(). > >> > > >> > Also add tracepoint in kmalloc_large() that was previously > >> > in kmalloc_order_trace(). > >> > > >> > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > >> > Reviewed-by: Vlastimil Babka > >> > > > > Thank you for review. > > > >> Hmm noticed a small change in how we call trace_kmalloc() which will now > >> include the __GFP_COMP. > > > > Good catch. > > > >> I think we could just call alloc_pages() from > >> kmalloc_large() with flags | __GFP_COMP instead of doing flags |= > >> __GFP_COMP; first. > > > > I'll consider that in next version. > > > >> AFAICS both kasan_kmalloc_large() and kmemleak_alloc() > >> will filter it out anyway. > > > > AFAIK not passing __GFP_COMP to both kasan_kmalloc_large() > > and kmemleak_alloc() will affect their behavior. > > You mean "will NOT affect...", right? Ah, yes. mistake. > > > - kasan_kmalloc_large() only checks if flag has __GFP_DIRECT_RECLAIM, > > - kmemleak_alloc() only use it to allocate kmemleak_object from > > slab/pool, which does not require __GFP_COMP. > > > > simply calling > > alloc_pages() with flags | GFP_COMP > > kasan_kmalloc_large() with flags > > kmemleak_alloc() with flags > > trace_kmalloc() with flags > > will be okay. > > > > BTW this is fixed after patch 9. > > Ah, right. __kmalloc_large_node_notrace() does the same flags |= > __GFP_COMP; but the tracepoint is outside and unaffected. I'll reflect your suggestion anyway. -- Thanks, Hyeonggon