From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE4EC00144 for ; Mon, 1 Aug 2022 08:47:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EA616B0071; Mon, 1 Aug 2022 04:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19A4A8E0001; Mon, 1 Aug 2022 04:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08B9F6B0073; Mon, 1 Aug 2022 04:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ECF876B0071 for ; Mon, 1 Aug 2022 04:47:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AA6DF140884 for ; Mon, 1 Aug 2022 08:47:13 +0000 (UTC) X-FDA: 79750394346.09.622CB08 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 3C440400E6 for ; Mon, 1 Aug 2022 08:47:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DCEDA60FB9; Mon, 1 Aug 2022 08:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1659343630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i3plC4gDCirp0/qEelmSAUkiw7vjt0l7z6WMBswDQpA=; b=kvjC6SkQ2jq0/pIqyrMLbUusGyMzDJgTpRqcOZB+GQy53XYapOoF+xKlAXR4Cyre0whHO2 oSKg3XevIukFCA/b4rkpJf9TIrsNdY5/MYcIMnyXCFW5abcsX72PGY8p+f9yCohFEDD15M idBdYfxPiuLIiCsrGQZWAWRAVXkS5/4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B6ED113A72; Mon, 1 Aug 2022 08:47:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nPMLKg6T52IMMwAAMHmgww (envelope-from ); Mon, 01 Aug 2022 08:47:10 +0000 Date: Mon, 1 Aug 2022 10:47:10 +0200 From: Michal Hocko To: Charan Teja Kalla Cc: akpm@linux-foundation.org, david@redhat.com, quic_pkondeti@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext Message-ID: References: <1659330397-11817-1-git-send-email-quic_charante@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1659330397-11817-1-git-send-email-quic_charante@quicinc.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659343632; a=rsa-sha256; cv=none; b=8jkFeFsNPj0fmMhF7vQyaQYty+zNQjsU0j/E6rirHR/kldeRDGKGIHkF2ixf1xqammUOqX zcuW4AiJOPYKoNqJBbgvqFgYFnyIhYDJADyI3/9KxvAZ+cFNB743m3iuijhEdwgHRNLN5s G83IpuLvtKnve3YWgaqoP1ExnqLeMHE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=kvjC6SkQ; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659343632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i3plC4gDCirp0/qEelmSAUkiw7vjt0l7z6WMBswDQpA=; b=v6u6Ut+OO8ovpuDfP04vkiy0ZFWNoiXg9pNttHGcFGJQOvypS6ldpeqObhQ4OpmrHGVw4i OmYVGo0s85GPdJqdheGmAdvo5gcsJlYQBUFTv1Q0DEVtyhKb3oyDDgjmGRr6SII15vcLtD eCslYUSoTZQlSKgpPLewjaGPQ3W1QgA= Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=kvjC6SkQ; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Stat-Signature: 9pxma3zph338iqfsbug3ojom774w9wyt X-Rspamd-Queue-Id: 3C440400E6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1659343632-547344 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 01-08-22 10:36:37, Charan Teja Kalla wrote: > Remove unused variable 'nid' in offline_page_ext(). This is not used > since the page_ext code inception. > > Signed-off-by: Charan Teja Kalla Acked-by: Michal Hocko Thanks > --- > mm/page_ext.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_ext.c b/mm/page_ext.c > index 3dc715d..e22a928 100644 > --- a/mm/page_ext.c > +++ b/mm/page_ext.c > @@ -336,7 +336,7 @@ static int __meminit online_page_ext(unsigned long start_pfn, > } > > static int __meminit offline_page_ext(unsigned long start_pfn, > - unsigned long nr_pages, int nid) > + unsigned long nr_pages) > { > unsigned long start, end, pfn; > > @@ -362,11 +362,11 @@ static int __meminit page_ext_callback(struct notifier_block *self, > break; > case MEM_OFFLINE: > offline_page_ext(mn->start_pfn, > - mn->nr_pages, mn->status_change_nid); > + mn->nr_pages); > break; > case MEM_CANCEL_ONLINE: > offline_page_ext(mn->start_pfn, > - mn->nr_pages, mn->status_change_nid); > + mn->nr_pages); > break; > case MEM_GOING_OFFLINE: > break; > -- > 2.7.4 -- Michal Hocko SUSE Labs