From: Michal Hocko <mhocko@suse.com>
To: Charan Teja Kalla <quic_charante@quicinc.com>
Cc: akpm@linux-foundation.org, david@redhat.com,
quic_pkondeti@quicinc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext
Date: Mon, 1 Aug 2022 10:47:10 +0200 [thread overview]
Message-ID: <YueTDphOhJgvB58e@dhcp22.suse.cz> (raw)
In-Reply-To: <1659330397-11817-1-git-send-email-quic_charante@quicinc.com>
On Mon 01-08-22 10:36:37, Charan Teja Kalla wrote:
> Remove unused variable 'nid' in offline_page_ext(). This is not used
> since the page_ext code inception.
>
> Signed-off-by: Charan Teja Kalla <quic_charante@quicinc.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks
> ---
> mm/page_ext.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index 3dc715d..e22a928 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -336,7 +336,7 @@ static int __meminit online_page_ext(unsigned long start_pfn,
> }
>
> static int __meminit offline_page_ext(unsigned long start_pfn,
> - unsigned long nr_pages, int nid)
> + unsigned long nr_pages)
> {
> unsigned long start, end, pfn;
>
> @@ -362,11 +362,11 @@ static int __meminit page_ext_callback(struct notifier_block *self,
> break;
> case MEM_OFFLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_CANCEL_ONLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_GOING_OFFLINE:
> break;
> --
> 2.7.4
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-08-01 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 5:06 Charan Teja Kalla
2022-08-01 5:28 ` Pavan Kondeti
2022-08-01 11:37 ` Charan Teja Kalla
2022-08-01 8:47 ` Michal Hocko [this message]
2022-08-01 9:07 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YueTDphOhJgvB58e@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=quic_charante@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox