[linux-next:master 4676/13542] drivers/remoteproc/rcar_rproc.c:45:20: sparse: sparse: incorrect type in argument 1 (different address spaces)

[linux-next:master 4676/13542] drivers/remoteproc/rcar_rproc.c:45:20: sparse: sparse: incorrect type in argument 1 (different address spaces)

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7c5e07b73ff3011c9b82d4a3286a3362b951ad2b
commit: d803336abdbc1bfacdb32b2cf9f4fdbee072b8ee [4676/13542] ARM: mm: kill unused runtime hook arch_iounmap()
config: arm-randconfig-s042-20220730 (https://download.01.org/0day-ci/archive/20220730/202207301837.luqV6gPB-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d803336abdbc1bfacdb32b2cf9f4fdbee072b8ee
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout d803336abdbc1bfacdb32b2cf9f4fdbee072b8ee
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash drivers/remoteproc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
   drivers/remoteproc/rcar_rproc.c:28:12: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void *va @@     got void [noderef] __iomem * @@
   drivers/remoteproc/rcar_rproc.c:28:12: sparse:     expected void *va
   drivers/remoteproc/rcar_rproc.c:28:12: sparse:     got void [noderef] __iomem *
>> drivers/remoteproc/rcar_rproc.c:45:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void volatile [noderef] __iomem *io_addr @@     got void *va @@
   drivers/remoteproc/rcar_rproc.c:45:20: sparse:     expected void volatile [noderef] __iomem *io_addr
   drivers/remoteproc/rcar_rproc.c:45:20: sparse:     got void *va

vim +45 drivers/remoteproc/rcar_rproc.c

285892a74f1370 Julien Massot 2021-12-07  40  
285892a74f1370 Julien Massot 2021-12-07  41  static int rcar_rproc_mem_release(struct rproc *rproc,
285892a74f1370 Julien Massot 2021-12-07  42  				   struct rproc_mem_entry *mem)
285892a74f1370 Julien Massot 2021-12-07  43  {
285892a74f1370 Julien Massot 2021-12-07  44  	dev_dbg(&rproc->dev, "unmap memory: %pa\n", &mem->dma);
285892a74f1370 Julien Massot 2021-12-07 @45  	iounmap(mem->va);
285892a74f1370 Julien Massot 2021-12-07  46  
285892a74f1370 Julien Massot 2021-12-07  47  	return 0;
285892a74f1370 Julien Massot 2021-12-07  48  }
285892a74f1370 Julien Massot 2021-12-07  49  

:::::: The code at line 45 was first introduced by commit
:::::: 285892a74f1370a12249f765c6a4e3b16194852e remoteproc: Add Renesas rcar driver

:::::: TO: Julien Massot <julien.massot@iot.bzh>
:::::: CC: Mathieu Poirier <mathieu.poirier@linaro.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [linux-next:master 4676/13542] drivers/remoteproc/rcar_rproc.c:45:20: sparse: sparse: incorrect type in argument 1 (different address spaces)

[Russell King (Oracle)]

On Sat, Jul 30, 2022 at 07:08:06PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   7c5e07b73ff3011c9b82d4a3286a3362b951ad2b
> commit: d803336abdbc1bfacdb32b2cf9f4fdbee072b8ee [4676/13542] ARM: mm: kill unused runtime hook arch_iounmap()

This is not a bug in this commit; this commit does not need fixing. This
is a bug in drivers/remoteproc/rcar_rproc.c:

struct rproc_mem_entry {
	void *va;

static int rcar_rproc_mem_alloc(struct rproc *rproc,
                                 struct rproc_mem_entry *mem)
{
        void *va;

	va = ioremap_wc(mem->dma, mem->len);


This is a bug.

static int rcar_rproc_mem_release(struct rproc *rproc,
                                   struct rproc_mem_entry *mem)
{
        iounmap(mem->va);

This is also a bug.

drivers/remoteproc/rcar_rproc.c needs fixing not to ignore the __iomem
annotation when dealing with iomem.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!