From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F33C04A68 for ; Sat, 30 Jul 2022 08:48:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D43448E0001; Sat, 30 Jul 2022 04:48:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF2696B0072; Sat, 30 Jul 2022 04:48:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE3418E0001; Sat, 30 Jul 2022 04:48:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AFD536B0071 for ; Sat, 30 Jul 2022 04:48:10 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 805F1120398 for ; Sat, 30 Jul 2022 08:48:10 +0000 (UTC) X-FDA: 79743139140.23.6C68CDF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf06.hostedemail.com (Postfix) with ESMTP id F3A3E1800C2 for ; Sat, 30 Jul 2022 08:48:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D663B81993; Sat, 30 Jul 2022 08:48:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C65B9C433D6; Sat, 30 Jul 2022 08:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659170887; bh=VgUDT0CHq5xXwgXx5dUDrl0wzXv+0S+jSbH+6URRswM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b/nRY3OEu7X4Lw6tfdqct/bqN21HMcA0HSjTu/cEPmk4+fz/kHgsi2s6U+rXc79mq wd2vv/fRHdos4RfUdYFkHiVMyHuteEbYflFleRD2NLvsZQzwZ6mLhEpNMFqU2W1Hfw mfldxJHLuKmUK0DhFUf/GHstEPWvJRjYzZ8V7zvpDuyoxEmBASZ5dHmFfq1lXmD49O x3OVh3gEco0SwzuLYj+PTnK5fySq53BIMdnuQ3SrkDT8OtT/fZW0QnQEgRylmle8pg LASGZ/vVD4d0+DL9aI2LLGX7+YZDsPXQy25gA8zHz5NFIp4C4TJ5/1siVTJi0WLqnD F9DrNfXJMay8g== Date: Sat, 30 Jul 2022 11:47:54 +0300 From: Mike Rapoport To: shaoqin.huang@intel.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] memblock test: Modify the obsolete description in README Message-ID: References: <20220729161125.190845-1-shaoqin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220729161125.190845-1-shaoqin.huang@intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659170890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5dHnFybLhXGG9Gy8Vqa2ismJBhuxykxpBNmbDsOiCdc=; b=VpclOX79F3sj91fV9bexG3hKMt73ItVj0oLrt+bcRuMYVA2ViGmBMZpJ/aCiVTMn3GxQzc P1UOpEMBqL8hH+ehN30AYtG3mlg4VZq2yFZ5FqCC9cFJR7jobThDi3vsb2PnPyuIBoY2n3 cakQ94/eNvrczbNM6LkdRvw1mI5+WMM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="b/nRY3OE"; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659170890; a=rsa-sha256; cv=none; b=nSdFLt6nGtnRPawVJuawg+duUnYZCyDaukXBu/8Gmag2I1QmWKybA6a5mbc8VUityacaaq mp7aSF4pKrSsm0VfXD9518cKfFdq4xEAAOC4DU2anTPLsFNEYL3xi+lMVOMBohn02vYPgR Bzn+XOCPrJ5mqsceZeR0i6mvpEimImU= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F3A3E1800C2 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="b/nRY3OE"; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: anstd6jxmwo38rj6yppbw8hq5tfzgh4h X-HE-Tag: 1659170889-490421 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 29, 2022 at 10:11:25AM -0600, shaoqin.huang@intel.com wrote: > From: Shaoqin Huang > > The VERBOSE option in Makefile has been moved, but there still have the > description left in README. For now, we use `-v` options when running > memblock test to print information, so using the new to replace the > obsolete items. > > Signed-off-by: Shaoqin Huang > --- > Changelog: > ---------- > v3: > - Using `build options` replace `options` to make it more clear. > v2: > - Tweak the sentence to make it more clear and continuesly. > - Commit log changes. > > tools/testing/memblock/README | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) Applied, thanks! > diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README > index 058146b528a5..72162b5f4a76 100644 > --- a/tools/testing/memblock/README > +++ b/tools/testing/memblock/README > @@ -33,20 +33,23 @@ To run the tests, build the main target and run it: > > $ make && ./main > > -A successful run produces no output. It is also possible to override different > -configuration parameters. For example, to include verbose output, specify the > -VERBOSE flag when building the main target: > +A successful run produces no output. It is possible to control the behavior > +by passing options from command line. For example, to include verbose output, > +append the `-v` options when you run the tests: > > -$ make VERBOSE=1 > +$ ./main -v > > This will print information about which functions are being tested and the > number of test cases that passed. > > -To simulate enabled NUMA, use: > +For the full list of options from command line, see `./main --help`. > + > +It is also possible to override different configuration parameters to change it > +test functions. For example, To simulate enabled NUMA, use: > > $ make NUMA=1 > > -For the full list of options, see `make help`. > +For the full list of build options, see `make help`. > > Project structure > ================= > -- > 2.30.2 > > -- Sincerely yours, Mike.