From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D84C00144 for ; Fri, 29 Jul 2022 22:03:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A8988E0001; Fri, 29 Jul 2022 18:03:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 856F86B0072; Fri, 29 Jul 2022 18:03:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71EA38E0001; Fri, 29 Jul 2022 18:03:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5F7826B0071 for ; Fri, 29 Jul 2022 18:03:24 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 387A9C10F7 for ; Fri, 29 Jul 2022 22:03:24 +0000 (UTC) X-FDA: 79741514328.23.33B0FC2 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf04.hostedemail.com (Postfix) with ESMTP id CF88A400BB for ; Fri, 29 Jul 2022 22:03:23 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id l9-20020a056830268900b006054381dd35so4203287otu.4 for ; Fri, 29 Jul 2022 15:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=RXWJjLRz7P9r1hNunIcpGJfPNUX5gzjTNT3qhw4Q8tc=; b=gBbVHOZCRQEC/xR/pKz52eY39CztxQaMuB22gkEz7v9ovzBeQZMjKvcNa58SKpeB6S X6ZR3csKR+tXv9VglmLTq4euN/XKZy3Q9iNNzEVEALpSkbjUms9TbORc9guZWmW3grMi WaFa1M7NCo0JqeOHqfYCLNXMNlyq0gpcnkQGh65L5TOx57hAM/+FF/2/0cW+h4fmhUgv EBTs9SIrjot83v/AdgBdAuiswROLcorb4eAs44X2WNwmXAZaDyJE/spadOkGzCguK3it ju+qZPUum7YY/JYJz+N3oBUqukxeudtyd3XvPi3wa6vKSTJ7VtPBUaalDsoeyoCQlkIK ZVsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=RXWJjLRz7P9r1hNunIcpGJfPNUX5gzjTNT3qhw4Q8tc=; b=bnuAtM1L2dpl6/RJ+OMB7IEde8LAWeKZbl6KoPG8HbS5FPFFj+1Fo/K+VePqjZkw09 nGEs8Qmm7V3Ks73HiqAcq3wBrVAMTpxi1Cb8mtyl+/ZYcP4066Bac7YkqMkzuYJM6xqc XmXCrqsXEw6OQ49jZLrAn3mg/0wgjtCNOP9DIIQPRLfzYX2AeRnHfyADMzUsMZwOKmi7 m4q3ynEMz7EsoHQDXf+MBu5FOih4e8QcGcZKv3aRWCC8By6vLEZW0i7AYYyz8xDIHcoh S/RXK+LTot+ZzsAQJYuN+EJ+mi5hrxTRCj6aL9krRWZ7AxN9Ry8HcI1xYvsrRKH+3Yqn eD5w== X-Gm-Message-State: AJIora8BVC39H/Q9Bx9I162vNrobSo25TOuVv3NnMxI0HIEfyhMRGmxe 9q/xrlPttD6JYwEmdS+5Wxw= X-Google-Smtp-Source: AGRyM1uxHqelv+2GP2cScl0HPfPe/tNoB5TLIAlvzfnUV2iBsdEDFUzqiKtuYqVT8K7ao4TXZ2JUNA== X-Received: by 2002:a9d:c65:0:b0:61c:bed2:622e with SMTP id 92-20020a9d0c65000000b0061cbed2622emr2144718otr.292.1659132202981; Fri, 29 Jul 2022 15:03:22 -0700 (PDT) Received: from bertie (072-190-140-095.res.spectrum.com. [72.190.140.95]) by smtp.gmail.com with ESMTPSA id 69-20020a9d02cb000000b0061c80736666sm1452425otl.28.2022.07.29.15.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 15:03:22 -0700 (PDT) Date: Fri, 29 Jul 2022 17:03:21 -0500 From: Rebecca Mckeever To: shaoqin.huang@intel.com Cc: rppt@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] memblock test: Modify the obsolete description in README Message-ID: References: <20220729161125.190845-1-shaoqin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220729161125.190845-1-shaoqin.huang@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659132203; a=rsa-sha256; cv=none; b=Qt2DjrUHmp6yMb7qCTE+AAcbxdJ7d0zJvAqNYmQrLe5RTGSA+gyUHmXeNawPiFA/TB4PQT 2Iu/8rQTfwNXZYtiqTnlovdhaPGMy6tAVV3TDIyRSq9MWzwt929iAh7BzIHIr2vXU+L5XD lFYbx7XzPT2laXhQjcDsCo5LS0iSsuI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gBbVHOZC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of remckee0@gmail.com designates 209.85.210.68 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659132203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RXWJjLRz7P9r1hNunIcpGJfPNUX5gzjTNT3qhw4Q8tc=; b=G7Y7KmHgQKHf70OIM8HXu6Pxga55v2WHWTCdmg38y6TWo2VnB9PiHkOELFeAHYxeM4qmoG bC3o1mqAx6mXxe1V9v1VGotO5PBBCgQJNZBJLcOUfYy0CmJABBc3CTF+SaSLXFYLEqm7OB yplyPN6qd9MrZLVjlb7lT/thvMwwsXE= X-Rspamd-Queue-Id: CF88A400BB X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gBbVHOZC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of remckee0@gmail.com designates 209.85.210.68 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Rspamd-Server: rspam09 X-Stat-Signature: wtezur7mg8gyabjgtu1y3o1rt4tgtf7g X-HE-Tag: 1659132203-531293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 29, 2022 at 10:11:25AM -0600, shaoqin.huang@intel.com wrote: > From: Shaoqin Huang > > The VERBOSE option in Makefile has been moved, but there still have the > description left in README. For now, we use `-v` options when running > memblock test to print information, so using the new to replace the > obsolete items. > > Signed-off-by: Shaoqin Huang > --- > Changelog: > ---------- > v3: > - Using `build options` replace `options` to make it more clear. > v2: > - Tweak the sentence to make it more clear and continuesly. > - Commit log changes. > Looks good! Acked-by: Rebecca Mckeever > tools/testing/memblock/README | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README > index 058146b528a5..72162b5f4a76 100644 > --- a/tools/testing/memblock/README > +++ b/tools/testing/memblock/README > @@ -33,20 +33,23 @@ To run the tests, build the main target and run it: > > $ make && ./main > > -A successful run produces no output. It is also possible to override different > -configuration parameters. For example, to include verbose output, specify the > -VERBOSE flag when building the main target: > +A successful run produces no output. It is possible to control the behavior > +by passing options from command line. For example, to include verbose output, > +append the `-v` options when you run the tests: > > -$ make VERBOSE=1 > +$ ./main -v > > This will print information about which functions are being tested and the > number of test cases that passed. > > -To simulate enabled NUMA, use: > +For the full list of options from command line, see `./main --help`. > + > +It is also possible to override different configuration parameters to change it > +test functions. For example, To simulate enabled NUMA, use: > > $ make NUMA=1 > > -For the full list of options, see `make help`. > +For the full list of build options, see `make help`. > > Project structure > ================= > -- > 2.30.2 > > Thanks, Rebecca