From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E589C00144 for ; Fri, 29 Jul 2022 14:35:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89CE66B0071; Fri, 29 Jul 2022 10:35:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84CB68E0002; Fri, 29 Jul 2022 10:35:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ED2A8E0001; Fri, 29 Jul 2022 10:35:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6049C6B0071 for ; Fri, 29 Jul 2022 10:35:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 285711A004B for ; Fri, 29 Jul 2022 14:35:37 +0000 (UTC) X-FDA: 79740385914.24.478AD91 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf17.hostedemail.com (Postfix) with ESMTP id 0D34C400C7 for ; Fri, 29 Jul 2022 14:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659105335; x=1690641335; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Fwz8XfsoWTAQMn6YI+beTtjBFPHAbaqLdcKiH2LGAyU=; b=Vwb5cDAfN7bXAwAs8eZZrzd16fEgwor+0B03NsnuBf5hWupPkdFNVSpN 9o3lE6z6xx4HX4bRFkFP/vObs/3iNWNxK3kvlMkRQv7UUWTyoNMHEaRKj TBPhY7qKHu0UAcsHvoKssiclzYjycG7ABc26c3JDB2rJpAA01TiBoLw83 WpGI0IZ7igBYdClHlRteTjYc7w5sn7wuXaGSRmf+m3j+h0rMSJ74ek02g gMLX5ESy5s0BHDxpBUre7XwYZanwgv0KA52BJh/4rs3p64PgBCkyevJ7z J3rLe2yJZ+UWFJd7OloLip639qcY8QUwMBfzShp1hcnnlMV98CyvSYcps A==; X-IronPort-AV: E=McAfee;i="6400,9594,10423"; a="287532572" X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="287532572" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 07:35:32 -0700 X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="669288400" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 07:35:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oHR5K-001eZm-10; Fri, 29 Jul 2022 17:35:26 +0300 Date: Fri, 29 Jul 2022 17:35:26 +0300 From: Andy Shevchenko To: Matthew Wilcox Cc: Mark Rutland , Jagdish Gediya , linux-kernel@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, dave.hansen@intel.com, Jonathan.Cameron@huawei.com, adobriyan@gmail.com, akpm@linux-foundation.org, rf@opensource.cirrus.com, pmladek@suse.com, will@kernel.org Subject: Re: [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Message-ID: References: <20220426180203.70782-1-jvgediya@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659105336; a=rsa-sha256; cv=none; b=4rJ53feHJgURB3UGa2EQotGFaUQU9wCQVySaUh8StpqY/zjh0VuFhkpmch1zL7gFAeUS0K 53IF/+3lEMcSnqphQLLFaQ70gj0VDAVkyS3eO7w6Ar/1axvxJwhorLnfFLpue1o5SRVyjp P1RJ3e0LloKSc+XLd6zMlzeBoI4wkRg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Vwb5cDAf; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659105336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6rkmZZL5S3MFSXrtdWMdWB/Fb4xXvClUDeSsNaT1Zgc=; b=RBwiYjneVFtBzyFtrjbeuBYaaAzW+HZe9BawnexF1D+Urz3/LFYwkQGGuAiVRqzf+t2pkw UWOYI8MVj/XKC6bRUSBgsgBZMOsWsKv7oDjxSC/mf8XlJZkyEPOYnzJINOUCZd3z/7FMct /ySb6/yeNvnCtgu1dDkitsj69cqa8ZM= X-Rspamd-Queue-Id: 0D34C400C7 X-Rspam-User: X-Stat-Signature: 4rg9y8x5s1siqo5uxpioqeo4kpcsez18 Authentication-Results: imf17.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Vwb5cDAf; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspamd-Server: rspam08 X-HE-Tag: 1659105334-434851 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 25, 2022 at 04:21:11PM +0100, Matthew Wilcox wrote: > On Mon, Jul 25, 2022 at 03:55:27PM +0100, Mark Rutland wrote: > > On Tue, Apr 26, 2022 at 11:32:02PM +0530, Jagdish Gediya wrote: > > > At many places in kernel, It is necessary to convert sysfs input > > > to corrosponding bool value e.g. "false" or "0" need to be converted > > > to bool false, "true" or "1" need to be converted to bool true, > > > places where such conversion is needed currently check the input > > > string manually, kstrtobool() can be utilized at such places but > > > currently it doesn't have support to accept "false"/"true". > > > > > > Add support to accept "false"/"true" as valid string in kstrtobool(). > > > > > > Signed-off-by: Jagdish Gediya > > > Reviewed-by: Matthew Wilcox (Oracle) > > > > I've just spotted that this broke arm64's "rodata=full" command line option, > > That isn't a documented option. > > rodata= [KNL] > on Mark read-only kernel memory as read-only (default). > off Leave read-only kernel memory writable for debugging. > > Hopefully this is an object lesson in why you need to update the > documentation when you extend a feature. > > > since "full" gets parsed as 'f' = FALSE, when previously that would have been > > rejected. So anyone passing "rodata=full" on the command line will have rodata > > disabled, which is not what they wanted. > > > > The current state of things is a bit messy (we prase the option twice because > > arch code needs it early), and we can probably fix that with some refactoring, > > but I do wonder if we actually want to open up the sysfs parsing to accept > > anything *beginning* with [tTfF] rather than the full "true" and "false" > > strings as previously, or whether it's worth reverting this for now in case > > anything else is affected. > > Well, that's going to break people who've started using the new option. > As a quick fix, how about only allowing either "f\0" or "fa"? I think we need to be more strict in kstrtobool(), i.e. 'f\0' ('t\0') and 'fal' ('tru') perhaps? -- With Best Regards, Andy Shevchenko