From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C1AC00144 for ; Fri, 29 Jul 2022 07:27:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C928B6B0071; Fri, 29 Jul 2022 03:27:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1B2C6B0072; Fri, 29 Jul 2022 03:27:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABC5B8E0001; Fri, 29 Jul 2022 03:27:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 97A0C6B0071 for ; Fri, 29 Jul 2022 03:27:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 69FA71610A9 for ; Fri, 29 Jul 2022 07:27:32 +0000 (UTC) X-FDA: 79739307144.05.63B7AC3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id E54861A0010 for ; Fri, 29 Jul 2022 07:27:31 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 71C25B8264A; Fri, 29 Jul 2022 07:27:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C863BC433C1; Fri, 29 Jul 2022 07:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659079649; bh=F53e3bQCi5VSjoYJytdJxDYdjCMvg5RkmdKiXFozHOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZRWAzYLEg1sS8ntUOOhIaAtUFUqYGWsM+tqTX1pelES2vWAeoACG57Ko68pA4jIEX wWqb+0lnIqUjDq7NIoyYiap5zZRO4/E3pJSbRYUnw5qVaLj7zxXCGn+Xri85GyGk51 /VWwfSXYMJ5tBNJJcoUp3wIxpFhP5l9jG1XlBaJ9AFEyyoUFaSC1F28j8EH3zZfPDd AiFk8FfKt5YNHjZe1sh/8+qGvDZgenxIrngqtBPELFc85ZDYVtc2c1VQ5mBWH/vT7X GvVvzjsdYiLNMFdNgRA+QWu2PqgzP8yR4fywI7oxypEP+fxNVcLbaW/AaQnwA+HsGm NOQ9wiKrfw9TA== Date: Fri, 29 Jul 2022 10:27:15 +0300 From: Mike Rapoport To: Liu Xinpeng Cc: mawupeng1@huawei.com, jrdr.linux@gmail.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] memblock tests: fix compilation errors Message-ID: References: <1658916453-26312-1-git-send-email-liuxp11@chinatelecom.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1658916453-26312-1-git-send-email-liuxp11@chinatelecom.cn> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659079652; a=rsa-sha256; cv=none; b=mNE26bzVfzPvLY+NtFx12JL6nzkAsFFIr42WimBsoyZuih+xz+QvMkbRJNltHsUQ3fKtJ4 45RYCiwv5GFrOfzYFBzSxfgrE4pxBm7kU+5Vr2hEXQ9AzhqV+1/yfPpk3528JjU3APw4GK Gsg9LrCzgCwjeFsZMppkZifqsoo3CGM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZRWAzYLE; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659079652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0gfS9aIkVL72JbDrZhdmFA55TfqL0y7P9rGge5qQ6TA=; b=3lBhyh7VsOGoqFbzWmmgYOunyCrrdA8fSdR51YnPc3L2YuPyD9ZfxSbGJSMXGSHH7U5CH3 Nn746RDkYUbFAj6ZpBa9auqsH82ZhJdCfPDypn9zIioSHmBzXAGxZA7Fk3m/qX/Lisapky qvh+3+7rlOI+jM4hk+DEB0Iv7H94r5k= X-Rspamd-Queue-Id: E54861A0010 X-Rspam-User: X-Stat-Signature: 7s5ngx8nh5zztjwmnoaf3t6f8rhxnx45 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZRWAzYLE; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam08 X-HE-Tag: 1659079651-965259 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 27, 2022 at 06:07:33PM +0800, Liu Xinpeng wrote: > Do 'make -C tools/testing/memblock', get the following errors: > > memblock.o: In function `memblock_find_in_range.constprop.9': > memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' > memblock.o: In function `memblock_mark_mirror': > memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' > > Fixes: 902c2d91582c ("memblock: Disable mirror feature if kernelcore is not specified") > Fixes: 14d9a675fd0d ("mm: Ratelimited mirrored memory related warning messages") > > Signed-off-by: Liu Xinpeng > Tested-by: Ma Wupeng Applied, thanks! > --- > Changelog: > V3 -> V4: Changed the title and add how to reproduce this issue. > V2 -> V3: Fixs should not have word wrap. > V1 -> V2: Removed comma in macro define and addressed review comments. > --- > tools/testing/memblock/internal.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h > index c2a492c05e0c..fdb7f5db7308 100644 > --- a/tools/testing/memblock/internal.h > +++ b/tools/testing/memblock/internal.h > @@ -9,6 +9,10 @@ > static int memblock_debug = 1; > #endif > > +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__) > + > +bool mirrored_kernelcore = false; > + > struct page {}; > > void memblock_free_pages(struct page *page, unsigned long pfn, > -- > 1.8.3.1 > -- Sincerely yours, Mike.