From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3726C04A68 for ; Thu, 28 Jul 2022 09:02:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D088D6B0071; Thu, 28 Jul 2022 05:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB84A6B0072; Thu, 28 Jul 2022 05:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA8498E0001; Thu, 28 Jul 2022 05:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AB0C36B0071 for ; Thu, 28 Jul 2022 05:02:07 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 58E3C1413E5 for ; Thu, 28 Jul 2022 09:02:07 +0000 (UTC) X-FDA: 79735916694.07.2E03736 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 2384FC00BA for ; Thu, 28 Jul 2022 09:02:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2780F61C31; Thu, 28 Jul 2022 09:02:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C0B5C433C1; Thu, 28 Jul 2022 09:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658998924; bh=GRgdNTJ8PYQp/lGN9oA41yePt1HnQHalvV+J4FRauOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bYjds+F/mT8xbCAb8xnhSIbva+I4XQG4q8eLZb092m7gPpKrTB0IM91BGjYZ8J3xO ZK51pJxeBbCyGQkFreBQh+AGC8sbPsIkiH98omsmCgJo2tz7WBD1vgzwmFGkWmw92y qaueSsNXJUsCJgqoZGEjxAX8Vxkv/NF5n9Zo+VYFth8Yvik3Px8SkLOJctkYWesmx9 mrJZn75evlcJWowAzEncawFJB3C/JhABKdqVNWo/48OUjRijOGie0iKwrHO3X2jQZt 9GKBAByRjeJWgeQ+Fzdqd88HmlilA2qZA8OtPEzcj1CJyNn4ce+eWc532gcDVXzveb 0JqTHQ8rn6mEA== Date: Thu, 28 Jul 2022 12:01:52 +0300 From: Mike Rapoport To: "Huang, Shaoqin" Cc: Rebecca Mckeever , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memblock test: Modify the obsolete description in README Message-ID: References: <20220728011228.23691-1-shaoqin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bYjds+F/"; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658998926; a=rsa-sha256; cv=none; b=H3SSm3ssNnwiZ8PJfGsols8RQJyd4rQCIAz6C4d6EOSuVOULGKWEOm9HDH+x5+t+Z/tDSC hs0cYjSfF3+Z19jtQBbieCahNqGk6aXAw1Q8totY87XbS3ekIKzMcc6rkMoIrZIIAk4b6U KXfhaLNqa8UNJBBOlIRnKgx3ipK2hls= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658998926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o2Ni0KFmZ0byrKYCPOLZBmDoDMPlATct27I0SyMjWhA=; b=UopQ0HhmX+PlECBF+Cdw35xEwABws05aTx7gh6i0Ql7Xnvq+CaxluZS9jDocbcnvsGf+nc Lr4n6j8/Qnkp+PN1IXV9tIqG8K9oNetpcnxF3JETxV+7XVttqjvxHF+EqdXciBu2Bg5eGs C1Pwfj2/8Drvj3sUs0FGxvihNzqCUAo= X-Stat-Signature: qo6yq7fg17tedcxuwupbki8pz3738qac X-Rspamd-Queue-Id: 2384FC00BA X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bYjds+F/"; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam12 X-HE-Tag: 1658998925-5508 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 28, 2022 at 01:08:25PM +0800, Huang, Shaoqin wrote: > > > On 7/28/2022 12:05 PM, Rebecca Mckeever wrote: > > On Wed, Jul 27, 2022 at 07:12:28PM -0600, shaoqin.huang@intel.com wrote: > > > From: Shaoqin Huang > > > > > > The VERBOSE option in Makefile has been moved, but there still have the > > > description left in README. For now, we use `-v` options when running > > > memblock test to print information, so using the new to replace the > > > obsolete items. > > > > > Thanks for catching this! > > > > > Signed-off-by: Shaoqin Huang > > > --- ... > > > This will print information about which functions are being tested and the > > > number of test cases that passed. > > > -To simulate enabled NUMA, use: > > > +For the full list of options from command line, see `./main --help`. > > > > --help will display the list of command line options by default, but a > > help command line option isn't explicitly implemented. I'm planning to add > > the help option, so if you want to remove this sentence, I will add it when > > I implement the help option. > > Hi, Rebecca. > > That's ok. I didn't notice the --help has not been implemented. So I can > remove the line: > -For the full list of options from command line, see `./main --help`. > > But after remove it. There seems a little stranger about how to get the full > list of options at the time. How do you think about it? I '--help' option is implemented, it just does not list help for itself. I think it's fine to keep the "For the full list..." line. -- Sincerely yours, Mike.