From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB49C04A68 for ; Thu, 28 Jul 2022 04:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B1D66B0071; Thu, 28 Jul 2022 00:05:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9619D6B0072; Thu, 28 Jul 2022 00:05:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829118E0001; Thu, 28 Jul 2022 00:05:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6FFFE6B0071 for ; Thu, 28 Jul 2022 00:05:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3F1031A01C7 for ; Thu, 28 Jul 2022 04:05:10 +0000 (UTC) X-FDA: 79735168380.22.F4FCD09 Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) by imf30.hostedemail.com (Postfix) with ESMTP id DCB43800C8 for ; Thu, 28 Jul 2022 04:05:09 +0000 (UTC) Received: by mail-oo1-f67.google.com with SMTP id p5-20020a4a4805000000b0043548dba757so94770ooa.8 for ; Wed, 27 Jul 2022 21:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w3ZvXOi58iLmqXMoB+Pk7kq83LCFc7KsAO1ebX7B/ns=; b=VBVapj9fDuUiMhOo/t74oJiah7FQ707LUH5LhxoEV8hLE6VycGQR/JzM0ewWtMOJ3n aZ+Zo+0e7VjDdrb+kFSBwHTcnA5BqysI1uEkg8wtC5COCY1Zb95dWLUopVzpE6J2Ayjw sRCxKpmRQYIe60tcTmGFmDb2vCAvBEnl+7MQRI2WBRJIdWCJxxvB7afELQB/xkbPhD2N hZBGrGHXBvkSLCkEMHO9+4h0y5kLtIUlKaU3JOG1TY8DMW5j4bMhHqHvwBhkwxsark+o U/55J70Z9/v4WtFH0yn4FvkWcW7kXtV6icUxUv24PFLEDvjO+TPN+ExbioDbx4Z/kR9m tDLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w3ZvXOi58iLmqXMoB+Pk7kq83LCFc7KsAO1ebX7B/ns=; b=ctUmC49xR5MRBZI1REohyeVUXugc63UixRRvXRjw0BdZNtIjet8iXMZc2oORzM1x4c VyAT1zB5QDFphEjIyiswXp2lzWODncIwop9K5CzvUQwIwdqEIg9ddAB16/k6/+lf0HkQ jukEi+iWT6DWQAvMEfeqOF3yl+ImZa3OODMzQsVFjQ0BzRkDJpQQfOKM7QnxSeg4VJa8 hC1tnLeaz/4sQj1vZ1LP9r0x7myZ7V6H6/hpc6W+ClAUTqN2ybP3dIHBb75vVCzK2mLN j4kPvoY4XFo+/aimpEsUyZtiIUMXD1DDuhH4dCbUilIn4K+mMTOmFWj0Cf9LdHDkFw9j 9tUQ== X-Gm-Message-State: AJIora9FQQETiHJkW6UzFm2siRzb58mTrxE19324FPGQjs5JeHihdAGG cngo8V82/X/eAk/2e9ahqCs= X-Google-Smtp-Source: AGRyM1sls4qhxEGs/5y1MoMOolLttyl41O5u8SrzAGP7Y01XjkxIZegy9jWSkSkrKjRvBVnSSNfXyA== X-Received: by 2002:a05:6820:16aa:b0:435:acba:37ef with SMTP id bc42-20020a05682016aa00b00435acba37efmr8831262oob.69.1658981109070; Wed, 27 Jul 2022 21:05:09 -0700 (PDT) Received: from bertie (072-190-140-095.res.spectrum.com. [72.190.140.95]) by smtp.gmail.com with ESMTPSA id k1-20020a544401000000b0033aef871695sm3383781oiw.16.2022.07.27.21.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 21:05:08 -0700 (PDT) Date: Wed, 27 Jul 2022 23:05:01 -0500 From: Rebecca Mckeever To: shaoqin.huang@intel.com Cc: rppt@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memblock test: Modify the obsolete description in README Message-ID: References: <20220728011228.23691-1-shaoqin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728011228.23691-1-shaoqin.huang@intel.com> ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VBVapj9f; spf=pass (imf30.hostedemail.com: domain of remckee0@gmail.com designates 209.85.161.67 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658981109; a=rsa-sha256; cv=none; b=pu4fpvOvfF8ecb0PwQ8kP00NqixJUD0saG4jhguPRy+xOZakCCKzROdPrKIfsBqgiXexa6 QifdsnuEf0PyhIit/onbqsDVDOWYpH9vUYoTB48GDlO/XJHpUUj0lEOCrWUEn6nsIKViP+ z7ETqAXhjAGBN3wAWd95IgqrKSh4n+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658981109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w3ZvXOi58iLmqXMoB+Pk7kq83LCFc7KsAO1ebX7B/ns=; b=ZfF+ENDHvTeakUo7y+aBNwehuiQ5lQ022UR1BoGEF2543uCFxa+FzC7E7PUQHKBpv/O42b xOSF4S2nSzxoxASoCStZP5PeAKmKgkZIv77DXNft4EKB75K76QMWOjyAdKh1ZShZPX39xg KaKAOBaUp3SMVwQBriJBO2jt628CIvI= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VBVapj9f; spf=pass (imf30.hostedemail.com: domain of remckee0@gmail.com designates 209.85.161.67 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DCB43800C8 X-Stat-Signature: h37eex9toch9ka9fad7yb159ez5oeeqc X-HE-Tag: 1658981109-12442 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 27, 2022 at 07:12:28PM -0600, shaoqin.huang@intel.com wrote: > From: Shaoqin Huang > > The VERBOSE option in Makefile has been moved, but there still have the > description left in README. For now, we use `-v` options when running > memblock test to print information, so using the new to replace the > obsolete items. > Thanks for catching this! > Signed-off-by: Shaoqin Huang > --- > Changelog: > ---------- > v2: > - Tweak the sentence to make it more clear and continuesly. > - Commit log changes. > > tools/testing/memblock/README | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README > index 058146b528a5..d3875e7065fd 100644 > --- a/tools/testing/memblock/README > +++ b/tools/testing/memblock/README > @@ -33,16 +33,19 @@ To run the tests, build the main target and run it: > > $ make && ./main > > -A successful run produces no output. It is also possible to override different > -configuration parameters. For example, to include verbose output, specify the > -VERBOSE flag when building the main target: > +A successful run produces no output. It is possible to control the behavior > +by passing options from command line. For example, to include verbose output, > +append the `-v` options when you run the tests: > > -$ make VERBOSE=1 > +$ ./main -v > > This will print information about which functions are being tested and the > number of test cases that passed. > > -To simulate enabled NUMA, use: > +For the full list of options from command line, see `./main --help`. --help will display the list of command line options by default, but a help command line option isn't explicitly implemented. I'm planning to add the help option, so if you want to remove this sentence, I will add it when I implement the help option. > + > +It is also possible to override different configuration parameters to change it > +test functions. For example, To simulate enabled NUMA, use: > > $ make NUMA=1 > Maybe you could add "build" before "options" in the line after this: -For the full list of options, see `make help`. +For the full list of build options, see `make help`. > -- > 2.30.2 > >