From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E60C04A68 for ; Wed, 27 Jul 2022 09:41:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C332694000E; Wed, 27 Jul 2022 05:41:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBC17940009; Wed, 27 Jul 2022 05:41:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAA6694000E; Wed, 27 Jul 2022 05:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 986FC940009 for ; Wed, 27 Jul 2022 05:41:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 752D0120BC5 for ; Wed, 27 Jul 2022 09:41:14 +0000 (UTC) X-FDA: 79732386468.04.09D3D8D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id D1E152009F for ; Wed, 27 Jul 2022 09:41:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7B9AB81FF9; Wed, 27 Jul 2022 09:41:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED1CBC433C1; Wed, 27 Jul 2022 09:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658914870; bh=QPFk5LyXjXwuPDjKAAtyafwy5DsakHirnFpbMfhIawI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IfIXgJB65HnWZg6RjOxNuOgNxV6yMennna8GEwqJKo4d7Te9L7oadEfrtuSUeK3vp lZeOUpcer0JohUmVvKZybOmsJRuHRswcAhNWaapszb1SosXCqe8o8xonEEJH4R4YrR wt9JPaY3VFFmlNiI7EKlamvp+La7DhEKXJ8r6gv8qde8FSPIW0yVsTjGl0IXoFBx5G pEZRhYetpOiWJ1AME7hobDfKw49kKSYovIVBuOar+lkioYjp7KbTqpJRKVIfWvw72e G6IdxzRvXVrQDG3XFOClV7ACXkG4I78Gbi0o2oQrjXhQi3d/NchL76yFpNTR5+fikI I8zVX9BkzLT8w== Date: Wed, 27 Jul 2022 12:40:57 +0300 From: Mike Rapoport To: shaoqin.huang@intel.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rebecca Mckeever , David Hildenbrand Subject: Re: [PATCH] memblock test: Modify the obsolete description in README Message-ID: References: <20220728001615.19099-1-shaoqin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728001615.19099-1-shaoqin.huang@intel.com> ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IfIXgJB6; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658914874; a=rsa-sha256; cv=none; b=vDsoTWM3pFqoyPycFz/MPhJB9MqUaoFxGJ79Kqr/rPThOeQMhd5PsMgvPC8aGqeYK+uDcv A3T/xKekwFd8MFL/kTFtQ9uaJyjDEdNW6TQPOegM0tnHTVBe9ZDyLWBEPcyqWPZb0Sjs4I VTlWXUU7t7HqC1ExjWb/v9dFn4aM2to= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658914874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NMSAuBRxeqbkAWqQnVRkUYfalAvLOOuJP4KkEwaNeRA=; b=voUU0buRzcOkAsss0eYqwEnEDFldGrhbmd+B2xY0NKZkTU7YNtxi4sTyOTCOJueI1ILJjF haGnoJ4BbbyJWh5FMM97Ym2p36fQ8ap6jjDJBvwwWm/1BVxVxn/5qClRg6SUYCB6M2Srol WsSgWt921G1UZKP9+u6gvhbKpwOkZ8I= X-Stat-Signature: j65m7tpqznb9u4oh8f3eftn6wg99s1z9 X-Rspamd-Queue-Id: D1E152009F X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IfIXgJB6; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam12 X-HE-Tag: 1658914873-315611 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 27, 2022 at 06:16:15PM -0600, shaoqin.huang@intel.com wrote: > From: Shaoqin Huang > > The VERBOSE option in Makefile has been moved, but there still have the > description left in README. For now, we use `-v` options when running > memblock test to print information, so also add some description about > it. > > Signed-off-by: Shaoqin Huang > --- > tools/testing/memblock/README | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README > index 058146b528a5..f39cc0aa6b76 100644 > --- a/tools/testing/memblock/README > +++ b/tools/testing/memblock/README > @@ -33,20 +33,21 @@ To run the tests, build the main target and run it: > > $ make && ./main > > -A successful run produces no output. It is also possible to override different > -configuration parameters. For example, to include verbose output, specify the > -VERBOSE flag when building the main target: The description of VERBOSE build option was a logical continuation of the previous sentence. Instead of doing mechanical changes, please rearrange the text so it'll make sense. > +A successful run produces no output. It it also possible to override different > +configuration parameters. For example, to simulate enabled NUMA, use: > > -$ make VERBOSE=1 > +$ make NUMA=1 > > -This will print information about which functions are being tested and the > -number of test cases that passed. > +For the full list of options, see `make help`. > > -To simulate enabled NUMA, use: > +It is also possible to pass options at run time. For example: > > -$ make NUMA=1 > +$ ./main -v > > -For the full list of options, see `make help`. > +This will print information about which functions are being tested and the > +number of test cases that passed. > + > +For the full list of options, see `./main --help`. > > Project structure > ================= > -- > 2.30.2 > > -- Sincerely yours, Mike.