From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 860A8C00140 for ; Sat, 6 Aug 2022 00:04:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E23CB6B0071; Fri, 5 Aug 2022 20:04:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3648E0001; Fri, 5 Aug 2022 20:04:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9B226B0073; Fri, 5 Aug 2022 20:04:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B7EE76B0071 for ; Fri, 5 Aug 2022 20:04:35 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8A5DFA031A for ; Sat, 6 Aug 2022 00:04:35 +0000 (UTC) X-FDA: 79767221310.30.9017F2A Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf07.hostedemail.com (Postfix) with ESMTP id E5D3040126 for ; Sat, 6 Aug 2022 00:04:34 +0000 (UTC) Date: Fri, 5 Aug 2022 17:04:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1659744273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SNPSSSNCcsODM6FcDFTB0/QY2xvnSXXiMzXUqFnL7G8=; b=FXngCiEGbKvBUUX68HPXzkns0r27XmBrR+fYTljzWMaejRXpC9hRR4viZ8aYC+gc0IktZM y3QjaRpKHUXg+3r+d7U67kpVNj7nf2HYBHqBMJuL19JyLOVtve5YQyaSHgqsA/bkihSR28 5aplmwopU8LWek5bL786EIuMKHeFqfA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Linus Torvalds Cc: Andrew Morton , Kent Overstreet , mm-commits@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner Subject: Re: [GIT PULL] MM updates for 5.20-rc1 Message-ID: References: <20220803133541.18b82ec9344ed0e8b975fe5b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FXngCiEG; spf=pass (imf07.hostedemail.com: domain of roman.gushchin@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659744275; a=rsa-sha256; cv=none; b=NgA87iG8B7GhroNkIP89K818JK0h1rRGCpqKE9cxi3YoD3KOeUS6DVkcqw8Kla8n8P+4yS 7avZT/yDh9woKDF5mVYi1eSGzP+ue1RGEVyq7E1oexsi7XYkC4m/2yNCRZXMApidMjOE8Z Spv3Sql9bsmzR+dEaLC6PhEHRaiVHTg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659744275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SNPSSSNCcsODM6FcDFTB0/QY2xvnSXXiMzXUqFnL7G8=; b=uV8T+UQZMC/OcggKpzXJpmDnaDIgi+E6xK4VHrbhtC4aQO8tNnUMwnWyYWbRv9u8E0ollb 7vXkpvsnR1X+4pWPLDasy3JN3jv3AmoQyh5v6YWeHX/nStb1Qsfo20bKXCVR1j8tVsB+oa CCl6S9PSCJ9cZ3yGTrTr5PjKucq1PrE= X-Stat-Signature: g3rxbgjqer3bbcuf1od7g7dw7csppbng X-Rspamd-Queue-Id: E5D3040126 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FXngCiEG; spf=pass (imf07.hostedemail.com: domain of roman.gushchin@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1659744274-254187 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 05, 2022 at 04:32:34PM -0700, Linus Torvalds wrote: > On Wed, Aug 3, 2022 at 1:35 PM Andrew Morton wrote: > > > > - memcg debug/visibility work from Roman Gushchin > > Well, not just memcg. > > There's that new CONFIG_SHRINKER_DEBUG too. > > Which looks like yet another "people add Kconfig options incorrectly". > > We don't make new features "default y" unless there's some truly > pressing reason for it (ie "99.9% of all people will want this" or "we > used to always compile this in, now it's optional"). Hi Linus! It actually was 'default n' in one of the earlier version of the patchset and has been switched to 'default y' based on the following feedback from Dave Chinner (https://lore.kernel.org/lkml/YmiWK56bOHyrr64u@rh/): No. The argument that "if we turn it off there's no overhead" means one of two things: 1. nobody turns it on and it never gets tested and so bitrots and is useless, or 2. distro's all turn it on because some tool they ship or customer they ship to wants it. Either way, hiding it behind a config option is not an acceptible solution for mering poorly thought out infrastructure. Personally I think that the feature is not that useful for the majority of users (this is why default was n), but it's not adding much of the overhead, so I had no strong reasons to oppose Dave. Cc'ing him just in case. Thanks!