From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE9FC00140 for ; Fri, 5 Aug 2022 18:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C66596B0071; Fri, 5 Aug 2022 14:14:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C165D8E0001; Fri, 5 Aug 2022 14:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADDFD6B0073; Fri, 5 Aug 2022 14:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9F27B6B0071 for ; Fri, 5 Aug 2022 14:14:40 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 78D4FAC313 for ; Fri, 5 Aug 2022 18:14:40 +0000 (UTC) X-FDA: 79766339520.15.241EFFF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id EE66B40142 for ; Fri, 5 Aug 2022 18:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659723279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JFlgXAOeQvAo2VQxtr1S0aAKuStavDrI9zg1bwCkjgk=; b=bdhWsMWUKHszkCZ2fIdT00dihf5V2+B2owKaIj+4NgvAdfoDOLhRu2gAiA9JHz14Gai3/b QJ4ZSEp72RgUgQprvAcmkghc72mfU9h+nSKWVFrVDNBmxo480ZA0NyLdsoCRlpacLy6wkb fgHIlULvm0Qf5eL+pwbPRDqIe+5GJEY= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-371-EjCxEEpoM1SkQZYgPMXn0g-1; Fri, 05 Aug 2022 14:14:37 -0400 X-MC-Unique: EjCxEEpoM1SkQZYgPMXn0g-1 Received: by mail-qv1-f69.google.com with SMTP id o9-20020a0cecc9000000b0047491274bb1so1797843qvq.19 for ; Fri, 05 Aug 2022 11:14:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=JFlgXAOeQvAo2VQxtr1S0aAKuStavDrI9zg1bwCkjgk=; b=okkBFJ50alJKQhJHhAADSLxhQy9Q/E6JmujA5bN6H22VQV93b/O9kA1LpjssVH1sMf ViKZp/e5Pg40vp5GYut0RVxngqcsGshNmvGQ59XtGdEHMELP4ZEjkxLroip9P9BMaQM7 f/6NSLg1deSwboLkR+ng/Clpn3H/X00m01qhwyrjupmWiHGSnFMv5kghiL55Ly6TkdsB IU5JWIlSs25K5CtD9ssa9hp+nV5j6q25VruvjomrnJh5pom2O2jlq+DHy0/AmCbE2+Ba B+pBsYfkeHC+tTnbXR93+lIxixULk21KZKDcPCWsBEeknoP16EjBkplBIo8vxlI70AEa ygyw== X-Gm-Message-State: ACgBeo0z3QtkEDCbst/w/Cjwq+PonWl4TYxbwRkhdGQxemEC6o1HkNjx IpDfwl6dew49gpX5KNKnqDxXLT9FQ0SVxM8pMtRgN3iEYaVo9OsigU5oPKigZlT4x0gpYebpgHz 4Avv7BGIJHo4= X-Received: by 2002:a05:6214:c6c:b0:476:97d8:4445 with SMTP id t12-20020a0562140c6c00b0047697d84445mr6758405qvj.19.1659723276930; Fri, 05 Aug 2022 11:14:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR5j1hEQTJoVPFydvn1kx4gLZZz+vdtoIGznvH6S3I2ZX5BXyCUql4S5PuEXABKZUBzzNHN/FQ== X-Received: by 2002:a05:6214:c6c:b0:476:97d8:4445 with SMTP id t12-20020a0562140c6c00b0047697d84445mr6758393qvj.19.1659723276683; Fri, 05 Aug 2022 11:14:36 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id j7-20020ac86647000000b0031f0485aee0sm2971335qtp.88.2022.08.05.11.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 11:14:36 -0700 (PDT) Date: Fri, 5 Aug 2022 14:14:34 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song , Peter Feiner , "Kirill A . Shutemov" , stable@vger.kernel.org Subject: Re: [PATCH v1 1/2] mm/hugetlb: fix hugetlb not supporting write-notify Message-ID: References: <20220805110329.80540-1-david@redhat.com> <20220805110329.80540-2-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220805110329.80540-2-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659723280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JFlgXAOeQvAo2VQxtr1S0aAKuStavDrI9zg1bwCkjgk=; b=OaXrs1a3v36Fc/qW7M5lXf2qTWqyZq5W6uEd/93vOwSPSjioXKj8g7QWeom91x2P3ihDDd yWYdiv/WH6kyV8JmdturHMxuybCYjNZhUGm/+hKbCch1Ycz23cGQsApW52ks9GXoaOJjv1 glJTJ0hf51uh2N/i0UAjxCaW9EWIn38= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bdhWsMWU; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659723280; a=rsa-sha256; cv=none; b=cyGJUkZmU/rYm41cw68fYK8NZ1Lxu/xeZraBKRGDf0vbfnea8FIyyCucILxpdTD5P0ZI3W aAwllWEEr+DCiu6SmXh7tvuSzSqla9j4bJQhuRv2p1HR9ul2aaaBK+5qoRZNbDd3O+ekhi NrCJJXlzRHb2R/P9Fya5/WDpRppZarA= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bdhWsMWU; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EE66B40142 X-Stat-Signature: h15yayj9akssyozajgmki9ohub569yte X-Rspam-User: X-HE-Tag: 1659723279-946438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 05, 2022 at 01:03:28PM +0200, David Hildenbrand wrote: > diff --git a/mm/mmap.c b/mm/mmap.c > index 61e6135c54ef..462a6b0344ac 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1683,6 +1683,13 @@ int vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot) > if ((vm_flags & (VM_WRITE|VM_SHARED)) != ((VM_WRITE|VM_SHARED))) > return 0; > > + /* > + * Hugetlb does not require/support writenotify; especially, it does not > + * support softdirty tracking. > + */ > + if (is_vm_hugetlb_page(vma)) > + return 0; I'm kind of confused here.. you seems to be fixing up soft-dirty for hugetlb but here it's explicitly forbidden. Could you explain a bit more on why this patch is needed if (assume there'll be a working) patch 2 being provided? Thanks, -- Peter Xu