From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D820C43334 for ; Sun, 24 Jul 2022 07:18:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E35AC6B0072; Sun, 24 Jul 2022 03:18:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE4D76B0073; Sun, 24 Jul 2022 03:18:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD3F96B0074; Sun, 24 Jul 2022 03:18:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD01B6B0072 for ; Sun, 24 Jul 2022 03:18:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8A3F241129 for ; Sun, 24 Jul 2022 07:18:57 +0000 (UTC) X-FDA: 79721141514.09.1752D6E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 099101C00AF for ; Sun, 24 Jul 2022 07:18:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 036EA60DE7; Sun, 24 Jul 2022 07:18:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D85E2C341C0; Sun, 24 Jul 2022 07:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658647135; bh=cilKIlwRX04/ZKOXRDFJP5xqs9Q3uNUGrabQaZJDLLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j3WH1Wi1dbsD67j89JBDezOse91s5xYCoDwsT6nHSrW4o7eLNPdwJoMEVL9XYG44E v+peqz/qnKjCwVbrSC6aUeMO3x8XiHy44MncJU6eieR2h4MxGWAsXbaQlWjS1y6Jax uwbP74TrDuvey7rGo+63ttT9Ma+huBfPZD7pTpbo= Date: Sun, 24 Jul 2022 09:18:52 +0200 From: Greg KH To: Jianglei Nie Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/damon/reclaim: fix potential memory leak in damon_reclaim_init() Message-ID: References: <20220724065224.2555966-1-niejianglei2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220724065224.2555966-1-niejianglei2021@163.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658647137; a=rsa-sha256; cv=none; b=7dT2xnZ/s2lPKvYkxTksRu7zJ9G9pV2tOtBXawGdzswVZipzO18xDczXKHugOA5wPp45o/ 4ZA6E8t41PtBRtJr1RMmnbU2RkMbVwMJ+z1D/Z7CHLFxrMWKkJCJbXXiW3sqERxiQytWnI T8OzCatEimmsWbiELdpE4tHRhZz3EG8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=j3WH1Wi1; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658647137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dpNagSI2bFC6I2IV51/vPjNxbPqO3+VsQhUx1eiC+1o=; b=sS6zpYOYnduixT13errfj1Rf5PD+AiduXkyg5xeLBhkAEBr7IWR5nzgmgMrAt0fYOF0i8R cG3SkFVMnl/VxBDxbHrnq0PXfqW0no4I/AkWTzxQ9Go0CF98s6MJpmINMAAIrA8H29Me/p hN9r+y7SThHTNIa9OjdxZa+Ne88LwAg= X-Rspamd-Queue-Id: 099101C00AF Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=j3WH1Wi1; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 64wabf7444a8746nsb5rshfeby914y1e X-HE-Tag: 1658647136-819351 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 24, 2022 at 02:52:24PM +0800, Jianglei Nie wrote: > damon_reclaim_init() allocates a memory chunk for ctx with > damon_new_ctx(). When damon_select_ops() fails, ctx is not released, which > will lead to a memory leak. > > We should release the ctx with damon_destroy_ctx() when damon_select_ops() > fails to fix the memory leak. > > Fixes: 4d69c3457821 ("mm/damon/reclaim: use damon_select_ops() instead of damon_{v,p}a_set_operations()") > Signed-off-by: Jianglei Nie > --- > mm/damon/reclaim.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c > index 4b07c29effe9..0b3c7396cb90 100644 > --- a/mm/damon/reclaim.c > +++ b/mm/damon/reclaim.c > @@ -441,8 +441,10 @@ static int __init damon_reclaim_init(void) > if (!ctx) > return -ENOMEM; > > - if (damon_select_ops(ctx, DAMON_OPS_PADDR)) > + if (damon_select_ops(ctx, DAMON_OPS_PADDR)) { > + damon_destroy_ctx(ctx); > return -EINVAL; > + } > > ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; > ctx->callback.after_aggregation = damon_reclaim_after_aggregation; > -- > 2.25.1 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.