From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F3BCCA483 for ; Sat, 23 Jul 2022 13:43:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F5F26B0071; Sat, 23 Jul 2022 09:43:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37E276B0073; Sat, 23 Jul 2022 09:43:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F7F26B0074; Sat, 23 Jul 2022 09:43:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0A2576B0071 for ; Sat, 23 Jul 2022 09:43:53 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D49C11C6A3C for ; Sat, 23 Jul 2022 13:43:52 +0000 (UTC) X-FDA: 79718482704.22.C409413 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf17.hostedemail.com (Postfix) with ESMTP id 7C92240019 for ; Sat, 23 Jul 2022 13:43:51 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id 23so6532027pgc.8 for ; Sat, 23 Jul 2022 06:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nPpL7FVl1H6PqS4nSrWEyucV5KSmiF3t3mUkvRlHKBU=; b=33Pvm3siw1zIA/gqHlaxpRttHKirwq32HP3voocw7GvlH7yCIugm82MXFYusTQBr68 knM800EJZgRHqXkSz7vdMPH3+5nKTta1dlmxzWt1AqMHiPlfYhv0qE8Lmd67TKIE8cXK rQN5NAzCXFChsjY2ct3ErpJIaAVOoyjfoH/sp22cfnNJAudeIYuaprca7rtdbQIfPEMM o2S1DnSjoLj7gxj3OOKF3zmA0043M82rpl8M+OCxC19U9RBfGtjyWE369bahfWSt2Txg K+a38XrTyNcnAJgQhy0yydkXBJRwQHzyyX8LwMGfX8ANV+E9J63tSjuXbvJocqeDTSnn 6aYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nPpL7FVl1H6PqS4nSrWEyucV5KSmiF3t3mUkvRlHKBU=; b=XAyWpgQoDvq10ajykRvwSOv5XQn75L0fP8mt4QT3p/za9OhUB5fB2ZOXqKKv7db5BR UO8HLUzGiX9c008E78VxfsQS79YjL8Nu9mSTgP74VWbTv7hvP2gcxNmiABspKPZWD1xe Zjh3zJpJb+9Z3bzhnTsfT7GpNXZdxgU22c/dL2RJtB+OEvzJ/KbmP1e+KTEepFL+DDQ6 9X2/Q8RtKacwIjf45Lo6nbTJHauxAmKF5JAD9xXGmsL9S9F3ZuVDFwLPKYJTDXz7/gZ9 mV03cHQjNQsuWsjlN+yArzCMlPT8gujA4QxzZxTUALK+0logZuKkdYrkxQpLSL9NixZb ATaQ== X-Gm-Message-State: AJIora8wpcTOnR7gX+VC1GBc3DwX3OJNZK+olsgDthwch2JJDYJOBIE2 d0oejDtPlcDuUZLP3M/Cqimv8Q== X-Google-Smtp-Source: AGRyM1t+byhgVDc1TwUk8OX/9xUITk45nLbmuKiSJ1MhpGu0O/05x8iTrTMZreaVyvjjKObbuO3KvA== X-Received: by 2002:a63:31d3:0:b0:412:a9d9:d407 with SMTP id x202-20020a6331d3000000b00412a9d9d407mr3953747pgx.479.1658583830231; Sat, 23 Jul 2022 06:43:50 -0700 (PDT) Received: from localhost ([139.177.225.241]) by smtp.gmail.com with ESMTPSA id n13-20020a170902e54d00b0016c38eb1f3asm5895681plf.214.2022.07.23.06.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jul 2022 06:43:49 -0700 (PDT) Date: Sat, 23 Jul 2022 21:43:45 +0800 From: Muchun Song To: Jiebin Sun Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, tim.c.chen@intel.com, ying.huang@intel.com, amadeuszx.slawinski@linux.intel.com, tianyou.li@intel.com, wangyang.guo@intel.com Subject: Re: [PATCH] mm: Remove the redundant updating of stats_flush_threshold Message-ID: References: <20220722164949.47760-1-jiebin.sun@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220722164949.47760-1-jiebin.sun@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658583832; a=rsa-sha256; cv=none; b=HJFdjdkLXzWdpLEdpIE2i4M07sKvXhmMqZjaW6lQVlKjKNP6Tr52jsfurrJmVZJnmBt3OJ BXSV9a+1rNS9TB8GaZT2qhb0R+1S4gGrMV4QvYfuAEjkOR/qcR6c+gStturhWgCJp2Rpm7 lefKlIqeDt/FOrntUdCtpMfp23hVgOM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=33Pvm3si; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf17.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658583832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nPpL7FVl1H6PqS4nSrWEyucV5KSmiF3t3mUkvRlHKBU=; b=ZqH4a3qcI2NHqWFp1DTqpj3HkHm+DikGctVM14GHNj0Kvj/tvIK7ofCdVWZ+fCPvjzxZBO SgZof3y7fnkOTdzEYhxfixg5AEDpPvGyCN8WdTcc92VeWMNr6Tq0iCyppAB2Nk6HuT2v9e 0SGtXDcGjjwzsmo5wFhDSvF1Nx8vRu4= Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=33Pvm3si; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf17.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7C92240019 X-Stat-Signature: aan375mf1yshnuiyjdm84fawkprd1718 X-HE-Tag: 1658583831-732518 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote: > From: jiebin sun > > Remove the redundant updating of stats_flush_threshold. If the > global var stats_flush_threshold has exceeded the trigger value > for __mem_cgroup_flush_stats, further increment is unnecessary. > > Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads). > > Score gain: 1.95x > Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%) > > CPU: ICX 8380 x 2 sockets > Core number: 40 x 2 physical cores > Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads) > > Signed-off-by: Jiebin Sun Acked-by: Muchun Song Thanks.