From: Muchun Song <songmuchun@bytedance.com>
To: Jiebin Sun <jiebin.sun@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeelb@google.com,
akpm@linux-foundation.org, tim.c.chen@intel.com,
ying.huang@intel.com, amadeuszx.slawinski@linux.intel.com,
tianyou.li@intel.com, wangyang.guo@intel.com
Subject: Re: [PATCH] mm: Remove the redundant updating of stats_flush_threshold
Date: Sat, 23 Jul 2022 21:43:45 +0800 [thread overview]
Message-ID: <Ytv7EX1FzNg1uz1t@FVFYT0MHHV2J.usts.net> (raw)
In-Reply-To: <20220722164949.47760-1-jiebin.sun@intel.com>
On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote:
> From: jiebin sun <jiebin.sun@intel.com>
>
> Remove the redundant updating of stats_flush_threshold. If the
> global var stats_flush_threshold has exceeded the trigger value
> for __mem_cgroup_flush_stats, further increment is unnecessary.
>
> Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads).
>
> Score gain: 1.95x
> Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%)
>
> CPU: ICX 8380 x 2 sockets
> Core number: 40 x 2 physical cores
> Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads)
>
> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
Acked-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
prev parent reply other threads:[~2022-07-23 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 16:49 Jiebin Sun
2022-07-22 16:22 ` Shakeel Butt
2022-07-22 17:05 ` Roman Gushchin
2022-07-22 17:57 ` Chen, Tim C
2022-07-23 13:43 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytv7EX1FzNg1uz1t@FVFYT0MHHV2J.usts.net \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jiebin.sun@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tianyou.li@intel.com \
--cc=tim.c.chen@intel.com \
--cc=wangyang.guo@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox