From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10C79C433EF for ; Sat, 23 Jul 2022 09:12:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D4836B0071; Sat, 23 Jul 2022 05:12:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 083ED6B0073; Sat, 23 Jul 2022 05:12:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E65C76B0074; Sat, 23 Jul 2022 05:12:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D7D3D6B0071 for ; Sat, 23 Jul 2022 05:12:54 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 98E1C160E93 for ; Sat, 23 Jul 2022 09:12:54 +0000 (UTC) X-FDA: 79717799868.21.54D9416 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf10.hostedemail.com (Postfix) with ESMTP id EBE12C0089 for ; Sat, 23 Jul 2022 09:12:53 +0000 (UTC) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26N8nk9q025997; Sat, 23 Jul 2022 09:12:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=Uif1aPba3YM5gb4TRKwfYAw9avTxPk+m4XZfVC4A7HU=; b=Huk+vgyTWceYjylZ2bXT6y1JA/lh4rpiNZmTp95bw4KkRlq5abL5MutqktOOUrrdV3WP APO6RTCHGqmGBGFnabjOMWNNjyDRqDbduQJ6vU90qH/RB7sCKM9ehDFGztRTVh/93QBb YhN7d7Su/KKJDZjl85l/WGIQv7VZGjKwoWmcZ4atjTJXPoywt1/oyiEzZk504KEOjepc voCvV+tUrKOtabe4gkqXvPhZ0lKC6t/pV8Z7IjoVIoC5FXa9+Qt4DIFxDMZBezw0uHIN iEIryl31xrkPRglTVrXri61DN2XsOFAx7xnIujlpBWs8f4YTdnm/su16X3d4ukHkF6M3 lQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3hgdts0bc5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 23 Jul 2022 09:12:52 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 26N9980B024462; Sat, 23 Jul 2022 09:12:52 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3hgdts0bbp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 23 Jul 2022 09:12:52 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 26N97P2x006723; Sat, 23 Jul 2022 09:12:50 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 3hg96ug7nn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 23 Jul 2022 09:12:50 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 26N9Cm1r17236244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 23 Jul 2022 09:12:48 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 447AAA4053; Sat, 23 Jul 2022 09:12:48 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6227FA4040; Sat, 23 Jul 2022 09:12:47 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.2.93]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sat, 23 Jul 2022 09:12:47 +0000 (GMT) Date: Sat, 23 Jul 2022 12:12:45 +0300 From: Mike Rapoport To: Nadav Amit Cc: linux-mm@kvack.org, Andrew Morton , Nadav Amit , Mike Kravetz , Hugh Dickins , Axel Rasmussen , Peter Xu , David Hildenbrand Subject: Re: [PATCH v2 1/5] userfaultfd: introduce uffd_flags Message-ID: References: <20220718114748.2623-1-namit@vmware.com> <20220718114748.2623-2-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718114748.2623-2-namit@vmware.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: -tTIGL7QBl5h4fpZkdVnEThFh6XlB8Ud X-Proofpoint-GUID: KwLN0gSu6SiSlrH_togBpjDjrKOcsEMX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-22_06,2022-07-21_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 impostorscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207230040 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658567574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uif1aPba3YM5gb4TRKwfYAw9avTxPk+m4XZfVC4A7HU=; b=K6zfVD0nE8tF7Bh9OsO3LIfLn6qEHjpQMTIfMYDrPCKrYnWz74KRqDtCobkBvMipjBo9+4 8WGmr6xe5akrBcIqkiX+QmnDpbRToxdt4CURcM6FzkJ/1XjQAZr3eZ4QXL1xHWL4BcXnQL ofNVmvL+4R7XajvnojSD1MwXjY+90mc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658567574; a=rsa-sha256; cv=none; b=okLCHkhURYBKBG7v3+7+lnzsxJmySotooX9pFSJb1Oxvkw6j4APHE6ci8/gbmFgnXShxEv +nYgnKJQqmimb7joAEL1wKkon4/D9UiPnIei+IvRhsYQWM92qmCpvt5tRDjjOzIgOJGB5N q2AOuHt9Pjfq3sVr7GjRFuUTc8UjC4U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Huk+vgyT; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com X-Stat-Signature: hy5fpo7rw8oqddu45ynpsyyehu3ew1i7 X-Rspamd-Queue-Id: EBE12C0089 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Huk+vgyT; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1658567573-257096 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 18, 2022 at 04:47:44AM -0700, Nadav Amit wrote: > From: Nadav Amit > > As the next patches are going to introduce more information that needs > to be propagated regarding handled user requests, introduce uffd_flags > that would be used to propagate this information. > > Remove the unused UFFD_FLAGS_SET to avoid confusion in the constant > names. > > Introducing uffd flags also allows to avoid mm/userfaultfd from being > using uapi (e.g., UFFDIO_COPY_MODE_WP). > > Cc: Mike Kravetz > Cc: Hugh Dickins > Cc: Andrew Morton > Cc: Axel Rasmussen > Cc: Peter Xu > Cc: Mike Rapoport > Acked-by: David Hildenbrand > Signed-off-by: Nadav Amit > --- > fs/userfaultfd.c | 22 +++++++++++--- > include/linux/hugetlb.h | 4 +-- > include/linux/shmem_fs.h | 8 +++-- > include/linux/userfaultfd_k.h | 24 +++++++++------ > mm/hugetlb.c | 3 +- > mm/shmem.c | 6 ++-- > mm/userfaultfd.c | 57 ++++++++++++++++++----------------- > 7 files changed, 73 insertions(+), 51 deletions(-) > > diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c > index e943370107d0..2ae24327beec 100644 > --- a/fs/userfaultfd.c > +++ b/fs/userfaultfd.c > @@ -1682,6 +1682,8 @@ static int userfaultfd_copy(struct userfaultfd_ctx *ctx, > struct uffdio_copy uffdio_copy; > struct uffdio_copy __user *user_uffdio_copy; > struct userfaultfd_wake_range range; > + bool mode_wp; > + uffd_flags_t uffd_flags; > > user_uffdio_copy = (struct uffdio_copy __user *) arg; > > @@ -1708,10 +1710,15 @@ static int userfaultfd_copy(struct userfaultfd_ctx *ctx, > goto out; > if (uffdio_copy.mode & ~(UFFDIO_COPY_MODE_DONTWAKE|UFFDIO_COPY_MODE_WP)) > goto out; > + > + mode_wp = uffdio_copy.mode & UFFDIO_COPY_MODE_WP; This seems to be the only place where mode_wp is used in this function. I'd just drop it, and set uffd_flags directly from uffdio_copy.mode. E.g. something like uffd_flags_t uffd_flags = UFFD_FLAGS_NONE; ... if (uffdio_copy.mode & UFFDIO_COPY_MODE_WP) uffd_flags = UFFD_FLAGS_WP; Otherwise Acked-by: Mike Rapoport > + > + uffd_flags = mode_wp ? UFFD_FLAGS_WP : UFFD_FLAGS_NONE; > + > if (mmget_not_zero(ctx->mm)) { > ret = mcopy_atomic(ctx->mm, uffdio_copy.dst, uffdio_copy.src, > uffdio_copy.len, &ctx->mmap_changing, > - uffdio_copy.mode); > + uffd_flags); > mmput(ctx->mm); > } else { > return -ESRCH; -- Sincerely yours, Mike.