From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9372C43334 for ; Thu, 21 Jul 2022 14:20:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E96456B0071; Thu, 21 Jul 2022 10:20:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1EF26B0072; Thu, 21 Jul 2022 10:20:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBFE36B0074; Thu, 21 Jul 2022 10:20:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BA3EA6B0071 for ; Thu, 21 Jul 2022 10:20:30 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 977D612098D for ; Thu, 21 Jul 2022 14:20:30 +0000 (UTC) X-FDA: 79711317420.28.79E6AED Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 540481C008B for ; Thu, 21 Jul 2022 14:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dW/bWDwaMVv8Pew/7ulojs7UcuFsvJlVOAqRXlcbyF8=; b=SnzBFuWZSVXpX8nyooM8kLu6MA S231XnK+caNMoNrkjm8O9rLodzkwwdxZ1BunZNIMhJ6SEHgJ2RVCuvGrMmObZLlKaiWgpgbqXWalP 6S+VftT4RKvlxRlXaLTs28GKfGdKye3PZ2xXfj0/oeUf1O8oJrZ6ODiDsx7rkvVs9zeEjVQVxjUq+ fi21eBzwB8gMbSOX67TIqzQkUBu8qxeK/M5uhykFe3A7jwtoqoSETSYnmnVpyE5hY/CW/SlFIYBXh RzSOQEjAqFk2GEvrfVe72LsYezwRSzBJZ9wUEW0igAjp+Z7FV9fZxS0LutEH823+VRMiw10OuihiT V7jWElTQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEX26-00FQ9u-5W; Thu, 21 Jul 2022 14:20:06 +0000 Date: Thu, 21 Jul 2022 15:20:06 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Johannes Weiner , Joonsoo Kim , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [RFC PATCH] mm: set cache_trim_mode when inactive ratio is undesired Message-ID: References: <1658387208-20065-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1658387208-20065-1-git-send-email-zhaoyang.huang@unisoc.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658413229; a=rsa-sha256; cv=none; b=AgVZGnRQxu4BhKWm/qepngtobid2d5hn4kkHw5uGO84u5m6bj3ZxU7loM2w/h/DHjjZmz2 QvxUbn33GyFRkwf47N9wLkzHif+0lgNDYHZQKZIxozdC7nyChe3XZ/CWKoh3PyWWLksB1c P6Tr05B+BBaTRnEmR4UZsz23T4D8j/U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SnzBFuWZ; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658413229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dW/bWDwaMVv8Pew/7ulojs7UcuFsvJlVOAqRXlcbyF8=; b=wjbkiYHUpZCsKRh3FG/nn8lsnNUISPfQdHzBV8hAAjNFKOfdMDUjEt/glnbNn2vzbCj+kp 1HQgnJT0ZUZ/88GufcjUfHpPkOpyD74AflhA1TVincVscbFLPeL/CsLyTQNH4Num/IgYVm KBOKwxTsuBxaz1nRZ40GeSq0WBxZrpY= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SnzBFuWZ; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 540481C008B X-Stat-Signature: epsz1gf94yc6gtfatcdtwswtpyp3zkm9 X-Rspam-User: X-HE-Tag: 1658413227-725225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 21, 2022 at 03:06:48PM +0800, zhaoyang.huang wrote: > @@ -3198,7 +3215,8 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > * anonymous pages. > */ > file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE); > - if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE)) > + if (file >> sc->priority && (!(sc->may_deactivate & DEACTIVATE_FILE) > + || inactive_is_high(target_lruvec, LRU_INACTIVE_FILE))) Indentation is weird here. When splitting a line, put the operator at the end, and then indent the rest by something *other* than a single tab, so it doesn't look like it's part of the following statement. ie either: if (file >> sc->priority && (!(sc->may_deactivate & DEACTIVATE_FILE) || inactive_is_high(target_lruvec, LRU_INACTIVE_FILE))) or: if (file >> sc->priority && (!(sc->may_deactivate & DEACTIVATE_FILE) || inactive_is_high(target_lruvec, LRU_INACTIVE_FILE))) Some people like to use the indentation to illustrate the precendence. That would look like this: if (file >> sc->priority && (!(sc->may_deactivate & DEACTIVATE_FILE) || inactive_is_high(target_lruvec, LRU_INACTIVE_FILE))) (I have a mild preference for the third option in this instance) > sc->cache_trim_mode = 1; > else > sc->cache_trim_mode = 0; > -- > 1.9.1 > >