From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECECC433EF for ; Wed, 20 Jul 2022 22:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 514386B0072; Wed, 20 Jul 2022 18:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C4276B0073; Wed, 20 Jul 2022 18:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38CAB6B0074; Wed, 20 Jul 2022 18:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 251C06B0072 for ; Wed, 20 Jul 2022 18:03:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EF93AAAB4F for ; Wed, 20 Jul 2022 22:03:01 +0000 (UTC) X-FDA: 79708854162.01.233B6D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id DA0281C0084 for ; Wed, 20 Jul 2022 22:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658354580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c6jnvbTZSWYjkjxxL2h3wZQ+s22j9f6nKt+O/48X9rA=; b=ObQ3veYL8wkrmdycaiG/fDjkWaAW4dOQs7TCo6tPyYeMsFdHPUBnDGm3Xq+gTK26jzbZVU 9m8eD4dj/polF1nONsrEQ85DEsPQX+tjO3W6UCVUKZB7+0J4T01Dd/hLYF5n+SlD9LWTQ1 v/Z0zmeBXDB1ONpNAeTib1ng+2wwheo= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547-5K-CgWsXMDCsQ4gOhHsWHQ-1; Wed, 20 Jul 2022 18:02:59 -0400 X-MC-Unique: 5K-CgWsXMDCsQ4gOhHsWHQ-1 Received: by mail-qt1-f199.google.com with SMTP id cf20-20020a05622a401400b0031efad5abb9so38413qtb.10 for ; Wed, 20 Jul 2022 15:02:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c6jnvbTZSWYjkjxxL2h3wZQ+s22j9f6nKt+O/48X9rA=; b=EEBlW7Vle+h9m95oOvgQ+Hu3yGpUbX2ku5olrMB6yRyIYah4Q3BemJFpL9ZnOWT2M5 xWM7iSnnErgOrYQSSyHRDJGtns7wseRh0AU98G2lb+ZNO1VkQ5zpcqKC8pR08BH8Qk+6 oKQYiLw/uLVWAnD5p4sp7Vm6SD5wJwNVObj9BgNY9Er2DUgG3Hme2Jwg9VMqvWzynu6g mELOm9P/TzI2GJdgYSkXj7nvxd1S5Mki3sb1W0zhTIu3eZMooimPFojSdUFfQQApV9X1 /B/xXhbj+WjRI7H3erOsrjg+VRRriBp0ifRPCj0Rps4h/iLyGkXyTufF8LwPfo6gOUM5 WyvQ== X-Gm-Message-State: AJIora/qxAb+jYjeb5vsPX+UQ4toZHEtvmoblOVXa1gKs9m+Cv5bhEtj s+eZgZTFPXraYU1VRhChPflYrHWpfqG8gucsqEZNQo35775vQzwHehdC4VN4uYk9QIh1frJWLNE 6rrFVLEfybXAvUAVzKxbYKpZunMysTAw3omRxwJ/figTNfqSgIwE2skRcLDiA X-Received: by 2002:a37:614:0:b0:6b5:cda7:694b with SMTP id 20-20020a370614000000b006b5cda7694bmr18598717qkg.532.1658354578287; Wed, 20 Jul 2022 15:02:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vKjiIammcHHHBmJOZwtJ7s3x+QWPbbcaO+hZViEQVzR62uQ1jjVGoKVLSrMmHy4Q1LBCm1vA== X-Received: by 2002:a37:614:0:b0:6b5:cda7:694b with SMTP id 20-20020a370614000000b006b5cda7694bmr18598687qkg.532.1658354577916; Wed, 20 Jul 2022 15:02:57 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-37-74-12-30-48.dsl.bell.ca. [74.12.30.48]) by smtp.gmail.com with ESMTPSA id de39-20020a05620a372700b006b568bdd7d5sm214499qkb.71.2022.07.20.15.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 15:02:57 -0700 (PDT) Date: Wed, 20 Jul 2022 18:02:56 -0400 From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Nadav Amit , Andrea Arcangeli , Andrew Morton Subject: Re: [PATCH] mm/mprotect: Fix soft-dirty check in can_change_pte_writable() Message-ID: References: <20220720215319.87839-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220720215319.87839-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ObQ3veYL; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658354581; a=rsa-sha256; cv=none; b=HGmxX0i5hWETt7kfzKHiGtIgOYwlW2BNlggihjkkW+cxZ0hfvlcWO5T0bOcmk6VfhRMezx I7AsltnSYHvGL/EhzPjuGMxxLv+bn9KqfIfdLhnrQesY9D4SefQRJnA/zivo9jwxgLWkqc T6o6gMOwuS/h9tb+/a9gMIDYWKYNalw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658354581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c6jnvbTZSWYjkjxxL2h3wZQ+s22j9f6nKt+O/48X9rA=; b=iWPt91d/zTofYnNe6Cf46O+xodOotX/SqD9oqKtKqQ9y96lOGYDoEbjdOYQ8XmueqV1rjP +ZdyujAPlfueCrLnrhHUonDdIKKWLjsl31JvPcjEKaib2r7mksGKUIk5XF/lHvRldtvb5r 9JzKjBO93JAJIGeW4bXiHSK51696RlQ= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ObQ3veYL; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: hs8xmjjdhizib6dm1b9iz4nutmc8hna8 X-Rspamd-Queue-Id: DA0281C0084 X-HE-Tag: 1658354580-93319 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 20, 2022 at 05:53:19PM -0400, Peter Xu wrote: > void clear_refs_write(void) > { > int fd = open("/proc/self/clear_refs", O_RDWR); > > assert(fd >= 0); > write(fd, "4", 2); > close(fd); > } > Oops, git dropped some of the lines starting with "#".. Let me retry, sorry. > bool dirty = pagemap_read_vaddr(fd, page) & PM_SOFT_DIRTY; \ > if (dirty != expect) { \ > printf("ERROR: %s, soft-dirty=%d (expect: %d)\n", str, dirty, expect); \ > exit(-1); \ > } \ > } while (0) -- Peter Xu