From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282C6C433EF for ; Tue, 19 Jul 2022 09:36:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EDED6B0071; Tue, 19 Jul 2022 05:36:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49D696B0073; Tue, 19 Jul 2022 05:36:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33EBB6B0074; Tue, 19 Jul 2022 05:36:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2556E6B0071 for ; Tue, 19 Jul 2022 05:36:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EA0373452C for ; Tue, 19 Jul 2022 09:36:51 +0000 (UTC) X-FDA: 79703345022.18.AEF3411 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf26.hostedemail.com (Postfix) with ESMTP id 63A1E14006A for ; Tue, 19 Jul 2022 09:36:51 +0000 (UTC) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26J8FptY026655 for ; Tue, 19 Jul 2022 09:36:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2022-7-12; bh=JsvSJ211zCmaMr6S5agueIK+we4uelSiqDYcpsDNHRE=; b=cXxk39ZccRrL7jB0rlIaINrL5zFrYesXu08Y0E3hnAbIZDgZDkKc99RMlhtt1ABb2qI3 FSrgWKUTYU7OrT99S9g95fLMkiYTJ/N3AcknZYI08BDDq0Xli7yzdn4i0FCg3fh8ZxuR voBd37QGupHIv//iU2/7shYubK1DbhiGiB6YqrCENqplzuN5nT0s/8RplrLq722EMP7k 0ucWjHu0jwaFTkPSYRiZ8gl6D/kWZVBAKQwo+z0B3KCs59amv9IPXF3Navgl6CEguaW6 0HIN8eNtW07FGq4Z++v8hlLjzD+uggEyeUrHuD6+4jZHdosg65GmX+6IDO4ZLr7ZwBPR +Q== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hbn7a5nee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 19 Jul 2022 09:36:50 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26J8ZgpJ016513 for ; Tue, 19 Jul 2022 09:36:49 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2104.outbound.protection.outlook.com [104.47.55.104]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hc1emccnf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 19 Jul 2022 09:36:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V0bjRYgM7pCi3yHX+d3bMMn3HrY81NI3GrzBHlYMoaLHU9rukWy5VW4+LA6wILGlIGxVyji+jDTlLtcpWTZpbpQr79SwOV78551WmQ3QhATN/ov54B/rQ3LRI7BLZ0Bx9cY5w/KfPPRPpHeX7U+n6mDRseO5av42gahWd7j+viFDQa5GVCAP1Emus4cbHLHCYc2uzgcgADGGS5jff+RhyqW6Er2XlqgmcEaEx6wRWOynyWX8igE7gjQwlHGOyNurSeMBfL9hrlrf51PRcJaZkKnRZPYcxmT26VC9TJiQ0b217EB4LUrw0x2DY8RY4hgfCb9qxlSXxSJhfvt8NAk6xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JsvSJ211zCmaMr6S5agueIK+we4uelSiqDYcpsDNHRE=; b=OlQK+xQXv5wclEmS7BKbUmT/b629dJcYSXrkzmNZoIHVjNAZm2jcR26XUfMg20YacjiHpgSzzNi0o/iU2nIrp7eGb4qD3ghl4803pebFHgDBxVQNP5OB0LMOJ66deC3dJMCd+w53R+TwC9g5KQMjgMTmZE6WSEHeiHB/A6UO5Q1utwbrA0ANsV5g3wCE+p2RMunhn9H1ShML7Ps7f7xRk/A/7lEmKeS3yWfFqIJXVH+Vu9SRALiCozGVdpx/pBxyIpX5BSbgSDSWqS0t0+ujltbxnz1JktwltzI+wir71bC3sEGznx7+L2lL12WMS8BHZdrWuUdSXsQd9CaYDvd2JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JsvSJ211zCmaMr6S5agueIK+we4uelSiqDYcpsDNHRE=; b=HyAKp6hx0QjnDtbN+sQcw01Zn3Uty+7IATEYgARWMiRJ4NqWrwz6jU3u6JCiZefmO+xGqbFdwFN6qDWpB9rhcr0rbiysDqQbUtnTrD8oGabwNkM8ESwEUKyxipKTzF2lsF8UePCZyAZTsiybEM/l7Ao7AxM4P0z0uNLwf8fAZ2M= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by BN0PR10MB4933.namprd10.prod.outlook.com (2603:10b6:408:125::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19; Tue, 19 Jul 2022 09:36:45 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b%6]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 09:36:45 +0000 Date: Tue, 19 Jul 2022 12:36:36 +0300 From: Dan Carpenter To: Liam.Howlett@oracle.com Cc: linux-mm@kvack.org Subject: [bug report] Maple Tree: add new data structure Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-ClientProxiedBy: ZR0P278CA0121.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::18) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf42629a-277b-4a8a-81a8-08da696a31e9 X-MS-TrafficTypeDiagnostic: BN0PR10MB4933:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tNauXnph6Fl1tpYoRFJReNciO8KZrDPpDDIYQrFsmmYg+xA9j3NXkm1e4Pp5Eb7ePLuSVm+q9f85+QJWksfaK9E95HdeTIwrjx89hXdRZMFJ03Zk7GRlsIEpT+KNZT8AD1JOiePA9/s7qVnpRW9lc5eTVOUlK1z3mKpX1as9ttuel40h/Td4GVIKW6J15GMgkoNez06V53s83KvtbvDYgM9EyvabWcsBn8nyWIB5ojxIzPUMw6uPFKXRxN/XIRCWGN8g75Gh+QGnaZiskaegwJxr5UPo2aoeE/AVwDg33ZQAC03Y3aAUgS0egg83Fwwhnsy/zFg0jMkQSfUu3JEp2I71p03fk1vYvxCwPV0tMoA3IuDsHzo4Y10EdULVUi85yBLyTh5ft9M37zxzx9q33mHQwEoLyEDba6mR+Art2foZpXfqamFkC8J+YHgxNjuzc1YFgJxhVimz09myRaGKFWqolFPLNJbjJ4HMDEOOLrsc7lxfv7scK6WaUpDkx+oIgEZL/nOkkSy/at99iRDjeHqTBi8sBuWhT0LfyiAjljI4SPUoTWR5h2bJOJpTBAlbcgYIIByGUGWFDB2vKYDP1h4/rNiqTIc30lFkCUHn+eChAKNdx5DdnRlYPX0sozRmCox+0OyNaaAF3db6QGWK3LqDE2VGVv4sShKpoG2iEdTgn7bZwkH1+HoPEvTA4rpS0DQzR0oVrIkbCT9GEu2sHPENKUXXaXFedyCHHLO5zzwWmJ0ep71W1Sm9cEWh66nURr9LrgBXQ3cm4lZsMw+7/zc5YMHPAL9s9JwLC+Ex4+AP3bS7NgfUgSVwKN0O14+I X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(396003)(376002)(39860400002)(366004)(136003)(346002)(8676002)(33716001)(4326008)(66476007)(86362001)(34206002)(38100700002)(66946007)(38350700002)(186003)(5660300002)(44832011)(83380400001)(66556008)(8936002)(478600001)(52116002)(6486002)(6666004)(316002)(9686003)(6512007)(41300700001)(6636002)(26005)(2906002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jCjssBc3POfeKZGv2vaFVlGxSduM6PthMBaFpWL4xhSf6BlurcygsheZayG0?= =?us-ascii?Q?bGiEd3u0mpY1eFD3Pl5Abe2RWwK6AqnMb1TgBqOo7fPJzaDAcv5p++pjbDGi?= =?us-ascii?Q?OWAp4bvD0dBk39ezUV7kado+bgg9pGHL/4zsOpMcLNr3DXfHz2AXK+2/6+3L?= =?us-ascii?Q?T0tbHgmxhgt3LhZy1diezhZ5LEbxVSMHeBpe4SL5yJ7A5CVQkTW9a+5pC529?= =?us-ascii?Q?8DyzLvaV7dktpdd0nQ5Bb0mESv+XdeBJC1/oDhTDw2x1dVjyvHVNLfUhch01?= =?us-ascii?Q?RFXJbC/RbHKqVX7jmZ69DX+GFQlckij3MQOpDh3q2j4LH7/XUiFGpcvDaWJ3?= =?us-ascii?Q?HhY31Y8iqtFLA6rN2oMkjGV4mPHcCdpIgjt/JNU186hECljNUxhvH3Ei/x4Y?= =?us-ascii?Q?EC4WlgVxDz3EwG8xkrk9Ed6N9+W3yimR78HFntzGyKZDk2LfC470WMDotrHP?= =?us-ascii?Q?O+IMI83yaiUN0KTGiPr0TDjNebfimLlFYJMR3F/aqPKGyzD+MR4DB0hzc6dx?= =?us-ascii?Q?SrE+2xbbX3eizJnPKKuouzVe2x55bS8mfCLfYobDIe4i7c2nOCEBCBLUDKVM?= =?us-ascii?Q?nV2T2EiHjQMZ5em40YqplOuv6CVIkAYeSvtMm1R7KRpaBNsH+Ob+PaT1Y1i8?= =?us-ascii?Q?jawCdn7i3zK5XUZhHj7uZlN4OBDKWhvNv0e0+j/8f3y1Gq+81ucU9wRls1fe?= =?us-ascii?Q?ghpF3CTDfUU4jJUOgcEHEYWwaJqRq0nULkb8sQRCWauQYk0q/04yVvPRHMPn?= =?us-ascii?Q?7uPWnKzWdcgJ6fmymZc3ZqIHCuamxw67/a69FE9FLJyBtTfXRWAhxhpsSKzS?= =?us-ascii?Q?nFdywGU8GJgSBZDmu2K5dbFp912rjswqoHzLpGeStSJeRc9ZC+B4MSX6vZDn?= =?us-ascii?Q?BamKNucrCJyZuyPf0GBdfKXURkKP7PEhUbOmCcCzPbFHf0hOJjG1/KKbzW3s?= =?us-ascii?Q?BIycbIEgviErLe4RalUr/vJtmWPqOCjSQYHweptm7CwzIC4nKotz/oa6tdfh?= =?us-ascii?Q?YsGlpzHkd3IUTWdwn5nfigpOzADhA0TU1k69MnaV1EocMe5K28Cfhq8lsOA0?= =?us-ascii?Q?n0qRfvjIRZYPtKTPPtoBdWW19xzJYRqfZeagWvb+wZ5YOe2X3s4Kp07B4Adl?= =?us-ascii?Q?g4Hg9BdzXzosXFmnnP2qsAy50Rns8zOQbiFpvgMW2lTzNHFfgtFL8wID8Ask?= =?us-ascii?Q?1rZp1eV6EfzOeYLd19AyBpkGbV581DzE/pBaXjwFVRsNRgDIkIW0rQK/GXCj?= =?us-ascii?Q?n4azu3PgJn8Soj37H0snuPfSe74vUZ2qY8hsFAwpCJ7OFXSnqaI7/6Ok6dFU?= =?us-ascii?Q?xUhG11dRgfWEoB/fxhnrQ2kKhTNUWJ0a1HBMJ2PpZCGX/NDJ5R65QkwCQJN3?= =?us-ascii?Q?B19QUPbkvEzemw9DPhdgmU6t7c3kwUmFs752oKIxu77aoyOG4rbgG4dJx2XL?= =?us-ascii?Q?WomfGxTfd0ShHh50hroqM5juARVf9ILxLMyoLMpcCGreXL60HpmiYHTkuWCm?= =?us-ascii?Q?xSory9v++hqG/Jbcb56jOkKy1KsoKS7zpzveNlC2tbkz8QEZvffgT9LP2n1d?= =?us-ascii?Q?d6FMvCf2MwjIxwzZzZUF/haKZJWwuatXMB4ut52q+upf6eIMe2+qAJcClnD1?= =?us-ascii?Q?Tg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf42629a-277b-4a8a-81a8-08da696a31e9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 09:36:45.2901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Osr09eU2M7CSfksLWTz9tSF51E/dVGF8ns5I87o1WA3LwrmhfnPSt87OfBwg0afYFBHXABW7zn5vnJg+8rwDMH4BAUBaDhLn56dJ5vEXAA8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4933 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_22,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 mlxlogscore=790 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207190040 X-Proofpoint-ORIG-GUID: QyVfkFwhcqa-NIrNKAh2Qu-wThcdAz1m X-Proofpoint-GUID: QyVfkFwhcqa-NIrNKAh2Qu-wThcdAz1m ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=cXxk39Zc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=HyAKp6hx; spf=none (imf26.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658223411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=JsvSJ211zCmaMr6S5agueIK+we4uelSiqDYcpsDNHRE=; b=I7UX9UKUT//6kdnWZe/EE4whVqNMiKCVePERod+J5vmEFKMb1b23Cp9HzdoQ0dCNf16flg 6BuBz0k0ejGqBW4seGc4sRTUTd6TWVwAawI/5xRC0wBUE99i1EWaalX+5YLTAAvfi6i1tW litNd1CmS3XYCiA9AHrR+eQd7z1htsM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1658223411; a=rsa-sha256; cv=pass; b=20f3mZHj8flo1gimUX7fjFzkkoSmtIsO4BpFgcgzJsfmIRsEe37jM+MV/3eGjf2QJkeea5 T/hR2ITI17lmOwoUiW6K0/n/W7pj8cc1ys2P3Kt7s56ChLGhQBbGIY1rPQDu6SaHDqS3D0 vaZH3FnbW+vyGPqTf3G+RcBJXRtxOY0= X-Rspam-User: X-Rspamd-Queue-Id: 63A1E14006A Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=cXxk39Zc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=HyAKp6hx; spf=none (imf26.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Stat-Signature: aw9mnnhrcjurijbr3erxn44hbotknh9m X-Rspamd-Server: rspam07 X-HE-Tag: 1658223411-670305 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Liam R. Howlett, The patch 058c2f0f755f: "Maple Tree: add new data structure" from Jul 17, 2022, leads to the following Smatch static checker warning: lib/maple_tree.c:6969 mas_validate_limits() warn: add some parenthesis here? '!piv & (i != 0)' lib/maple_tree.c 6952 static void mas_validate_limits(struct ma_state *mas) 6953 { 6954 int i; 6955 unsigned long prev_piv = 0; 6956 enum maple_type type = mte_node_type(mas->node); 6957 void __rcu **slots = ma_slots(mte_to_node(mas->node), type); 6958 unsigned long *pivots = ma_pivots(mas_mn(mas), type); 6959 6960 /* all limits are fine here. */ 6961 if (mte_is_root(mas->node)) 6962 return; 6963 6964 for (i = 0; i < mt_slots[type]; i++) { 6965 unsigned long piv; 6966 6967 piv = mas_safe_pivot(mas, pivots, i, type); 6968 --> 6969 if (!piv & (i != 0)) Sparse and Smatch both hate this. I think this code is correct and it should be: if ((!piv) & (i != 0)) However the vast majority of the time this warning indicates a precendence bug where what was intended was: if (!(piv & (i != 0))) I guess it's not common to use booleans for bitwise ANDs... 6970 break; 6971 6972 if (!mte_is_leaf(mas->node)) { regards, dan carpenter