From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75968C433EF for ; Tue, 19 Jul 2022 04:26:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB6578E0001; Tue, 19 Jul 2022 00:25:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3E2E6B0073; Tue, 19 Jul 2022 00:25:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB7928E0001; Tue, 19 Jul 2022 00:25:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B66386B0071 for ; Tue, 19 Jul 2022 00:25:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 8F07860598 for ; Tue, 19 Jul 2022 04:25:59 +0000 (UTC) X-FDA: 79702561638.07.EEC952E Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 2E5AB40005 for ; Tue, 19 Jul 2022 04:25:59 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id t15so224805pjo.1 for ; Mon, 18 Jul 2022 21:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VoF44j+4R9N9EU2VnEL1yhSs28fdl6vQHXX1QYJLwmo=; b=jSpoz7Lf+CF59A0YYE3Z9usr+Y9Yzm58ZW4pQ9LMlLSr4lycE6zJUWgWOWLDPSVlA/ Rs3bCzS17QWyZ8sJgQ4Lu64xbZYGN5XV64Kq2TPgTrjdpvd6ddNQhdOAYnRIwWosbCAg rNR/aBWQVKXKSyZQ8fSSV+xSea0DipC1ctpB0Ardys5hWIwb5JbnWCFtFvEtJvh2OG29 BWjCDPEjs5JX/nY/z4nN1Co3SkQKVRS3i9uMK1knCU8E03A/gpc4+2rpsE0q9e6J51Xb y3lmR4HEwR97gTcVlPiImLC6DoiA0NskvJKgaG3Y6JtXu4+ljaYhcqyh86D8mnMvGRZX FU5Q== X-Gm-Message-State: AJIora+U6Bm8n0wVkmaKHexIr9vxAz5GlSnc/Yf9+eJ6VKXj9y07LdfA n/kMimC98Xr1RgDRWMkyktI= X-Google-Smtp-Source: AGRyM1v2VLTRIa6mxNMtcr945yR256PwAUp79CQCO3ViG5wnm5Dfgqn3+Z9w4eDbKH2iTOZEE9z51Q== X-Received: by 2002:a17:90b:388b:b0:1f0:47d8:67fb with SMTP id mu11-20020a17090b388b00b001f047d867fbmr35942608pjb.34.1658204758078; Mon, 18 Jul 2022 21:25:58 -0700 (PDT) Received: from fedora (136-24-99-118.cab.webpass.net. [136.24.99.118]) by smtp.gmail.com with ESMTPSA id a8-20020a170902ecc800b001641b2d61d4sm10496205plh.30.2022.07.18.21.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 21:25:57 -0700 (PDT) Date: Mon, 18 Jul 2022 21:25:52 -0700 From: Dennis Zhou To: Yury Norov Cc: linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Andy Shevchenko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 14/16] mm/percpu: optimize pcpu_alloc_area() Message-ID: References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-15-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718192844.1805158-15-yury.norov@gmail.com> ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf17.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658204759; a=rsa-sha256; cv=none; b=jwLPH+yEo2YIGlVBQt0KVqB6LHJQqyaTaUyaqAWA6gEiILCQIAMTj5xLV5/QydzwkIERt+ 0UhuiIQetCkdw5Cgsr/MrWrcSFgeO6s3dLJjhGGDDzNNqJLrs94nEz4kAYwUD9YnNECty2 x3VMYgPAAOxA+wtAlqjyn55bJ14QBUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658204759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VoF44j+4R9N9EU2VnEL1yhSs28fdl6vQHXX1QYJLwmo=; b=cmQPbyku3b2oLeik3WvNuViCPlbH9fTiYU1paoTDfW+u+mQq32GlWbfKLMiMIXr2JM1jCV dE75nxwJ76V95o+iQStMX//yYQ89+GwG9F7WEFRQsmP4lDcIrIgbst7tIXz1ijYVpIj/Q0 j1inlAo70ekcv1ZSbkf/ms9s/4UgZ4w= X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2E5AB40005 Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf17.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-Stat-Signature: 6bh7ngqht64ggrtnbryfqkga47w8tcfp X-HE-Tag: 1658204759-983856 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Mon, Jul 18, 2022 at 12:28:42PM -0700, Yury Norov wrote: > Don't call bitmap_clear() to clear 0 bits. > > bitmap_clear() can handle 0-length requests properly, but it's not covered > with static optimizations, and falls to __bitmap_set(). So we are paying a > function call + prologue work cost just for nothing. > > Caught with CONFIG_DEBUG_BITMAP: > [ 45.571799] > [ 45.571801] pcpu_alloc_area+0x194/0x340 > [ 45.571806] pcpu_alloc+0x2fb/0x8b0 > [ 45.571811] ? kmem_cache_alloc_trace+0x177/0x2a0 > [ 45.571815] __percpu_counter_init+0x22/0xa0 > [ 45.571819] fprop_local_init_percpu+0x14/0x30 > [ 45.571823] wb_get_create+0x15d/0x5f0 > [ 45.571828] cleanup_offline_cgwb+0x73/0x210 > [ 45.571831] cleanup_offline_cgwbs_workfn+0xcf/0x200 > [ 45.571835] process_one_work+0x1e5/0x3b0 > [ 45.571839] worker_thread+0x50/0x3a0 > [ 45.571843] ? rescuer_thread+0x390/0x390 > [ 45.571846] kthread+0xe8/0x110 > [ 45.571849] ? kthread_complete_and_exit+0x20/0x20 > [ 45.571853] ret_from_fork+0x22/0x30 > [ 45.571858] > [ 45.571859] ---[ end trace 0000000000000000 ]--- > [ 45.571860] b1: ffffa8d5002e1000 > [ 45.571861] b2: 0 > [ 45.571861] b3: 0 > [ 45.571862] nbits: 44638 > [ 45.571863] start: 44638 > [ 45.571864] off: 0 > [ 45.571864] percpu: Bitmap: parameters check failed > [ 45.571865] percpu: include/linux/bitmap.h [538]: bitmap_clear > > Signed-off-by: Yury Norov > --- > mm/percpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 3633eeefaa0d..f720f7c36b91 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -1239,7 +1239,8 @@ static int pcpu_alloc_area(struct pcpu_chunk *chunk, int alloc_bits, > > /* update boundary map */ > set_bit(bit_off, chunk->bound_map); > - bitmap_clear(chunk->bound_map, bit_off + 1, alloc_bits - 1); > + if (alloc_bits > 1) > + bitmap_clear(chunk->bound_map, bit_off + 1, alloc_bits - 1); > set_bit(bit_off + alloc_bits, chunk->bound_map); > > chunk->free_bytes -= alloc_bits * PCPU_MIN_ALLOC_SIZE; > -- > 2.34.1 > Acked-by: Dennis Zhou Thanks, Dennis