From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EE7EC43334 for ; Mon, 18 Jul 2022 21:38:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B58E56B0071; Mon, 18 Jul 2022 17:38:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE2086B0073; Mon, 18 Jul 2022 17:38:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95D346B0074; Mon, 18 Jul 2022 17:38:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 81A8B6B0071 for ; Mon, 18 Jul 2022 17:38:13 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 57B0480CD2 for ; Mon, 18 Jul 2022 21:38:13 +0000 (UTC) X-FDA: 79701534066.14.3999B61 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf31.hostedemail.com (Postfix) with ESMTP id B073F2005C for ; Mon, 18 Jul 2022 21:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658180291; x=1689716291; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rWXYDKxVPXg4e3PYB2fvhJbVOl7JEUozCmhPRc0BwnI=; b=YZn+fozZBldUoW3HYTu983MD3JNLcHyAAi+XicFgu5OBO3TKtSq3VPK/ WZ2DzbW96ff2uEiDqF9eCO5Eul7j9dNz47rriyi+dGSr5+Qyl3ubUDzor MGFvB/1DxN/N/rOmZ9x7fwYB2DXEmCEwsfaw7HXUVWmeRWqekWXjNFwt/ tYhbjJpv+f8xkgge9gNWWIsrspH9aGXaZJOTP+8mrmKWVEy2kLUaC3VI2 xvSXDfKRpjRiQpNPR+UGklcDUGsxS99U8YZqCPz2vyuqo+8ftR/qerB11 4HsJpJhIfNruHXrb4DMmcSsECouBG9DD5PSVzzPVUMy3usStVuzY6tIqJ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="283892319" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="283892319" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 14:38:10 -0700 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="686881800" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 14:38:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oDYRA-001OZv-0f; Tue, 19 Jul 2022 00:37:56 +0300 Date: Tue, 19 Jul 2022 00:37:55 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 08/16] smp: optimize smp_call_function_many_cond() for more Message-ID: References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-9-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718192844.1805158-9-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YZn+fozZ; spf=none (imf31.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658180291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GOprvhKx3LME4rhxs5HPVZlUBZjznEeFWeXjXPm4dSg=; b=vB1hGJuoOMnEKVVG/qH1mshU024zZLx54zkLaXSaLaMHrWbQPSg+ehBxoWHiDu6JKgpirn RpIHLiB3uiNZ+XkDeEArcx+Hya6t/geGG66G4NbChf3RhNJKrESYXUdBvMiUZKVbb19u4w r6dVB850nwJ4qEHTHZp0VUcYrTc8qnk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658180291; a=rsa-sha256; cv=none; b=E3wA7xSTuj5yIn3Tev8dsds1+m49kuczz37rqyY2rOpTsIZpqo5klFvf1Mr4khPjf91JJq L9fE5srg5k9cyDQ8AiSNFcWAVNlANhyoqus055w9336zwrdeKiAACvWBQiV5gazc6At8Wh cKaqrjHMXAkHn5g+ko49EnnXAVo4BXQ= X-Rspam-User: X-Rspamd-Queue-Id: B073F2005C Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YZn+fozZ; spf=none (imf31.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: bdcisor9gz6w4fxnkdbh149az9wqwejx X-Rspamd-Server: rspam07 X-HE-Tag: 1658180291-703907 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 18, 2022 at 12:28:36PM -0700, Yury Norov wrote: > smp_call_function_many_cond() is often passed with cpu_online_mask. > If it's the case, we can use cpumask_copy instead of cpumask_and, which > is faster. > > Caught with CONFIG_DEBUG_BITMAP: > [ 7.830337] Call trace: > [ 7.830397] __bitmap_check_params+0x1d8/0x260 > [ 7.830499] smp_call_function_many_cond+0x1e8/0x45c > [ 7.830607] kick_all_cpus_sync+0x44/0x80 > [ 7.830698] bpf_int_jit_compile+0x34c/0x5cc > [ 7.830796] bpf_prog_select_runtime+0x118/0x190 > [ 7.830900] bpf_prepare_filter+0x3dc/0x51c > [ 7.830995] __get_filter+0xd4/0x170 > [ 7.831145] sk_attach_filter+0x18/0xb0 > [ 7.831236] sock_setsockopt+0x5b0/0x1214 > [ 7.831330] __sys_setsockopt+0x144/0x170 > [ 7.831431] __arm64_sys_setsockopt+0x2c/0x40 > [ 7.831541] invoke_syscall+0x48/0x114 > [ 7.831634] el0_svc_common.constprop.0+0x44/0xfc > [ 7.831745] do_el0_svc+0x30/0xc0 > [ 7.831825] el0_svc+0x2c/0x84 > [ 7.831899] el0t_64_sync_handler+0xbc/0x140 > [ 7.831999] el0t_64_sync+0x18c/0x190 > [ 7.832086] ---[ end trace 0000000000000000 ]--- > [ 7.832375] b1: ffff24d1ffd98a48 > [ 7.832385] b2: ffffa65533a29a38 > [ 7.832393] b3: ffffa65533a29a38 > [ 7.832400] nbits: 256 > [ 7.832407] start: 0 > [ 7.832412] off: 0 > [ 7.832418] smp: Bitmap: parameters check failed > [ 7.832432] smp: include/linux/bitmap.h [363]: bitmap_and Same for long commit message noise. -- With Best Regards, Andy Shevchenko