From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D145C433EF for ; Mon, 18 Jul 2022 21:34:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDE5E6B0088; Mon, 18 Jul 2022 17:34:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8E9C6B0089; Mon, 18 Jul 2022 17:34:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5A338E0001; Mon, 18 Jul 2022 17:34:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A5A536B0088 for ; Mon, 18 Jul 2022 17:34:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8599D20C37 for ; Mon, 18 Jul 2022 21:34:30 +0000 (UTC) X-FDA: 79701524700.30.17D8F12 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf18.hostedemail.com (Postfix) with ESMTP id 331F11C0010 for ; Mon, 18 Jul 2022 21:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4kJIbH62hRR2GU6oL7niOpMGvgJbkAuiAh8TauODeGM=; b=K9gd2aVQ80EFQckNHQ6cK380ZK HVgrEGAtEYMwNDZLuKmmQevAkIDX/Rq1tSG0sLKaWBx7R9CDlGFTrC8APy1nIgyjXqaVFhWJtcVoH 6yNsLCNGec2r3gXm/c96Py1bHyc31J+alclZLvDbvGMZOIHp/5dOuaI3WVWP2F/aGih0poylZ07aS Nzd+bQ7i+rIXOf7cATAI8KFiWUr59wvMA0RfUXCITXgpygi1ngP55PglzHDfN/17HiNwChIFz3w5r 5DXTj4z7OJuhu2uXxWsdvCVMCNu8MBj2/bTERB/1QqMCaS7vQjsJBG8n759a5rH45OzOSkqX0UrRr K9L0Iu0Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDYNV-004uET-Nz; Mon, 18 Jul 2022 21:34:10 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id DBCF39802A7; Mon, 18 Jul 2022 23:34:08 +0200 (CEST) Date: Mon, 18 Jul 2022 23:34:08 +0200 From: Peter Zijlstra To: Yury Norov Cc: linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Andy Shevchenko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 10/16] sched: optimize __set_cpus_allowed_ptr_locked() Message-ID: References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-11-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718192844.1805158-11-yury.norov@gmail.com> ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=K9gd2aVQ; dmarc=none; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658180070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4kJIbH62hRR2GU6oL7niOpMGvgJbkAuiAh8TauODeGM=; b=Ikkcm1bSXiUFP4rYXGh5FXUik+kPvF0/2M99hq0h0N2X3McjjFaRkoZIVU42Xp+X67Q3Ht Kopm1KBITb0fWYnnjOa/zDE8ubXzI1rKf0DA52RGtRpmkeYgJcqcN14cB1wKCBGgdXBNLF IbzDrkebu8D4No1cG9hpdk9/C8Nybrk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658180070; a=rsa-sha256; cv=none; b=cp+FLX/LRwfMDTS0PyuSjNUuF9ze7K/J7uJ86aUBFA2JqE2SCtdciQ76Q1biLDfmdrFAV/ faT8aYxLIA4ot9mGd5kmk8xv+tKDEoQsWPSmZOmHZXZWgUHpj3ozs2oAT+uASotW5Y5mq8 Bm28Gh3o0NxVUx88yIUoCsBD7UwQoHk= X-Stat-Signature: wapqj9od3pm6tgowgop59bkngjm1ek9j X-Rspamd-Queue-Id: 331F11C0010 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=K9gd2aVQ; dmarc=none; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1658180070-565496 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 18, 2022 at 12:28:38PM -0700, Yury Norov wrote: > --- > kernel/sched/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index da0bf6fe9ecd..d6424336ef2d 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -2874,7 +2874,8 @@ static int __set_cpus_allowed_ptr_locked(struct task_struct *p, > cpu_valid_mask = cpu_online_mask; > } > > - if (!kthread && !cpumask_subset(new_mask, cpu_allowed_mask)) { > + if (!kthread && new_mask != cpu_allowed_mask && > + !cpumask_subset(new_mask, cpu_allowed_mask)) { Optimize cpumask_subset() for src1p == src2p instead? > ret = -EINVAL; > goto out; > } > -- > 2.34.1 >