From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F57ECCA479 for ; Mon, 18 Jul 2022 21:08:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24EAF6B007B; Mon, 18 Jul 2022 17:08:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FF2E8E0002; Mon, 18 Jul 2022 17:08:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5A66B007E; Mon, 18 Jul 2022 17:08:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F0CEB6B007B for ; Mon, 18 Jul 2022 17:08:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id C2592120D49 for ; Mon, 18 Jul 2022 21:08:53 +0000 (UTC) X-FDA: 79701460146.04.D681AA1 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf24.hostedemail.com (Postfix) with ESMTP id 2DA90180008 for ; Mon, 18 Jul 2022 21:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658178532; x=1689714532; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KTQG4RmtxzPJAdkE4J2lkvPJbDNJSkkFFy8SjpeMAuI=; b=Eez0NK5OpxuXdlT4C+OjzVamkXDYIwBdPbBDwPXafTm1sGGyBCKcXpNV QLjyHaU8x356XrqF46ZQwClYOl0KSb4fXjT60cWrnPIPyWNZsrqfdnoIH bm7V6cvOETQGw8GIs8ZYt3dxUZJXqE7LzUZl5mZqvlYm4YmKy2qpjq9fX gmTuSHCMjeB0HCl8xUOH9WNT2Ls62n3xSfB/SpP1v5SRny7zPvfIgmjLu YKGbux+YRbRv+knnf0osk9xjkxN+r+xChwq30XJlc2OdClgqw2PV3GG9S xhRW/nrsBvbPJ6FMWrtC/gr6GHYdEybMdVibELed55bNmXgKPsPGEv2UK w==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="266101840" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="266101840" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 14:08:50 -0700 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="686874569" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 14:08:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oDXym-001OYZ-0w; Tue, 19 Jul 2022 00:08:36 +0300 Date: Tue, 19 Jul 2022 00:08:36 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 03/16] lib/test_bitmap: don't test bitmap_set if nbits == 0 Message-ID: References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718192844.1805158-4-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658178532; a=rsa-sha256; cv=none; b=mDlUIknsF8/CYLiVMeAHbQvcNj7upfvP/WajOQafgOOLiwBVVM4sTeEu+wkxMsS+hiJ1eG 7ECSLR+khGauKFUgex/uXgq+7EGWoVXBx3C3UNPAdqbvLP9UNYbc59sqKE/jTi2ywypnxb kN2d/AdhFp9xK0nR136IKGf8bDQ9wwE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Eez0NK5O; spf=none (imf24.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.136) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658178532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Xs+eAbpdVhdnvI5RCff2wLvdoo3vK+gzLo5ZomaI40=; b=O2mU1v0i23ndNbEeNOJE9GiIdubKAwhQGtGoFNMnaikQzqR3vhhQPT70kkUmmalwM7R5Qh eWT139AyA9GPGm2bQsO5kpllt3i+jgvOpdD97S3TP9GorhmkiCTIOXD3OMrknTF2+JF1DS Ktxg59u2EzQvalTMsPyOTRM0YCp+mws= X-Stat-Signature: bw8x8h4i1i7xexih9s86xmshjpqhuh36 X-Rspamd-Queue-Id: 2DA90180008 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Eez0NK5O; spf=none (imf24.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.136) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1658178531-244177 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 18, 2022 at 12:28:31PM -0700, Yury Norov wrote: > Don't test bitmap_set(bitmap, start, 0) as it's useless, most probably > a sign of error in real code, and makes CONFIG_DEBUG_BITMAP barking. No, the test of not useful and sign of an error is a good thing to test! Test cases may be positive, may be negative. Code shouldn't fail badly because of that. I tend to give a NAK here. -- With Best Regards, Andy Shevchenko