From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37559C43334 for ; Mon, 18 Jul 2022 20:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD6306B0074; Mon, 18 Jul 2022 16:12:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B870A6B0075; Mon, 18 Jul 2022 16:12:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4DFF6B0078; Mon, 18 Jul 2022 16:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 964036B0074 for ; Mon, 18 Jul 2022 16:12:47 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 621A33B0 for ; Mon, 18 Jul 2022 20:12:47 +0000 (UTC) X-FDA: 79701318774.30.4C803E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 0181DC0005 for ; Mon, 18 Jul 2022 20:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658175166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XwWjdddtwE9SmGyJdyy2ifUdoyJyKXx7zMgX3yacSmE=; b=Es0RFdNQQZ7NFp4PXQ72WIfbeF6Urg5ZiTtqPnon/2aHu4X3bk93hmMZVdPzQu7ItwEyeR 48nxqQOJihDIc+RlSxr6FQ4d2em7pPU1OgZAYevEYAhUp2iVPiTpJ/R4L+E6Az427YCFkT /YVlFETPUME1VkDBzdg0WuUT0F51g0E= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-436-K8SL-FTrOW-2TYYoCSpSag-1; Mon, 18 Jul 2022 16:12:45 -0400 X-MC-Unique: K8SL-FTrOW-2TYYoCSpSag-1 Received: by mail-qk1-f197.google.com with SMTP id br36-20020a05620a462400b006b5fa8e5dd5so619315qkb.1 for ; Mon, 18 Jul 2022 13:12:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XwWjdddtwE9SmGyJdyy2ifUdoyJyKXx7zMgX3yacSmE=; b=uYw01W8CBQEEI5zxxFjNwE4/FT57P8tUjG7QxWc8/AfGjMYBICQlXRmiUvWTtgep6h t0Ki/YzYbLlrDz+feXI0MCgDWs+qHTbllWFEG1tC8f4wOf45b2YaxGOS3UAhxcSlf/GZ 2M9SGrKyQn7YvKSlC3NQvCYbxCVRTFr92q0GSPvCL5Zcp5U4Z9Ih2/oHZeuBtQl6X4ay L1nAcD9BifU0pbrr+lhnTLXZYS40hbh4WZ42aaidtzzRibuawvyEdnZali0vInLA4rzY zEqyK7sapQXI7VL707/oSEsB+XcGH58FgDaSI8ZEVk87WY0//OdnYDyX6ZTH16rHLqvN p//Q== X-Gm-Message-State: AJIora/k1LH5c+0cO5+zBz+UxIhE/RLEceQup1RMtJn3RkMmQWhEYEp0 Winwo1quRdWCSg+SGWUUT59YeCqDL3GVYRxlcfpn2hwjSPuA/0SJtaff+v/YM7BnvFWb0BL0IBG 32yjY3dvTZqI= X-Received: by 2002:ac8:7fce:0:b0:31d:34bd:66b4 with SMTP id b14-20020ac87fce000000b0031d34bd66b4mr22929303qtk.673.1658175165002; Mon, 18 Jul 2022 13:12:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tXp8Ld9spAUhvSaPUm/qZPU70hwmvfLJaEy7nYiFvH4l0Dh9BDWdhztz+ZigT8miM3fyvUxA== X-Received: by 2002:ac8:7fce:0:b0:31d:34bd:66b4 with SMTP id b14-20020ac87fce000000b0031d34bd66b4mr22929295qtk.673.1658175164767; Mon, 18 Jul 2022 13:12:44 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-37-74-12-30-48.dsl.bell.ca. [74.12.30.48]) by smtp.gmail.com with ESMTPSA id z17-20020ac84551000000b0031ecce4077fsm9651148qtn.31.2022.07.18.13.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 13:12:44 -0700 (PDT) Date: Mon, 18 Jul 2022 16:12:43 -0400 From: Peter Xu To: Nadav Amit Cc: linux-mm@kvack.org, Andrew Morton , Nadav Amit , Mike Kravetz , Hugh Dickins , Axel Rasmussen , David Hildenbrand , Mike Rapoport Subject: Re: [PATCH v2 3/5] userfaultfd: introduce write-likely mode for uffd operations Message-ID: References: <20220718114748.2623-1-namit@vmware.com> <20220718114748.2623-4-namit@vmware.com> MIME-Version: 1.0 In-Reply-To: <20220718114748.2623-4-namit@vmware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658175167; a=rsa-sha256; cv=none; b=nNERGwDWuJTo69Xo2NoONdWt42e22HSgLk7BKzv7O0642oTkVm8c7r47eTn9mRT6Pj4eSb 33jxwLbbtq+LxCb+vWoVSERcnQT3u/q9jMmHT4tAHV2qc7zQQ+5lWwGYmJ+LD08WLZQ6uc z1m9oU0SE+DdPc7El0dJzTiwqtyCz/E= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Es0RFdNQ; spf=none (imf28.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658175167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XwWjdddtwE9SmGyJdyy2ifUdoyJyKXx7zMgX3yacSmE=; b=l74rax016l13ElLQpZOsbg0RgbHUE3wMzdpOB8SOq7+TC4A/b9BPFL0qFtKKY2bI0wkb7Y 0XvkI20cNm5q6X9CPtUOXRH/y/GHYV18IADoTDITPhyR+pZV31nWOk+iFwaMVJOrzXNSKY hj+DkI1W2S3Jhl8EuxenzsQzaNm3biY= X-Stat-Signature: xxye1f8fzuinkorz1zxg4pwotp6pmurz X-Rspamd-Queue-Id: 0181DC0005 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Es0RFdNQ; spf=none (imf28.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1658175166-170386 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 18, 2022 at 04:47:46AM -0700, Nadav Amit wrote: > From: Nadav Amit > > Introduce write-likely hints for uffd. These hints would be used in a > future patch to decide whether to attempt to map pages in the page-table > or whether to only mark them logically as writable. This allows > userspace to determine whether a page would be accessed faster or > whether removal of the page would be possible, potentially, without > writeback and TLB flush. > > Cc: Mike Kravetz > Cc: Hugh Dickins > Cc: Andrew Morton > Cc: Axel Rasmussen > Cc: Peter Xu > Cc: David Hildenbrand > Cc: Mike Rapoport > Signed-off-by: Nadav Amit > --- > fs/userfaultfd.c | 32 ++++++++++++++++++++++++-------- > include/linux/userfaultfd_k.h | 1 + > include/uapi/linux/userfaultfd.h | 13 ++++++++++++- > 3 files changed, 37 insertions(+), 9 deletions(-) > > diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c > index 8d8792b27c53..3027d228550a 100644 > --- a/fs/userfaultfd.c > +++ b/fs/userfaultfd.c > @@ -1709,7 +1709,8 @@ static int userfaultfd_copy(struct userfaultfd_ctx *ctx, > if (uffdio_copy.src + uffdio_copy.len <= uffdio_copy.src) > goto out; > if (uffdio_copy.mode & ~(UFFDIO_COPY_MODE_DONTWAKE|UFFDIO_COPY_MODE_WP| > - UFFDIO_COPY_MODE_ACCESS_LIKELY)) > + UFFDIO_COPY_MODE_ACCESS_LIKELY| > + UFFDIO_COPY_MODE_WRITE_LIKELY)) > goto out; > > mode_wp = uffdio_copy.mode & UFFDIO_COPY_MODE_WP; > @@ -1719,8 +1720,11 @@ static int userfaultfd_copy(struct userfaultfd_ctx *ctx, > if (ctx->features & UFFD_FEATURE_ACCESS_HINTS) { > if (uffdio_copy.mode & UFFDIO_COPY_MODE_ACCESS_LIKELY) > uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + if (uffdio_copy.mode & UFFDIO_COPY_MODE_WRITE_LIKELY) > + uffd_flags |= UFFD_FLAGS_WRITE_LIKELY; > } else { > - uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY | > + UFFD_FLAGS_WRITE_LIKELY; > } > > if (mmget_not_zero(ctx->mm)) { > @@ -1774,14 +1778,18 @@ static int userfaultfd_zeropage(struct userfaultfd_ctx *ctx, > goto out; > ret = -EINVAL; > if (uffdio_zeropage.mode & ~(UFFDIO_ZEROPAGE_MODE_DONTWAKE| > - UFFDIO_ZEROPAGE_MODE_ACCESS_LIKELY)) > + UFFDIO_ZEROPAGE_MODE_ACCESS_LIKELY| > + UFFDIO_ZEROPAGE_MODE_WRITE_LIKELY)) > goto out; > > if (ctx->features & UFFD_FEATURE_ACCESS_HINTS) { > if (uffdio_zeropage.mode & UFFDIO_ZEROPAGE_MODE_ACCESS_LIKELY) > uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + if (uffdio_zeropage.mode & UFFDIO_ZEROPAGE_MODE_WRITE_LIKELY) > + uffd_flags |= UFFD_FLAGS_WRITE_LIKELY; > } else { > - uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY | > + UFFD_FLAGS_WRITE_LIKELY; > } > > if (mmget_not_zero(ctx->mm)) { > @@ -1834,7 +1842,8 @@ static int userfaultfd_writeprotect(struct userfaultfd_ctx *ctx, > > if (uffdio_wp.mode & ~(UFFDIO_WRITEPROTECT_MODE_DONTWAKE | > UFFDIO_WRITEPROTECT_MODE_WP | > - UFFDIO_WRITEPROTECT_MODE_ACCESS_LIKELY)) > + UFFDIO_WRITEPROTECT_MODE_ACCESS_LIKELY | > + UFFDIO_WRITEPROTECT_MODE_WRITE_LIKELY)) > return -EINVAL; > > mode_wp = uffdio_wp.mode & UFFDIO_WRITEPROTECT_MODE_WP; > @@ -1847,8 +1856,11 @@ static int userfaultfd_writeprotect(struct userfaultfd_ctx *ctx, > if (ctx->features & UFFD_FEATURE_ACCESS_HINTS) { > if (uffdio_wp.mode & UFFDIO_WRITEPROTECT_MODE_ACCESS_LIKELY) > uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + if (uffdio_wp.mode & UFFDIO_WRITEPROTECT_MODE_WRITE_LIKELY) > + uffd_flags |= UFFD_FLAGS_WRITE_LIKELY; > } else { > - uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY | > + UFFD_FLAGS_WRITE_LIKELY; > } > > if (mmget_not_zero(ctx->mm)) { > @@ -1903,14 +1915,18 @@ static int userfaultfd_continue(struct userfaultfd_ctx *ctx, unsigned long arg) > goto out; > } > if (uffdio_continue.mode & ~(UFFDIO_CONTINUE_MODE_DONTWAKE| > - UFFDIO_CONTINUE_MODE_ACCESS_LIKELY)) > + UFFDIO_CONTINUE_MODE_ACCESS_LIKELY| > + UFFDIO_CONTINUE_MODE_WRITE_LIKELY)) > goto out; > > if (ctx->features & UFFD_FEATURE_ACCESS_HINTS) { > if (uffdio_continue.mode & UFFDIO_CONTINUE_MODE_ACCESS_LIKELY) > uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + if (uffdio_continue.mode & UFFDIO_CONTINUE_MODE_WRITE_LIKELY) > + uffd_flags |= UFFD_FLAGS_WRITE_LIKELY; > } else { > - uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY; > + uffd_flags |= UFFD_FLAGS_ACCESS_LIKELY | > + UFFD_FLAGS_WRITE_LIKELY; > } > > if (mmget_not_zero(ctx->mm)) { > diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h > index b326798b5677..4968c86938b2 100644 > --- a/include/linux/userfaultfd_k.h > +++ b/include/linux/userfaultfd_k.h > @@ -60,6 +60,7 @@ typedef unsigned int __bitwise uffd_flags_t; > #define UFFD_FLAGS_NONE ((__force uffd_flags_t)0) > #define UFFD_FLAGS_WP ((__force uffd_flags_t)BIT(0)) > #define UFFD_FLAGS_ACCESS_LIKELY ((__force uffd_flags_t)BIT(1)) > +#define UFFD_FLAGS_WRITE_LIKELY ((__force uffd_flags_t)BIT(2)) > > extern int mfill_atomic_install_pte(struct mm_struct *dst_mm, pmd_t *dst_pmd, > struct vm_area_struct *dst_vma, > diff --git a/include/uapi/linux/userfaultfd.h b/include/uapi/linux/userfaultfd.h > index 02e0c1f56939..f52cbe4c9c44 100644 > --- a/include/uapi/linux/userfaultfd.h > +++ b/include/uapi/linux/userfaultfd.h > @@ -202,7 +202,7 @@ struct uffdio_api { > * write-protection mode is supported on both shmem and hugetlbfs. > * > * UFFD_FEATURE_ACCESS_HINTS indicates that the ioctl operations > - * support the UFFDIO_*_MODE_ACCESS_LIKELY hints. > + * support the UFFDIO_*_MODE_[ACCESS|WRITE]_LIKELY hints. > */ > #define UFFD_FEATURE_PAGEFAULT_FLAG_WP (1<<0) > #define UFFD_FEATURE_EVENT_FORK (1<<1) > @@ -257,9 +257,13 @@ struct uffdio_copy { > * page is likely to be access in the near future. Providing the hint > * properly can improve performance. > * > + * UFFDIO_COPY_MODE_WRITE_LIKELY provides a hint to the kernel that the > + * page is likely to be written in the near future. Providing the hint > + * properly can improve performance. > */ > #define UFFDIO_COPY_MODE_WP ((__u64)1<<1) > #define UFFDIO_COPY_MODE_ACCESS_LIKELY ((__u64)1<<2) > +#define UFFDIO_COPY_MODE_WRITE_LIKELY ((__u64)1<<3) > __u64 mode; > > /* > @@ -273,6 +277,7 @@ struct uffdio_zeropage { > struct uffdio_range range; > #define UFFDIO_ZEROPAGE_MODE_DONTWAKE ((__u64)1<<0) > #define UFFDIO_ZEROPAGE_MODE_ACCESS_LIKELY ((__u64)1<<1) > +#define UFFDIO_ZEROPAGE_MODE_WRITE_LIKELY ((__u64)1<<2) > __u64 mode; > > /* > @@ -296,6 +301,10 @@ struct uffdio_writeprotect { > * that the page is likely to be access in the near future. Providing > * the hint properly can improve performance. > * > + * UFFDIO_WRITEPROTECT_MODE_WRITE_LIKELY: provides a hint to the kernel > + * that the page is likely to be written in the near future. Providing > + * the hint properly can improve performance. > + * > * NOTE: Write protecting a region (WP=1) is unrelated to page faults, > * therefore DONTWAKE flag is meaningless with WP=1. Removing write > * protection (WP=0) in response to a page fault wakes the faulting > @@ -304,6 +313,7 @@ struct uffdio_writeprotect { > #define UFFDIO_WRITEPROTECT_MODE_WP ((__u64)1<<0) > #define UFFDIO_WRITEPROTECT_MODE_DONTWAKE ((__u64)1<<1) > #define UFFDIO_WRITEPROTECT_MODE_ACCESS_LIKELY ((__u64)1<<2) > +#define UFFDIO_WRITEPROTECT_MODE_WRITE_LIKELY ((__u64)1<<3) > __u64 mode; > }; > > @@ -311,6 +321,7 @@ struct uffdio_continue { > struct uffdio_range range; > #define UFFDIO_CONTINUE_MODE_DONTWAKE ((__u64)1<<0) > #define UFFDIO_CONTINUE_MODE_ACCESS_LIKELY ((__u64)1<<1) > +#define UFFDIO_CONTINUE_MODE_WRITE_LIKELY ((__u64)1<<2) > __u64 mode; I thought you would have some reasoning on having the flag for unprotect (since our last discussion you mentioned it) but it seems not there.. Then, could we only keep the zeropage write hint but drop the rest? They're never used in this whole series besides the zeropage one, meanwhile I think we're still not reaching consensus on whether they'll be helpful? Thanks, -- Peter Xu