From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22789C433EF for ; Sun, 17 Jul 2022 14:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A3F46B0071; Sun, 17 Jul 2022 10:48:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 853BA6B0072; Sun, 17 Jul 2022 10:48:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7428E6B0073; Sun, 17 Jul 2022 10:48:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 61DD36B0071 for ; Sun, 17 Jul 2022 10:48:13 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 359663452A for ; Sun, 17 Jul 2022 14:48:13 +0000 (UTC) X-FDA: 79696872066.06.9CDF59D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 1E0D118004B for ; Sun, 17 Jul 2022 14:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zg3lKm07i/XRUKG1J5yBXuQWVN/SwXdMkJ8fAyjZVmo=; b=iywJmjKFHgq/ARQuh+atQwVIvA FILkIUajNEfJ1DFe5/u66Z+kUlvfCYCh4t2aMqCWNHfWmd5kjMI68LD6/DKT1QFs5gYGNROYhHp7C vVulUjHl1Zzj0E3qB0iE980E96nM0AQFq/sgtrq9qPx1Qdz45IavU+8LnQGrJjZxewAut+mBm8gwT BChXAKgFkxSD2c2tj8/drGrftRAOQNxEQDgJl7VicsiStrcLHCxfe2kBmrZbUTXnK804qO7b1k2Ld u8jLuiPLe9cIs+B+kQTccWEIV+pgOevQf8KIg8G83n5EHRByb59aMgVdYc0biY1OJ/VgM88pxSUmI B7jsnvrg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oD5Yp-00BtUa-Oc; Sun, 17 Jul 2022 14:47:55 +0000 Date: Sun, 17 Jul 2022 15:47:55 +0100 From: Matthew Wilcox To: Li Hongyu Cc: "Liam R. Howlett" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Miguel Ojeda Subject: Re: [PATCH] maple: change the pointer name from maple_enode to maple_enode_p Message-ID: References: <20220717120652.GA9281@38c3a67cb865> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220717120652.GA9281@38c3a67cb865> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658069292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zg3lKm07i/XRUKG1J5yBXuQWVN/SwXdMkJ8fAyjZVmo=; b=3TP/H4sNvxGrnUJro8yySH5rC99a4GIc3MdLuWHdVgqOVfZ9g3dS2etKCBUz4VBO9zKcuj ox+k3vMTcbnCG3fyAOyWhgTIDt2rLmDf+WxxOIBF7LOWj2UvGHpNtqAi8QHE5c6le0/3LS 9rTM9Rp+7FO2DbZGgh1F2qLrwlJTwmc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658069292; a=rsa-sha256; cv=none; b=8ZIc5Oc61m04IkgTTocpWtBOGxPc264xo8BJg3B/JWuaZZVq5EMMjVSrraT2gEdzBhpsuz c2PqXo7i2bx5jbcVr/pTGkWU7wCSSnPO3bSams7iv5bEuBr7LJtLLSFqn9lEy3V8jonR6E S4UrhWEVwH5zEtKF/ARJCqRHDILGlvY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iywJmjKF; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: pz39ofuid53inc7rbrq6mgu7uozx9c8f X-Rspamd-Queue-Id: 1E0D118004B X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iywJmjKF; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam06 X-HE-Tag: 1658069291-725686 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 17, 2022 at 09:12:42PM +0900, Li Hongyu wrote: > The current name of the pointer to struct maple_enode is also > maple_enode. This is correct from the grammar point but can be > comfusing. Besides it seems in Linux it prefers typedef struct foo > *foo_p;, e.g. typedef struct cpumask *cpumask_var_t; and typedef > struct cgraph_node *cgraph_node_ptr;. I use re to search in the > Linux project and cannot find another example in typedef struct > foo *foo; style. > > This also results in a bug in the bindings of the > rust-for-linux subsystem, which can be seen in this github issue. > > https://github.com/Rust-for-Linux/linux/issues/795 > > The struct pointer maple_enode and maple_pnode are not used. It is > safe to change it to a new name. > > Signed-off-by: Li Hongyu > --- > include/linux/maple_tree.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h > index 2c9dede989c7..4886e019a2b5 100644 > --- a/include/linux/maple_tree.h > +++ b/include/linux/maple_tree.h > @@ -72,8 +72,8 @@ > * 0x010 : 32 bit values, type in 0-2, slot in 3-6 > * 0x110 : 64 bit values, type in 0-2, slot in 3-6 > */ > -typedef struct maple_enode *maple_enode; /* encoded node */ > -typedef struct maple_pnode *maple_pnode; /* parent node */ > +typedef struct maple_enode *maple_enode_p; /* encoded node */ > +typedef struct maple_pnode *maple_pnode_p; /* parent node */ If this is the only change needed, then clearly they're not being used, so just delete them?