From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424F3C433EF for ; Fri, 15 Jul 2022 17:38:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBEE694020A; Fri, 15 Jul 2022 13:38:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6E799401FB; Fri, 15 Jul 2022 13:38:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A368694020A; Fri, 15 Jul 2022 13:38:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 94EB89401FB for ; Fri, 15 Jul 2022 13:38:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 56A5715A7 for ; Fri, 15 Jul 2022 17:38:07 +0000 (UTC) X-FDA: 79690042614.24.36CE503 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id BC3FB180084 for ; Fri, 15 Jul 2022 17:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657906686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+QJFgzXdNV/CBVZ6SM9/IIKX+DwJmeA8immjPOoWrIc=; b=e2tZYFO10CBMw0LiEHtHne/UE4PVLeaL2qEo+8dYJVyo9gx/D9p1/MdvNR/wryzkfkU3WL XqY2+PSMgaVLAmGMnPl9MmRsHUOaQoCF0vsyYK7l4V4pPu/63XeVWTSyQuKkWH2dcxlrQC b8V7Y9uS8OEivCRTcDrNg7YTRRT64Lg= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-H1jAEP7SMka835X8veblzw-1; Fri, 15 Jul 2022 13:38:05 -0400 X-MC-Unique: H1jAEP7SMka835X8veblzw-1 Received: by mail-qt1-f198.google.com with SMTP id ca13-20020a05622a1f0d00b0031ed16bc026so3955130qtb.6 for ; Fri, 15 Jul 2022 10:38:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+QJFgzXdNV/CBVZ6SM9/IIKX+DwJmeA8immjPOoWrIc=; b=oD3lxT9P+kouqpttQBv8oshR6V994dYN/n0+kmkrjHDIEQLPs/b4iAG/dx0ndzSHcd 5qWqGx9X7k8dSz1h93F2EiqqC34+Nch/L+Tt8Nnc23WRjWxSMqtg87KXogelCp61RDLv M0JVhpDFXmoaubuoGNkbiVz0SbkJ4AIxlQdf23KjjkR/IZw/+5BrCmLfeGyDFPYmTQy0 iOVQn7uhEXB8Te+IlPNCaIM0PfyE3B8pHN2IK6h6mXKtcfn5LSTo4o3Ob48ZGiH7etx8 Hm52HJu2N8Gysw/amLMEnSuVySQ/TWM0sxGDfcYcE4u6YHs+0NYrtzdVzQjifUkUiLX2 RpEQ== X-Gm-Message-State: AJIora9M4IwnIJUbUow58rf/wEqmGE96iah/fY9+IGgpHwn6mkqZ1D9/ sai58c/2r6iiywcIdBam/dg1D5ZUU2u/s33qCaumYiI6/5BeNUAlsMQcoHgqrtwLR4eLelws5/F RkB5d38fHi/Q= X-Received: by 2002:a05:622a:3d2:b0:31e:9704:dfe4 with SMTP id k18-20020a05622a03d200b0031e9704dfe4mr13304149qtx.240.1657906684768; Fri, 15 Jul 2022 10:38:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t7MbHPD0/BZrxEZLLpMTZMXqpIbIlTg/PFCo+sShkoR38wOq6CLGHtWYk9DfydCQqcXSO1/g== X-Received: by 2002:a05:622a:3d2:b0:31e:9704:dfe4 with SMTP id k18-20020a05622a03d200b0031e9704dfe4mr13304133qtx.240.1657906684408; Fri, 15 Jul 2022 10:38:04 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-37-74-12-30-48.dsl.bell.ca. [74.12.30.48]) by smtp.gmail.com with ESMTPSA id s27-20020a05622a1a9b00b0031d3996d304sm4271352qtc.17.2022.07.15.10.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 10:38:03 -0700 (PDT) Date: Fri, 15 Jul 2022 13:38:01 -0400 From: Peter Xu To: Mike Kravetz Cc: Axel Rasmussen , Miaohe Lin , Andrew Morton , Muchun Song , Linux MM , LKML Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte Message-ID: References: <20220712130542.18836-1-linmiaohe@huawei.com> <20220713102357.8328614813db01b569650ffd@linux-foundation.org> <402ae708-4c86-8feb-75c4-9339e1deac3b@huawei.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657906687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+QJFgzXdNV/CBVZ6SM9/IIKX+DwJmeA8immjPOoWrIc=; b=LSLEgOCryA5g5P4KlCR3YpD8Lz54HmIq4jpXGzTWDlnr4gWhXM8vZ2V9upZhCPVMtFu0UL SNmbPAjCgwiY55xTylbujjihCTjJgaCGrOdG99vf7tEnYohADxRmueRdFS5fg8cnLNr1wX RG9Ho9LtkJGFNHX5bJ/rgRGuyj++Yoo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657906687; a=rsa-sha256; cv=none; b=Rp4NaPmKsJCSe9x7dhZtCG7VvLvlyQNgM8BO51kQiE7ncBaKvRTTAJ7V8qV5eNz7sK1m1C pQYudQrOC+PE1ZHlnpq2W5pSEQJ8Ai588L6juexDEdsCbesOe+19pSwP8PGME8nsJ7AFF2 iBGu3TZSm5QS4qSFMdoz8SfvkZPGwzg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e2tZYFO1; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-Stat-Signature: zggpqqspukyuego1cmngkhtpdc9noesg X-Rspamd-Queue-Id: BC3FB180084 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e2tZYFO1; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1657906686-539132 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 15, 2022 at 10:29:33AM -0700, Mike Kravetz wrote: > On 07/15/22 13:07, Peter Xu wrote: > > On Fri, Jul 15, 2022 at 09:45:37AM -0700, Axel Rasmussen wrote: > > > I don't really have a strong preference between the two. The second option > > > is what I originally proposed in the first version of the minor fault > > > series, so going back to that isn't a problem at least from my perspective. > > > If in the future we find a real use case for this, we could always easily > > > re-enable it and add selftests for it at that point. > > > > I'd go for fixing the test case if possible. Mike, would it be fine if we > > go back to /dev/hugepages path based approach in the test case? > > > > No problem going back to using a file for private mapping testing. Removing > that was more of a simplification, because of new MADV_DONTNEED support. > Just want to make sure we also keep remap and remove event testing. Yeah definitely, thanks Mike! -- Peter Xu