From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA32C433EF for ; Thu, 14 Jul 2022 18:16:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82A389401B5; Thu, 14 Jul 2022 14:16:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D96E9401A5; Thu, 14 Jul 2022 14:16:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A01D9401B5; Thu, 14 Jul 2022 14:16:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 584E79401A5 for ; Thu, 14 Jul 2022 14:16:03 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C9F93347C7 for ; Thu, 14 Jul 2022 18:16:02 +0000 (UTC) X-FDA: 79686509364.15.327FA71 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf27.hostedemail.com (Postfix) with ESMTP id 664CC40085 for ; Thu, 14 Jul 2022 18:16:02 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id bn33so3076581ljb.13 for ; Thu, 14 Jul 2022 11:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2QX/Lxw1dM3em+AdcVNETTOfkI14eEfg7V1aSOQdTQM=; b=cL80WLc/zql6U7gVA/bMoRIaeyJja2A7Hl+8eM1sjIXk66Z69jRPAKragoT+s5oy5k 1a8lc7LUo/0ZDCf2dAYC7YpNREsVd0CncKUzvRERTqnIbl3jCZT/M+6Mlz90DZP0LPBn cf7++pETwaA0ZfmkxaCN/CL2O2mgZP+X6tA3x+MxPdsIhW2wvuAEQjL0l4mloz5KY2uk HbSkdnKi7NbTpl4TVaQnbMbMDVLWqeE9PTKvc1LDsEBZDNUeWqyY+Rf1n3G/9Zmj34gZ PP5eWPuOXKBifT8R/noIRJY4rZywnQduq1Rncu2XnGHyRKmzuXz2etugNPmcDSmBV6ws tBPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2QX/Lxw1dM3em+AdcVNETTOfkI14eEfg7V1aSOQdTQM=; b=tBQ5EwVcHSNzTh0S9ha7uJW4ZX1e2mOSmhpY1DAhqk1huLj4i2Tg2rE394BOntcqy/ N5NnwEj+s6jjpcCFdLX5C50XdvGi7SdsIh/O7UzDQgqOj/xBkgFw9WwEeTnZBS+al259 8bW9lw8SLXmFBFTevh/TZigtrm3bh5cZGzKgNylAsX/YdElt6UJvFaQHRjjnFqK7TkTd qnP8dQT2BWymbgoIRtZs028nIgVJLVa6RuUgwvTJ5OBqTtq44lVCou4X38oDJ6YwKVUs mZQ7YVr+vZNZohE69/ICW88H2ND39BXg/KV2vtmWXdmnd4lPmxZqVm3pu/tarjS4TGVX N1eA== X-Gm-Message-State: AJIora+nmTLHUB4lCDeZ0YrQCt3OLVb2NARi27xzb8Xqwki7zMtmvodi qhkYSsEjxLeqL2uK6IuA6kU= X-Google-Smtp-Source: AGRyM1tpHk0AhqgOpToqpDTVrMgKe6SHJxLYZZJu+FPz/pCXoZQpyRbm608wTJYHdeLLsSOS4dK+hQ== X-Received: by 2002:a05:651c:158c:b0:250:a23d:2701 with SMTP id h12-20020a05651c158c00b00250a23d2701mr5429808ljq.475.1657822560608; Thu, 14 Jul 2022 11:16:00 -0700 (PDT) Received: from pc636 (host-90-235-11-208.mobileonline.telia.com. [90.235.11.208]) by smtp.gmail.com with ESMTPSA id bi32-20020a05651c232000b0025bbd5e3febsm386358ljb.132.2022.07.14.11.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 11:15:59 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 14 Jul 2022 20:15:56 +0200 To: Song Liu Cc: Christoph Hellwig , Song Liu , bpf , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "mcgrof@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "mhiramat@kernel.org" , "naveen.n.rao@linux.ibm.com" , "davem@davemloft.net" , "anil.s.keshavamurthy@intel.com" , "keescook@chromium.org" , "dave@stgolabs.net" , "daniel@iogearbox.net" , Kernel Team , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "rick.p.edgecombe@intel.com" , "akpm@linux-foundation.org" Subject: Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory Message-ID: References: <20220713071846.3286727-1-song@kernel.org> <20220713071846.3286727-2-song@kernel.org> <8AC2399B-F3B2-4F91-B18C-D9D3D5085471@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8AC2399B-F3B2-4F91-B18C-D9D3D5085471@fb.com> ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="cL80WLc/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657822562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2QX/Lxw1dM3em+AdcVNETTOfkI14eEfg7V1aSOQdTQM=; b=M4FJq+xtwsNin6ANrD+Kffn3Edp2lNlI2uzvbG6wDeOWSk+s7pU98B8xDFzXCiAzhrTQQR lF9tbyafsFQQAII7Z+YLfEzdFKNkl/0lZOxjU2X3FetfSmvMgG4I3WEf+a2mKJbvKB/jIK YO2gtl39tn0Wc/fVdqjdQeE+xiahtXM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657822562; a=rsa-sha256; cv=none; b=MdIp4OA30BuJQgLmGLRivRWG9rg6C/WSe6A07YEpFbK325gETr1ntoZpKhSuOsAe7I4Tbn j98V4irj4UC5UxTPSDKI9c1x8PrYohLL4SWib2KbULkPJel6l6ZLWpxT51k5NbhSe4WqhF XxW99BnwTM9a5m8rO5yJSki+nz8V/eY= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="cL80WLc/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 664CC40085 X-Rspam-User: X-Stat-Signature: 9yywtskbbi1z6ktyazczg1bdmzxrb7au X-HE-Tag: 1657822562-292671 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 14, 2022 at 04:54:40AM +0000, Song Liu wrote: > > > > On Jul 13, 2022, at 9:23 PM, Christoph Hellwig wrote: > > > > On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote: > >> > >> > >>> On Jul 13, 2022, at 3:08 AM, Christoph Hellwig wrote: > >>> > >>> NAK. This is not something that should be an exported public API > >>> ever. > >> > >> Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..) > > > > Even without that it really is not a vmalloc API anyway. > > This ... > > > Executable > > memory needs to be written first, so we should allocate it in that state > > and only mark it executable after that write has completed. > > ... and this are two separate NAKs. > > For the first NAK, I agree that my version is another layer on top of > vmalloc. But what do you think about Peter's idea? AFAICT, that fits > well in vmalloc logic. > I am not able to find the patch/change to see what you have done. But please do not build a new allocator on top of vmalloc code. We have three different ones what make things to be complicated :) -- Uladzislau Rezki