From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93656C43334 for ; Thu, 14 Jul 2022 15:45:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C14E79401AD; Thu, 14 Jul 2022 11:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC3DC9401A5; Thu, 14 Jul 2022 11:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB3FB9401AD; Thu, 14 Jul 2022 11:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9CF159401A5 for ; Thu, 14 Jul 2022 11:45:34 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6A651608BD for ; Thu, 14 Jul 2022 15:45:34 +0000 (UTC) X-FDA: 79686130188.09.211CEFA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 0DC951000BB for ; Thu, 14 Jul 2022 15:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657813533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/dzIwA4vz64Fdq+Tec7zAI7IQ5K1OCYtjvQ2rzb36hs=; b=DsYEujlzYulUcmYfnNdw8LLUx8anYfvcgDzGMYpKssrYQHIRbaNWdoyTEQFK5KSOpIaqSv b79LqTfdSYdImb/8pX0oeavQFWUJcWAGwoU8JLP73oV9hYKPVsUbbhu+BEQrNuR69KrBqt PA30BqDMYq2oIbVAJVGXAt7sgytb39A= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-155-5_mylmH9MhuDqUP6QSTc2A-1; Thu, 14 Jul 2022 11:45:32 -0400 X-MC-Unique: 5_mylmH9MhuDqUP6QSTc2A-1 Received: by mail-qt1-f198.google.com with SMTP id c22-20020ac81116000000b0031d25923ea8so1748429qtj.17 for ; Thu, 14 Jul 2022 08:45:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/dzIwA4vz64Fdq+Tec7zAI7IQ5K1OCYtjvQ2rzb36hs=; b=e8blewxuDMR8Jpccwaewy1qI6vwNvhY/DjgPUCcuIBsJA2Xbpuuhd5WjISOjQT3gGu jf4OZz6FiZbqfVQ51BoIqpOTGkopI5LeI8sKpB7wbfzKFoZjs8OrM2mfTaLpKkDQE9ux uVlK963FJkl2294QOYmHYbWsXvjZg80GIPr9JdeWHtmYBypmXELK19ZqLpfwEFx23TZy ymHmok7C6mouy9yRzj3JUcdWpW4ovdX8xnvU3y6KjOPopegwZA15vJuTR/aBeOtq/DkK vtbdQq6QLRV5RCKQYrXJOI1RJI+r6sYXRD6QPAqfOvmwOOx16IBjh2DDR6Qg3aUmOMAU BLag== X-Gm-Message-State: AJIora+B7tORKfysTT06cvJu4mbJG95ttkz05mb6rUP8W03OR3Vcez5Z hCjqWK4fb93KMOXafmEoLORwMphK3+aIAjHThiIIn+dAk1QU+55SrPicRixwptS/N/nFv576UJl vbvBYxRxZCyk= X-Received: by 2002:a0c:8084:0:b0:472:f26b:59f7 with SMTP id 4-20020a0c8084000000b00472f26b59f7mr8127386qvb.62.1657813531942; Thu, 14 Jul 2022 08:45:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t6oEt31b5+FHGmtHxJUjLrXvN2EA7KeRUBkXyvC1Ec9eZLkht9J5r7hUNUwO6xniY/dDBq8Q== X-Received: by 2002:a0c:8084:0:b0:472:f26b:59f7 with SMTP id 4-20020a0c8084000000b00472f26b59f7mr8127369qvb.62.1657813531765; Thu, 14 Jul 2022 08:45:31 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-37-74-12-30-48.dsl.bell.ca. [74.12.30.48]) by smtp.gmail.com with ESMTPSA id w22-20020ac843d6000000b0031eb02307a9sm1708746qtn.80.2022.07.14.08.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 08:45:31 -0700 (PDT) Date: Thu, 14 Jul 2022 11:45:29 -0400 From: Peter Xu To: Miaohe Lin Cc: Axel Rasmussen , Mike Kravetz , Andrew Morton , Muchun Song , Linux MM , LKML Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte Message-ID: References: <20220712130542.18836-1-linmiaohe@huawei.com> <1a27f20c-ed69-398a-5e6d-bb7ec5f14f5f@huawei.com> MIME-Version: 1.0 In-Reply-To: <1a27f20c-ed69-398a-5e6d-bb7ec5f14f5f@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657813534; a=rsa-sha256; cv=none; b=d6jYPDpFqwi6BnYqX75YK+uLb2TLSOyeAJ2bwYioUWm/0QliH9haI2na3r1CCW1RpSIZ44 HBQpAfTR40ZGMo2gHA5PD4qkX+T/1I+kPGnrwhCtR1RIcn55f3W5sPUBRS5Et2ysLBPj2s uqWunYFnsTUA48kCz9qS2Yq4Ievu3WU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DsYEujlz; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657813534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/dzIwA4vz64Fdq+Tec7zAI7IQ5K1OCYtjvQ2rzb36hs=; b=QcIRBMDh5R0rK+7vC4idhCjUSinEqvBsdF1vdQFFrpr0F+Wo9if6qBIFt/US83uuCqIheu efTcLRZVqOwmcBz1ocfUnnfkuU9Uai5j5wekMYay1dOCLPUQT0ZsbbuOxwHlx4Chs1ET7G 1HQpM8IKlusV5TaYmjkiS7p+gcCyFCo= X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DsYEujlz; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com X-Stat-Signature: zy1rxtf3fazb97dou1camcs5pyef3sus X-Rspamd-Queue-Id: 0DC951000BB X-Rspamd-Server: rspam08 X-HE-Tag: 1657813533-696257 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 14, 2022 at 06:09:49PM +0800, Miaohe Lin wrote: > As discussed in another thread, we might call page_dup_file_rmap for newly > allocated page (regardless of this patch). So should we come up a seperate > patch to call page_add_file_rmap here instead? Hmm, why we need page_add_file_rmap() even if a new page allocated? Say, we're at least also using page_dup_file_rmap() in hugetlb_no_page(). I see majorly two things extra there: memcg accounts on NR_FILE_MAPPED, and mlock. But I assume both of them will not apply to hugetlb pages? -- Peter Xu