From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28120C43334 for ; Mon, 11 Jul 2022 12:13:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A69A36B00C9; Mon, 11 Jul 2022 08:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A19346B00CA; Mon, 11 Jul 2022 08:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9082E6B00CB; Mon, 11 Jul 2022 08:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83A1A6B00C9 for ; Mon, 11 Jul 2022 08:13:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6020E6089F for ; Mon, 11 Jul 2022 12:13:07 +0000 (UTC) X-FDA: 79674708414.14.6F0855B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id D07B240094 for ; Mon, 11 Jul 2022 12:13:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A1A6A202F3; Mon, 11 Jul 2022 12:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657541585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RJTrqX4wTRC4bsbLa+oGGurpnRSIqFoGGm8rRNepF1U=; b=zWV2YtKM8u0yyeLAWJTZzMxHn40zWPKElXCwuTkoPuYgiCoFhPwZhsyCItkYFa7N/4Cwgb eorXLQtF4Vfng6IZvAGrd7zPPaxKUbLsRbnoT4m0SCJ8AYWFhBT8DYSBEwI+D5n6Qlb4s6 VY2tORPRBMXnduLHG9SGzQXTwh4ic8Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657541585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RJTrqX4wTRC4bsbLa+oGGurpnRSIqFoGGm8rRNepF1U=; b=2VOaoIIwZYq3AABcC05h0mvfyzwswoQ1gsj93jIqbTHuPSZhO+OaM4FCIhJKU/5NyaGqcV yR1PRBzv5MpRXxDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 747B613524; Mon, 11 Jul 2022 12:13:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BOhMG9ETzGIOCwAAMHmgww (envelope-from ); Mon, 11 Jul 2022 12:13:05 +0000 Date: Mon, 11 Jul 2022 14:13:04 +0200 From: Oscar Salvador To: Huang Ying Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi Subject: Re: [PATCH -V2 4/7] migrate_pages(): fix failure counting for THP subpages retrying Message-ID: References: <20220711084948.274787-1-ying.huang@intel.com> <20220711084948.274787-5-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711084948.274787-5-ying.huang@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657541587; a=rsa-sha256; cv=none; b=CfygSftu/9XGYTim38BTW8CA8orGPwCIIRoyvhFNrv0L27fk99ATo86qY8cm4Gbn29/VKq f81vaWjgKuouSZJjIhaMZXuBva9TBJEBE6W/rULL6FtsEpnwxlYveN+rWx9jTUEGOOJwnw PjNIfHj7CUtVY/gR7KRifKRl7/VHu1k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zWV2YtKM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2VOaoIIw; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657541587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RJTrqX4wTRC4bsbLa+oGGurpnRSIqFoGGm8rRNepF1U=; b=NYwWPCAWWMGBm3zXn8qMx5MSGTBCeyr/pPxurR4f3gm9HymASRyPQatlIZxl1CBY2hLGnX f4CcmvBjP+ZVBRXd9jWfbkv/i0KtqdaX1Kj+TAj87af7l0Yc4FmMCdCFHtwejgUg4dA1EI EkGYGZdE6ohLy/g4HZiZPY80lxts2wU= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D07B240094 X-Rspam-User: X-Stat-Signature: dona9cmk81491bz9aubdxwgqfarpcedy Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zWV2YtKM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2VOaoIIw; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1657541586-290912 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 11, 2022 at 04:49:45PM +0800, Huang Ying wrote: > If THP is failed to be migrated for -ENOSYS and -ENOMEM, the THP will > be split into thp_split_pages, and after other pages are migrated, > pages in thp_split_pages will be migrated with no_subpage_counting == > true, because its failure have been counted already. If some pages in > thp_split_pages are retried during migration, we should not count > their failure if no_subpage_counting == true too. This is done this > patch to fix the failure counting for THP subpages retrying. > > Signed-off-by: "Huang, Ying" > Fixes: 5984fabb6e82 ("mm: move_pages: report the number of non-attempted pages") > Reviewed-by: Baolin Wang > Cc: Zi Yan > Cc: Yang Shi Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs