From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3021C43334 for ; Mon, 11 Jul 2022 11:57:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44A6D6B00C5; Mon, 11 Jul 2022 07:57:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F9076B00C6; Mon, 11 Jul 2022 07:57:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C1B46B00C7; Mon, 11 Jul 2022 07:57:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1AEBE6B00C5 for ; Mon, 11 Jul 2022 07:57:22 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E8D11B97 for ; Mon, 11 Jul 2022 11:57:21 +0000 (UTC) X-FDA: 79674668682.27.B050CBD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf17.hostedemail.com (Postfix) with ESMTP id 7D72D40067 for ; Mon, 11 Jul 2022 11:57:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7ACDF20218; Mon, 11 Jul 2022 11:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657540640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iYcatKEW+q5bW/vlzXGidwV/BBFqHQS6h0HqRIuS6jU=; b=DN4t8sIucnIOzugkoQH9rK/FPjuKnU0HeQ/OfnRMiFpDY6Vm1Pe39PbJZ6EbIz+HhEkK9r 4O6vXhLEkPs+XVMuJ6vrBdXEMTA5ee7WxGTb5Rr6YImIm+IZeGWLpJv2/EfOpyUXgNYssF 889jYDZomWzNMIfuIM99JGYKagE1xQk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657540640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iYcatKEW+q5bW/vlzXGidwV/BBFqHQS6h0HqRIuS6jU=; b=536qo3gCx/uMV19ozGqyCwKX69wdlnOTYQwDsbWS+Zx9FS29sxJ/DNHIzUpp8wVae7jgBF TSWbsCyCW2379bBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A15913524; Mon, 11 Jul 2022 11:57:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Vm8CESAQzGJFAwAAMHmgww (envelope-from ); Mon, 11 Jul 2022 11:57:20 +0000 Date: Mon, 11 Jul 2022 13:57:18 +0200 From: Oscar Salvador To: Huang Ying Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi Subject: Re: [PATCH -V2 2/7] migrate_pages(): remove unnecessary list_safe_reset_next() Message-ID: References: <20220711084948.274787-1-ying.huang@intel.com> <20220711084948.274787-3-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711084948.274787-3-ying.huang@intel.com> ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DN4t8sIu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=536qo3gC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657540641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iYcatKEW+q5bW/vlzXGidwV/BBFqHQS6h0HqRIuS6jU=; b=P3cjILpiqgK5S/RegjcDCEVUMWKaEnrRt55ZED7TCq8s2oqxAHTMNcHvAf/4PHl4GEs3v3 bTra2ldXg5ZDtV5ZEuJ5k2FMlYfw7LgT/GVDwAEnL5QLRr4aeTw8FDBtaEKpz61f7ruoJa GUyP4IvfqY8WuM8w5Nb8LtmAF2mf28U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657540641; a=rsa-sha256; cv=none; b=AQzUiLY4G8D3A6zStQqLCLDDBFZDsQpR8U2ofU574JlHGfjWN7qLxzbtslWZkanm7L6d9V bbsu+fnvbGIfjsHSOvPttkLTJ6llEQ9HBSGCTBlXU5ODmdX9hal09hnZ5mOaFIpW/xUTRl TL70GuwPYD2msjcDjJZ7SVQx+XMUPw0= Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DN4t8sIu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=536qo3gC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: 46zs44xqi5yrfcf7b1eb7w48errd9pot X-Rspamd-Queue-Id: 7D72D40067 X-HE-Tag: 1657540641-111216 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 11, 2022 at 04:49:43PM +0800, Huang Ying wrote: > Before commit b5bade978e9b ("mm: migrate: fix the return value of > migrate_pages()"), the tail pages of THP will be put in the "from" > list directly. So one of the loop cursors (page2) needs to be reset, > as is done in try_split_thp() via list_safe_reset_next(). But after > the commit, the tail pages of THP will be put in a dedicated > list (thp_split_pages). That is, the "from" list will not be changed > during splitting. So, it's unnecessary to call list_safe_reset_next() > anymore. > > This is a code cleanup, no functionality changes are expected. > > Signed-off-by: "Huang, Ying" > Reviewed-by: Baolin Wang > Cc: Zi Yan > Cc: Yang Shi Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs