From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37C2C43334 for ; Mon, 11 Jul 2022 11:52:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13AF86B00C1; Mon, 11 Jul 2022 07:52:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EB176B00C2; Mon, 11 Jul 2022 07:52:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF5566B00C3; Mon, 11 Jul 2022 07:52:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0AEA6B00C1 for ; Mon, 11 Jul 2022 07:52:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B12C2209AE for ; Mon, 11 Jul 2022 11:52:37 +0000 (UTC) X-FDA: 79674656754.28.C57EAA7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id 230214002E for ; Mon, 11 Jul 2022 11:52:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B5926202F3; Mon, 11 Jul 2022 11:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657540355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TdFY1RWwGYvBePPQsPedAbt4Dp/hBwt/0QCbIDf8xuw=; b=xSvia/5kjnsgiJTeS1+fnuBLnvUcBv36rtCfS7WIITz0oa/2oUbO7QBdPgDJHRbsnLAu23 OSZjd7R4m+dDBcrCfboDKQHUGndAsgjHGUvh0Uu3f6p7D2TZmyrvUeDFXAyglK7odwySjF F6WQwSEPc6GZPis4SvofV6als9x5WYc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657540355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TdFY1RWwGYvBePPQsPedAbt4Dp/hBwt/0QCbIDf8xuw=; b=nadu+SnQgfvxOj2JXvvu2dsqQgtx7xswMcDR1BVYnm2uo/8CuykxWfZV2Uwk1sdX3uOYI8 58A41V7jd8QdtaBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B75413524; Mon, 11 Jul 2022 11:52:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8fjpIAMPzGK1fwAAMHmgww (envelope-from ); Mon, 11 Jul 2022 11:52:35 +0000 Date: Mon, 11 Jul 2022 13:52:34 +0200 From: Oscar Salvador To: Huang Ying Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi Subject: Re: [PATCH -V2 1/7] migrate: fix syscall move_pages() return value for failure Message-ID: References: <20220711084948.274787-1-ying.huang@intel.com> <20220711084948.274787-2-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711084948.274787-2-ying.huang@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657540357; a=rsa-sha256; cv=none; b=LxAcR17fhgrvOrHdi+D4HvkGOS7gDgHfNhyQftpJ7u74a4AYpDHp0xVVAk1iDO2FXjekOC TKlZ7Xer4Tvd5Hh4oKajKXyuh8U2rkpeIfQfB8TBHu/GcMbUbciYY1Qj3mgGEUrPma6YPg VBu1D6d+6jZ9Krx5J+QpbIyR3RnMYeY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="xSvia/5k"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nadu+SnQ; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657540357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TdFY1RWwGYvBePPQsPedAbt4Dp/hBwt/0QCbIDf8xuw=; b=2TcrSTFVqBvii+nokl9sjBbfj699nePqKda87m0KFuMBuRwnoGUm9YgO03AJUpMuYQPSLk OfI3Thk3HUvnJobLcvHRa3x/11SNH58cXFh+QFEMCfv2LUJ7Eab0C4/42ZvufVj5MXe3AA yKMoQTKdCzPg5aolcnfyJuHx69ksVUo= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 230214002E X-Rspam-User: X-Stat-Signature: dzi3xtwwx169jbpcfq54apms4wg5f8xf Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="xSvia/5k"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nadu+SnQ; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1657540357-981890 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 11, 2022 at 04:49:42PM +0800, Huang Ying wrote: > return store_status(status, start, node, i - start); > @@ -1768,8 +1768,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > > err = move_pages_and_store_status(mm, current_node, &pagelist, > status, start, i, nr_pages); > - if (err) > + if (err) { > + /* We have stored status of page i */ IMHO, "We have accounted for page i" gives a more clear statement. Reviewed-by: Oscar Salvador > + if (err > 0) > + err--; > goto out; > + } > current_node = NUMA_NO_NODE; > } > out_flush: > -- > 2.30.2 > > -- Oscar Salvador SUSE Labs