From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0EB3CCA47B for ; Mon, 11 Jul 2022 14:35:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6081F6B00F3; Mon, 11 Jul 2022 10:35:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B88A8E0002; Mon, 11 Jul 2022 10:35:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A75F6B00F5; Mon, 11 Jul 2022 10:35:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 36DE46B00F3 for ; Mon, 11 Jul 2022 10:35:45 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 006DE20D23 for ; Mon, 11 Jul 2022 14:35:44 +0000 (UTC) X-FDA: 79675067850.25.2B922B0 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by imf16.hostedemail.com (Postfix) with ESMTP id DABF9180061 for ; Mon, 11 Jul 2022 14:35:43 +0000 (UTC) Date: Mon, 11 Jul 2022 16:35:39 +0200 From: Pablo Neira Ayuso To: Bill Wendling Cc: isanbard@gmail.com, Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Subject: Re: [PATCH 12/12] netfilter: conntrack: use correct format characters Message-ID: References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-13-morbo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220609221702.347522-13-morbo@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657550144; a=rsa-sha256; cv=none; b=VV5WrPLPUxZ8TCyeqku9Xkny1r4LUAq9v7SPZqz88RRWiM3LOQZr+aAShQq5Dmoa60toSb 5EcvlVEvpCLAldony1Ze63twr2vrV9Qm67U1oQATgj1trh5NLxvGqoiUWQ5mcBUaUeyMH8 mFQghoJMXx1TGogEeEA0zPSnE0LKRO0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of pablo@netfilter.org designates 217.70.188.207 as permitted sender) smtp.mailfrom=pablo@netfilter.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657550144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEIdMBxgF/UN00ALth79jw+eX2jGrtehNAQHz0JFy2w=; b=u0MmcS9nFzS9BR+QGIINfUhunEAvdyK4sdcqmyFDiHs4X+0BqZCpxff7AezE/WQdsMqr+7 HeFDxaSF/M2IIVJCEEdT4x8K911pcx+Skw6GRaVnHxenA+M+oAJ3bnetWl0tyhgbHaHFEW +UEEMdKubBWD3ucTTQwxALh+xmA6fPk= Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of pablo@netfilter.org designates 217.70.188.207 as permitted sender) smtp.mailfrom=pablo@netfilter.org X-Stat-Signature: g59dzbyi9euwrk4mqdo88tmg9b7axwok X-Rspamd-Queue-Id: DABF9180061 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1657550143-43884 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 10:16:31PM +0000, Bill Wendling wrote: > From: Bill Wendling > > When compiling with -Wformat, clang emits the following warnings: > > net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > request_module(mod_name); > ^~~~~~~~ > > Use a string literal for the format string. Applied this patch to nf-next, thanks