From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D80C433EF for ; Mon, 11 Jul 2022 10:18:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED22C6B00BB; Mon, 11 Jul 2022 06:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E82EA6B00BC; Mon, 11 Jul 2022 06:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D70676B00BD; Mon, 11 Jul 2022 06:18:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C99616B00BB for ; Mon, 11 Jul 2022 06:18:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9622220321 for ; Mon, 11 Jul 2022 10:18:24 +0000 (UTC) X-FDA: 79674419328.27.3E4D288 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 040C320066 for ; Mon, 11 Jul 2022 10:18:22 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id fz10so4449087pjb.2 for ; Mon, 11 Jul 2022 03:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OEP5c1Ts3y3jjcZd/vxo+DFJNaZAkcnY9wcB9rKwQk0=; b=8XMkm5VW53KdDaQvf+q37G9BYrf6ehTATfsf9ZgZosxgK5egvreQu1XDJoLFzGoxrY Spx4dIrYlGbHhKpGEAcH5SzpGOAVzKW0A/dn/krSdYeqGQoe5Sok0fUzEw74itmR57FW G8icen7/bsNrDOQqcQAy1CAUZHxDT3MyQLnFq0auLHAN1gCb808h7M1YXNy+iKHSZdUh QrkiA4RJfYEvDm7KtWKvEEuFML8KJBUfdV/5rhTe2Q6tHj0+o8ywPyFv3/0dCQ/Xrp8r hv6IlainqJPCGq+AN++UdANZFlv0xPCR6W+DIh/6wI4wQ7EIElt95OaP5psBkJ15one+ 7lAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OEP5c1Ts3y3jjcZd/vxo+DFJNaZAkcnY9wcB9rKwQk0=; b=y2YoYRsJvxwds61YF9JAEzLWksS6Q2YpXlpQ3B9OTCm3kYXlTonm3G03T/ofW+cEB/ 9Bhq5LKyRGBxDPgGoebQL1GSQojnDKiY5BA6o5tPPmEJnMvnsqybq9CIVjl3CmZBomBi CM6YhYfHsQaBbnhAIEA6CnoPsAC08XR0Cf8WINTScAxXIndV9GKq+4W6Bm04BA9+xHNN f0tdVKxfqAG1yXTVM8oQjUe99xQPXofXaO2QcJpeoJMvk1mIZPF8I0x3GxpC1QHuJJU4 ZNCWrmupQl8S62xEp+h/LUzxivciwkYUErd+/CJ3P1PR1XTSgoDjQ3jLdRi8+Z/2r6VN A0Dg== X-Gm-Message-State: AJIora9iiHqmHn5EclwhfeDGtq22+m2RAbPIhdZ7wxZ9ZmJbrN+KEKD9 t7CYihkgvf9HjvXjXNBd+hp5tA== X-Google-Smtp-Source: AGRyM1sIYzLIe4/E3L+3duTvdoRwBoXV+BsrpUmKJRMQpAv5GS6y4B0utoiHVD2sU7/U5uNCjty5uQ== X-Received: by 2002:a17:902:aa82:b0:16c:4bee:1f90 with SMTP id d2-20020a170902aa8200b0016c4bee1f90mr4181686plr.69.1657534701800; Mon, 11 Jul 2022 03:18:21 -0700 (PDT) Received: from localhost ([61.120.150.77]) by smtp.gmail.com with ESMTPSA id k22-20020aa79736000000b00528f9597fb3sm4383091pfg.197.2022.07.11.03.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 03:18:21 -0700 (PDT) Date: Mon, 11 Jul 2022 18:18:18 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hugetlb: fix memoryleak in hugetlb_mcopy_atomic_pte Message-ID: References: <20220709092629.54291-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220709092629.54291-1-linmiaohe@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657534703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OEP5c1Ts3y3jjcZd/vxo+DFJNaZAkcnY9wcB9rKwQk0=; b=7Avm/cy/mR+TULdPLuTZYhqTf5Z6FhnKw+RkLAqQ5BcKpYSIEThqsfoz2k2DT92QJcXmWG 6bXw66zJsdHzBmUx3DmS3wLieamy75xgV1CvkUnGo8jLtKJyoYZIvvSQMLABZN7lUwryyR zcc3xnumC8EkW+JmHkqUA6iDrPTtVJc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657534703; a=rsa-sha256; cv=none; b=h9ie4yH71Tr7sYFzor8QZfwWeEsxmVeb+FliAjS3+VS0wQQX9XlFALcGQV4mTFstHVQWw2 wx+jPm90bp/FYENoYqFv6vdwwqeG1MzVp6qmiGxmGPgp2CucyHjtDfRvjfAgx0MtC19L/p gjzTI/cf+sKoLTtbcM7FjTOsHjA2sms= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=8XMkm5VW; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: hi1ue4y86ambopqjoyh9cqy6dz5atrkd X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=8XMkm5VW; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 040C320066 X-HE-Tag: 1657534702-36413 X-Bogosity: Ham, tests=bogofilter, spamicity=0.031477, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 09, 2022 at 05:26:29PM +0800, Miaohe Lin wrote: > When alloc_huge_page fails, *pagep is set to NULL without put_page first. > So the hugepage indicated by *pagep is leaked. > > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY") > Signed-off-by: Miaohe Lin Acked-by: Muchun Song Thanks.