From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F32C433EF for ; Thu, 7 Jul 2022 15:06:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F6206B0072; Thu, 7 Jul 2022 11:06:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A5306B0073; Thu, 7 Jul 2022 11:06:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51F29900002; Thu, 7 Jul 2022 11:06:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4279A6B0072 for ; Thu, 7 Jul 2022 11:06:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A9D834DD6 for ; Thu, 7 Jul 2022 15:06:57 +0000 (UTC) X-FDA: 79660631274.09.8AEA10A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 95DE814002A for ; Thu, 7 Jul 2022 15:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657206416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UinEqYT5P2BUTkxNTDp3jNgzt4lAPnjhnDB8MAsyPX4=; b=MVaVvIycFuwozBrnB4hWejJs5k8Fh7sCF1QLW1r/CaVTxSDg9Tv6KZ6joTgI7RcGWtl+wt KUcJmc8t5FBuhqrCEfUCfFKz3M5DijNlvmYPp8II/gN88TeJxQ5a6pR09tH6sqT67lmQQn ks0JWAah3B3A74W+BMFzxZYmm0zH3mY= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-386-YriVLEzXPTyNPK54OE481Q-1; Thu, 07 Jul 2022 11:06:54 -0400 X-MC-Unique: YriVLEzXPTyNPK54OE481Q-1 Received: by mail-qt1-f200.google.com with SMTP id q21-20020ac84115000000b0031bf60d9b35so15563250qtl.4 for ; Thu, 07 Jul 2022 08:06:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UinEqYT5P2BUTkxNTDp3jNgzt4lAPnjhnDB8MAsyPX4=; b=mA9NbtO2mbKqTa06zfA6/adolMRYTsB6S/blVxeJQSgd2a+9KNvU2dJQ/hAZNYqZ5o C44CcWf3O0/+GfkXl2u400JayEQcAouFsHVgzxxDe/6QivrIcA1+DYZoygvglcCtaHOC UHIbilMZS+iS7HbUTULmT86oQUvu0jIMN+VAPOT5KL+9w0QXWYq1643OwoytBih9lwQJ xwE9MHDdIxnaydsEuHyMGVrtQWgkky57Do4af87ICofz6HXxzMjvOI9uZnfn/9caKYdH SFPZWdVZ4QutDAOfhAVlVrhWXPbmu1otAwq5w/SexkGbxitDEV+7Ft4ud5BpiE0lY9dL zmGg== X-Gm-Message-State: AJIora8AHFktgL238uTYUBb3DmDhPjE6qUjM6mX0k9V2IYGmxvSiJuV3 NQpEur6oW0TVkp4mERBqWpX2XFwbcxgRWXhyQ9+N3hQA+nxNaiyOxi4LgZOn4HamCQydh+MSgKu 2t4e1Lgy8szw= X-Received: by 2002:a05:620a:1ed:b0:6b5:51ef:a01b with SMTP id x13-20020a05620a01ed00b006b551efa01bmr2234436qkn.672.1657206413982; Thu, 07 Jul 2022 08:06:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1veVQQ17tD7Ufgu37nRA9WzoyJWV+Q9os145bMm7/zYt0YRDhjZ/MSZMr+nKljNFfFJ65mMdA== X-Received: by 2002:a05:620a:1ed:b0:6b5:51ef:a01b with SMTP id x13-20020a05620a01ed00b006b551efa01bmr2234378qkn.672.1657206413610; Thu, 07 Jul 2022 08:06:53 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-37-74-12-30-85.dsl.bell.ca. [74.12.30.85]) by smtp.gmail.com with ESMTPSA id j17-20020ac84c91000000b002f39b99f6a4sm20992646qtv.62.2022.07.07.08.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 08:06:52 -0700 (PDT) Date: Thu, 7 Jul 2022 11:06:49 -0400 From: Peter Xu To: Matthew Wilcox Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657206416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UinEqYT5P2BUTkxNTDp3jNgzt4lAPnjhnDB8MAsyPX4=; b=3BE5bwFGHxEBUw499ik+6b0leo2bPWSkjd4UxmDhKVw7mxUYbeCRZG98eT6lZffLaoFkNQ uOhKQTJZyREVsAlOSPL7eqW9LnTXNKJtWfKZwpIUvGOCJ/kBnSpkdDOOUDl1oQVZeNpL9m 0Lg8KSQSWABt7a7Bp1Hs/0a7nQIIb/s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657206416; a=rsa-sha256; cv=none; b=VNSirszYqJbaRsZJkJgTqO41bpIK/OKyi53OEMjE3M4d6XJaTy0ZC3t2LL+vhYqKshVm4P s88DledqYr8NPudzTL2/+8MMyWsmswjHGLq6mh/2B9OGOCaPspvfxY5FFSYx9kLwTOeihG lx95c6kU3/sL9B9QqW+yUQWJQmi4kkQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MVaVvIyc; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-Stat-Signature: ndgudbgt3z7j9jzoxz3wsjsn1o86jdf3 X-Rspamd-Queue-Id: 95DE814002A X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MVaVvIyc; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam10 X-HE-Tag: 1657206416-118107 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 04, 2022 at 11:48:17PM +0100, Matthew Wilcox wrote: > On Wed, Jun 22, 2022 at 05:36:53PM -0400, Peter Xu wrote: > > +/* > > + * GUP always responds to fatal signals. When FOLL_INTERRUPTIBLE is > > + * specified, it'll also respond to generic signals. The caller of GUP > > + * that has FOLL_INTERRUPTIBLE should take care of the GUP interruption. > > + */ > > +static bool gup_signal_pending(unsigned int flags) > > +{ > > + if (fatal_signal_pending(current)) > > + return true; > > + > > + if (!(flags & FOLL_INTERRUPTIBLE)) > > + return false; > > + > > + return signal_pending(current); > > +} > > This should resemble signal_pending_state() more closely, if indeed not > be a wrapper of signal_pending_state(). Could you be more specific? Note that the only thing that should affect the signal handling here is FOLL_INTERRUPTIBLE, we don't allow anything else being passed in, e.g. we don't take TASK_INTERRUPTIBLE or TASK_*. Thanks, -- Peter Xu