From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FCDAC43334 for ; Wed, 6 Jul 2022 22:26:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A10106B0073; Wed, 6 Jul 2022 18:26:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C13C8E0002; Wed, 6 Jul 2022 18:26:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8889A8E0001; Wed, 6 Jul 2022 18:26:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 76D786B0073 for ; Wed, 6 Jul 2022 18:26:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 4DC1F804B9 for ; Wed, 6 Jul 2022 22:26:34 +0000 (UTC) X-FDA: 79658110308.13.D70D4DF Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf15.hostedemail.com (Postfix) with ESMTP id EF77FA0034 for ; Wed, 6 Jul 2022 22:26:33 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id d3so15251163ioi.9 for ; Wed, 06 Jul 2022 15:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tdMeO7jrD/dIfpY7p2JB9yqnBwdG8BahWjwdHXRbu1k=; b=naH4kwPAB5R8CvE/dGvN0fuWyppIK1xf3NBrtyjW3Y41AYDfdBR/vtTJnvbs61H6Bo ctYrY2owT9GvOmsWDgCOAHQ9N4p3OuMvnM15cYJnx8ESbgjggdI3/H3dE5nyD24iZiro 35f2BbIakOw/NQnp6rDPvUYH56fdY3+FoExVEiTlkSriCXKCBNApax4DuFDx0PiUOnGo Sb4FO7GPktbl3uEUcchhWKqeD/MWyl0Bw0HJ29aEPK1/cCnq/tBxWsiqivcUreYflkEl 5tQnpP8XmFtnwcM5inWfp5G8mEVBx8TmTScYhsQqkDh/aIWK+uurX2OglenfVAYr/j11 vovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tdMeO7jrD/dIfpY7p2JB9yqnBwdG8BahWjwdHXRbu1k=; b=ybEt2SDh5hsfau46/f3Nc54JTtp0CxR6GIwd4RBRQEpAO457bfYW0xQPCixnMvVX1+ FW++HeMU9WaCxB/XCcgBpnMObDbxtIHDzCCKBIRwG+uWqmc4QpLkyyuOGc+CY5qZyrYM +z0pypXeYW1MehU36aLlmsc4ucvzRajDI9xCjGQVOYaEpzs1gJzsUL87wBsvub3L5Jo2 rxTJpPyfpYwGJm2NRsfHsDOr4l+F6tqy2ENLHw12XoBTuuSayazsmFhy/mhAdNNG3o3+ +gDC1bciXLDuzlMe1q0Gw3Vj0HVWRNbe1UjrS7KCrxhVDJrZHNIgVFaCwHuADPEwLivq Upnw== X-Gm-Message-State: AJIora+DGhaO/S0rnsYIXQkn8H5UbxWq8DDSSYCOAsBwePKH99RETJmM k4/AR+3aHwr4zfxyuNAThOqm0w== X-Google-Smtp-Source: AGRyM1s0AIMCH99LiToMeYSdiGPBoRUTHvuuNfnnciKcHf9pq+YmScNTAa9bLACPyJfsm70G4LXStw== X-Received: by 2002:a05:6638:31c2:b0:32e:167a:d887 with SMTP id n2-20020a05663831c200b0032e167ad887mr26983433jav.197.1657146393078; Wed, 06 Jul 2022 15:26:33 -0700 (PDT) Received: from google.com ([2620:15c:183:200:b89c:e10a:466e:cf7d]) by smtp.gmail.com with ESMTPSA id e25-20020a0566380cd900b00339ee768069sm16275743jak.74.2022.07.06.15.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 15:26:32 -0700 (PDT) Date: Wed, 6 Jul 2022 16:26:27 -0600 From: Yu Zhao To: Andrew Morton , Liam Howlett Cc: Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v13 08/14] mm: multi-gen LRU: support page table walks Message-ID: References: <20220706220022.968789-1-yuzhao@google.com> <20220706220022.968789-9-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706220022.968789-9-yuzhao@google.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657146394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tdMeO7jrD/dIfpY7p2JB9yqnBwdG8BahWjwdHXRbu1k=; b=0SE/pvJ2gpMGFrnrVnePx3IUK+mXNVqJ+zYk/aN9XYYhvwTBJ6K4VNaUk4Q9mUtlsqtvSC /6zhPrnZ0R9VK/LHx7XsTbkYo4rRRtYr8rEWYx4kDuhR7I69gqgWoJpheX89bsxO7lm27H OXsllf3T9FICrGiwQ7DUIYzLk8Ie1xg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=naH4kwPA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657146394; a=rsa-sha256; cv=none; b=IskDKjv2ktU7cBOeT9PwI5dIQPD2wfC+MXSSmdBpo5vnpS4hzvo+O4NnQJ1AqFihkRL159 pO1IDLTqPXbUOsnkmjdU+CuSVt95twsrjapWmjvugQA27utfq5V4ITP76UO5teuhjZgSha ih+OzuJxHlY6cgfUZL4AEeuBVAoWFMg= X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: sehc67i7ucx4km9msba8jqmjknn6w4wz X-Rspamd-Queue-Id: EF77FA0034 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=naH4kwPA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=yuzhao@google.com X-HE-Tag: 1657146393-745901 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 06, 2022 at 04:00:17PM -0600, Yu Zhao wrote: ... > +/* > + * Some userspace memory allocators map many single-page VMAs. Instead of > + * returning back to the PGD table for each of such VMAs, finish an entire PMD > + * table to reduce zigzags and improve cache performance. > + */ > +static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk *args, > + unsigned long *vm_start, unsigned long *vm_end) > +{ > + unsigned long start = round_up(*vm_end, size); > + unsigned long end = (start | ~mask) + 1; > + > + VM_WARN_ON_ONCE(mask & size); > + VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask)); > + > + while (args->vma) { > + if (start >= args->vma->vm_end) { > + args->vma = args->vma->vm_next; > + continue; > + } > + > + if (end && end <= args->vma->vm_start) > + return false; > + > + if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) { > + args->vma = args->vma->vm_next; > + continue; > + } > + > + *vm_start = max(start, args->vma->vm_start); > + *vm_end = min(end - 1, args->vma->vm_end - 1) + 1; > + > + return true; > + } > + > + return false; > +} To make the above work on top of the Maple Tree: diff --git a/mm/vmscan.c b/mm/vmscan.c index 7096ff7836db..c0c1195da803 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3689,23 +3689,14 @@ static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk { unsigned long start = round_up(*vm_end, size); unsigned long end = (start | ~mask) + 1; + VMA_ITERATOR(vmi, args->mm, start); VM_WARN_ON_ONCE(mask & size); VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask)); - while (args->vma) { - if (start >= args->vma->vm_end) { - args->vma = args->vma->vm_next; + for_each_vma_range(vmi, args->vma, end) { + if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) continue; - } - - if (end && end <= args->vma->vm_start) - return false; - - if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) { - args->vma = args->vma->vm_next; - continue; - } *vm_start = max(start, args->vma->vm_start); *vm_end = min(end - 1, args->vma->vm_end - 1) + 1;