From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B816C43334 for ; Wed, 6 Jul 2022 15:46:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D74446B0071; Wed, 6 Jul 2022 11:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFD486B0073; Wed, 6 Jul 2022 11:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC71D6B0074; Wed, 6 Jul 2022 11:46:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AA9DD6B0071 for ; Wed, 6 Jul 2022 11:46:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 7619D80198 for ; Wed, 6 Jul 2022 15:46:18 +0000 (UTC) X-FDA: 79657101636.29.51C6DE3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 106B940013 for ; Wed, 6 Jul 2022 15:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZMPiGOu1gsOrP+OcjmrgLm7lfQsrjdxIxBZ6JkHGY4s=; b=Igpy4Ztjw6EHxP2kGcUQABTJik ouxzd2xaG1VFa/TwwQyX8nCf+NZbuPs26JHzK8ELixfm2UjEcG99xdhcY0ijhI1LtxN1TtWXXB1wL QBSZiM37PnQUgp8ys5M4sk1urMtXH3tFmEn9tXn80WEy5ywwwpHY/B24cPAjwB804VrzcVjUODNMU REYwWnm8SDyYQhQI+K8NRNdHOXn/LjDqfABaVA7ReWa7TfKrCSZdNUB/0bU3yR8JvVOT6qXB4SQlS 6cZwAeAkpFg6LyYLh9cFFeOAo0nQow7O0grI47Vbdv0rczao6tql2aINzX6orwdtuyV46iQV7irPy 1bIWikBQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o97DI-001lBg-0s; Wed, 06 Jul 2022 15:45:16 +0000 Date: Wed, 6 Jul 2022 16:45:15 +0100 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, rppt@linux.ibm.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, peterz@infradead.org, catalin.marinas@arm.com, chenhuacai@kernel.org, kernel@xen0n.name, tsbogend@alpha.franken.de, dave.hansen@linux.intel.com, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, arnd@arndb.de, guoren@kernel.org, monstr@monstr.eu, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, x86@kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-csky@vger.kernel.org, openrisc@lists.librecores.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: Add kernel PTE level pagetable pages account Message-ID: References: <398ead25695e530f766849be5edafaf62c1c864d.1657096412.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <398ead25695e530f766849be5edafaf62c1c864d.1657096412.git.baolin.wang@linux.alibaba.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657122376; a=rsa-sha256; cv=none; b=YgAswwun1nPoMFt8/HQt8U/hbv3pauLAGIa4H93ep9Mgv2ABHVLCvhM4bhKSolULliQyPt fqr/D4JA7ID6CGtz54IoTWb61vbzHvSOqJzag+AZgCrmMfHOHxJwpskbpEP6FnMP+x2GMb 2UynElpxR2oLWpcq8QAHXN9eon1ghzM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Igpy4Ztj; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657122376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZMPiGOu1gsOrP+OcjmrgLm7lfQsrjdxIxBZ6JkHGY4s=; b=A0ViVmuSylEWkgAbWG0PcE64WidlwoVHJtzmr9qYUMvROEHm1y7zSlk6nKhIkWygsClVsN Rk6pnHvL5DCO8cAcvDUz+fNCOcd0g7uGCBplfojKK6WPxAUiHYlGD14fOUAUdKeZTjIlW3 zAKqdutMnGHPY+5ENVlBl+rXYlPQrm0= X-Rspamd-Server: rspam04 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Igpy4Ztj; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 6mcq1cbnwryi1huo1gkhf94pd516dtgi X-Rspamd-Queue-Id: 106B940013 X-HE-Tag: 1657122375-749275 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 06, 2022 at 04:59:17PM +0800, Baolin Wang wrote: > Now the kernel PTE level ptes are always protected by mm->page_table_lock > instead of split pagetable lock, so the kernel PTE level pagetable pages > are not accounted. Especially the vmalloc()/vmap() can consume lots of > kernel pagetable, so to get an accurate pagetable accounting, calling new > helpers page_{set,clear}_pgtable() when allocating or freeing a kernel > PTE level pagetable page. > > Meanwhile converting architectures to use corresponding generic PTE pagetable > allocation and freeing functions. > > Note this patch only adds accounting to the page tables allocated after boot. > > Signed-off-by: Baolin Wang > Reported-by: kernel test robot What does this Reported-by: even mean? the kernel test robot told you that the page tables weren't being accounted? I don't understand why we want to start accounting kernel page tables. an we have a *discussion* about that with a sensible thread name instead of just trying to sneak it in as patch 3/3?