From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6187CC433EF for ; Mon, 4 Jul 2022 16:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7C466B0072; Mon, 4 Jul 2022 12:31:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2C086B0073; Mon, 4 Jul 2022 12:31:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF2EA6B0074; Mon, 4 Jul 2022 12:31:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9FF586B0072 for ; Mon, 4 Jul 2022 12:31:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6045A34433 for ; Mon, 4 Jul 2022 16:31:01 +0000 (UTC) X-FDA: 79649956722.28.CF400DA Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf14.hostedemail.com (Postfix) with ESMTP id CEDEF10009B for ; Mon, 4 Jul 2022 16:31:00 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 264G2wcS023517; Mon, 4 Jul 2022 16:30:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pp1; bh=gJnL/G7O20Rd6U2Rbs8HerMEoRfqGWgNBlHNnsoKfbE=; b=Kl8uHM6iasT3vuqppIAyjB4nBDdSIbUAoddnUZFhpqnVZSGqoFsmjT+tgZVkxoku2sG4 qQd4NbDpqiJLl/rdvYoZI2FXFHCsF4H872bPrGtVGSytOJ8rPfzyWfwNQq62r40Ofkc5 1y57ob/MmM3vtlpswvDHol6XBUWqpghj88H/kFxB1KQ7yrCBBQ9tOBUjwAQx6DV2yuvJ Czp4U7Q5oG+ZcowYxRl5Idzr0OF+r+iaMtLrRh8y95iIx4JRQvIfRDqCCFb6wRyPgpw+ wSyVlXvK9oPxKzcPmAtVOmtUaN6kn+NYEou8yV7qPDzFj5YqpmaehZceGe1Jf7036tuO bA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3h43cu0hs6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Jul 2022 16:30:57 +0000 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 264G3tlW026793; Mon, 4 Jul 2022 16:30:56 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3h43cu0hrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Jul 2022 16:30:56 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 264GMC97008512; Mon, 4 Jul 2022 16:30:54 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06ams.nl.ibm.com with ESMTP id 3h2d9jaxbt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Jul 2022 16:30:54 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 264GTdaw20054430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Jul 2022 16:29:39 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42A4A11C050; Mon, 4 Jul 2022 16:30:52 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3422611C04A; Mon, 4 Jul 2022 16:30:51 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.191.226]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 4 Jul 2022 16:30:51 +0000 (GMT) Date: Mon, 4 Jul 2022 19:30:49 +0300 From: Mike Rapoport To: Lukas Bulwahn Cc: Andrew Morton , linux-mm@kvack.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , llvm@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] secretmem: drop unneeded initialization in secretmem_file_create() Message-ID: References: <20220704092605.19604-1-lukas.bulwahn@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220704092605.19604-1-lukas.bulwahn@gmail.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: eHOg46GdlyEixKN991psQ6ZIf0VubMuc X-Proofpoint-ORIG-GUID: gIlQ0z65uu7v642PDYHSFqXRCZenWHWt X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-04_16,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=999 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2207040069 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656952261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gJnL/G7O20Rd6U2Rbs8HerMEoRfqGWgNBlHNnsoKfbE=; b=AoGJzmEsBXD/MU6f3Rh+jFghbVcGKnGstC6V5cHjbF/BS0vgpQfiX+JrhpFIycjVAl8TVY baF2mm2ybFCQwYyOq3xP4480WhDkNZIpqxREPnbCf6+bkoMD01ebUTmUurO7D9GsxTTWPv QeHSENUvk2EJkAnKd+JDHPuPxoTIP0w= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Kl8uHM6i; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf14.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656952261; a=rsa-sha256; cv=none; b=MdjwopGAj6ZyBHbsHmptpoJ2DEq3e5OY3uZ/Hs2B8umI5F53rf54uJOiLymvhQLoJqyke2 OvFMUGuTHOaMV9ELvp4N1m8vvumNTe9ZAy3HW4DG1lg6TgHYoan1ZiLxyPr4yop5U5WPZk Epz72LV7VSaS3NSTscJRBF4a2BKIVrk= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Kl8uHM6i; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf14.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com X-Stat-Signature: t7fcn5ny43bngctien8qrhts9maxpejo X-Rspamd-Queue-Id: CEDEF10009B X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1656952260-184899 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Lukas, On Mon, Jul 04, 2022 at 11:26:05AM +0200, Lukas Bulwahn wrote: > Drop the unneeded initialization of the local variable file in function > secretmem_file_create(). > > No functional change and no change in the resulting object code. > > This unneeded initialization was already introduced with the introduction > of secretmem in commit 1507f51255c9 ("mm: introduce memfd_secret system > call to create "secret" memory areas"). This minor code-stylistic issue > was discovered as a dead store with clang-analyzer. You are right and in the current code the initialization is unneeded, but there's a pending patch that relies of this initialization: https://lore.kernel.org/all/Yr1jKwz2+SGxjcuW@kernel.org/ Let's wait and see how that fix develops. > Signed-off-by: Lukas Bulwahn > --- > Mike, please ack. > > Andrew, please pick this minor stylistic clean-up patch. Thanks. > > mm/secretmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 7584aab54d20..46b431d62761 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -171,7 +171,7 @@ static struct vfsmount *secretmem_mnt; > > static struct file *secretmem_file_create(unsigned long flags) > { > - struct file *file = ERR_PTR(-ENOMEM); > + struct file *file; > struct inode *inode; > const char *anon_name = "[secretmem]"; > const struct qstr qname = QSTR_INIT(anon_name, strlen(anon_name)); > -- > 2.17.1 > -- Sincerely yours, Mike.