From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41826C433EF for ; Mon, 4 Jul 2022 13:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C942F6B0072; Mon, 4 Jul 2022 09:55:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C444D6B0073; Mon, 4 Jul 2022 09:55:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0D4A6B0074; Mon, 4 Jul 2022 09:55:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A1AC66B0072 for ; Mon, 4 Jul 2022 09:55:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7823A33A02 for ; Mon, 4 Jul 2022 13:55:38 +0000 (UTC) X-FDA: 79649565156.23.58EED15 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf06.hostedemail.com (Postfix) with ESMTP id CB4A4180004 for ; Mon, 4 Jul 2022 13:55:37 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id r6so4708223pfq.6 for ; Mon, 04 Jul 2022 06:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3BaWzCX2gs48m5o657dKNWJWxvbd6VVhJo20O9wNYbQ=; b=k34J9jCFQXFgd75z8EpNYtm9nt4YtS6IddVzJjvAThdloBININOsCaRGt19bk+hEjL DSqTC3h/vzmSHJC4P3069eoIumo2B1HK0WpkH8c/cibo8C00a9TE0sdLJcWuNkgYXpPD oTuXQTKP5U7HGJjQrCxVgvAtCgIH6Q7UqFkEHaL8ihg7ChqbiebtmXp58gznbBSJwOTT AjyLLGKjbli61c5azh7qDZLCPDBGxFUqyv8a6hyYG2rzgeeLBsjzHbOdZUX2DlcrMfgI +YV+OdCpFL7pqRjdCj3A0YWI/YR6ByRzscSY+FfQ0YFCm5pIA6qLb+J75xvpZyv4eRco fvCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3BaWzCX2gs48m5o657dKNWJWxvbd6VVhJo20O9wNYbQ=; b=N+GZR1jx2i1YJus3lZecF4DhqanswviSZ6mD2sD3Sp1HOAyhGByetkXlyFqNBRVks7 2zHZ5QLChDiPvaW7k933reU1ExW2SyfsoGTmbJfh+bQMo5yBuKV5mOcg6wQSMyRAriJL wHocyFGmP1IbDe3eWDpLWD95N5Xbw04CapUhcoDEpkXOuY9nZMpUs7gGLb5sK5SPY47X rJ+HgQ5cAi30LaoTL6PdMzndoRLqHA4K8uVUls3iDIhSwCxm7V3fuB6w2uzGxcIk4OQC ps0A2taCkH+H8lmMkPcOEdO3KbVwDSk3wOsPKYfakn9apwFMmTvG9+fZ06+IegtJr0Zk +ejA== X-Gm-Message-State: AJIora82sPP2veQzpCGb9GcKfmaateWZEvwBmBjg51k0p+p8tftNIWe0 a3vF3BH7MHrWlI8+VsRL6NjgrQ== X-Google-Smtp-Source: AGRyM1vdAz3v/h9OadIpNWHBuh7HykTHQFAoZ7auI/S4hb+OgBx6vM+FYo/ta9/E1puKPzK+iXUiuQ== X-Received: by 2002:a63:854a:0:b0:40d:1d04:769 with SMTP id u71-20020a63854a000000b0040d1d040769mr25787540pgd.151.1656942936709; Mon, 04 Jul 2022 06:55:36 -0700 (PDT) Received: from localhost ([2408:8207:18d5:ce0:b44a:d6ac:cbc5:89fd]) by smtp.gmail.com with ESMTPSA id b6-20020a170902d50600b0016bdabdf64fsm3600847plg.46.2022.07.04.06.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 06:55:36 -0700 (PDT) Date: Mon, 4 Jul 2022 21:55:33 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 13/16] mm/huge_memory: fix comment of page_deferred_list Message-ID: References: <20220704132201.14611-1-linmiaohe@huawei.com> <20220704132201.14611-14-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220704132201.14611-14-linmiaohe@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656942938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3BaWzCX2gs48m5o657dKNWJWxvbd6VVhJo20O9wNYbQ=; b=U16gCNSiOwnuL3q9TOeNY8Ucu9Te6NWGOq88cnp1PeZjlnytH04hVQG3/ifeRG71/UBswe ah3dzYaQ3OEnkkLuEvcI5cRG+QFHt5siuiZecmIZdDHiial4n7UrVnnaKDFERh0AjINp9z G1Hgk80hLLJXz39QajPXdVbgePQDdkk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=k34J9jCF; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf06.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656942938; a=rsa-sha256; cv=none; b=IBlJKP9fmYnIjUY9D5pne4W6WbqJ4i8cXx3DsFtIPiZggqj45QiC/95d9Fl3oVIAD7LH2p Rizw7DEwchvA2OtgZAmIlLZ/jvmjyyuatE1jQw1AElyD8FAD6wmDxJthNhkztIIJ3sxIzj tSJpAGE3H6zg5BsYH9ozQQKdyTunzIk= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=k34J9jCF; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf06.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CB4A4180004 X-Stat-Signature: mz6emwrqsehxbxjppbrfm64qbw5z3uoy X-Rspam-User: X-HE-Tag: 1656942937-126865 X-Bogosity: Ham, tests=bogofilter, spamicity=0.012662, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 04, 2022 at 09:21:58PM +0800, Miaohe Lin wrote: > The current comment is confusing because if global or memcg deferred list > in the second tail page is occupied by compound_head, why we still use > page[2].deferred_list here? I think it wants to say that Global or memcg > deferred list in the first tail page is occupied by compound_mapcount and > compound_pincount so we use the second tail page's deferred_list instead. > > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song Thanks.