From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C10DCCA480 for ; Mon, 4 Jul 2022 06:37:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9E326B0072; Mon, 4 Jul 2022 02:37:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D261B6B0073; Mon, 4 Jul 2022 02:37:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC6688E0001; Mon, 4 Jul 2022 02:37:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AACB76B0072 for ; Mon, 4 Jul 2022 02:37:36 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 7D1C212062B for ; Mon, 4 Jul 2022 06:37:36 +0000 (UTC) X-FDA: 79648461312.31.34346C3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf31.hostedemail.com (Postfix) with ESMTP id 16FA32002C for ; Mon, 4 Jul 2022 06:37:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F259614B8; Mon, 4 Jul 2022 06:37:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9052CC3411E; Mon, 4 Jul 2022 06:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656916654; bh=Ev99x2/dGK/AfHwjAp99Abizv7vniBu6IQA5CawQMQE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PFJVmhiYn6Ic6FTheiyt1yAOHTodfrybFiqBvVQ/qjJyqvMcrf1iEMEQ/sockNodS ONjRsGxOWH8Cfs69RjqlQ6woEHTlfn5jDBz8nPLFjT72zKvzgWfCgsTNTPCO4TvPkj uwLufFvGkCfNTFWsGIoYzNf29FFaGS0USFD+b4wjw7PxPT6FVuf/T0z4or7bBn/A2i NLtBgjQ1GgdHb5h/x2cfDvUqGj0IWK9OcUpaBWJIWtp5mJNteU1glbswFU1WdZNqOb JmmU/VcV1X3eYwOhhr4yzKOS0q9pNiC0cCirbCUjL6QELQ10pfnXNAwNGPmOVMkb4+ HTG0pR49rjXDg== Date: Mon, 4 Jul 2022 09:37:17 +0300 From: Mike Rapoport To: WANG Xuerui Cc: Matthew Wilcox , Andrew Morton , Arnd Bergmann , Dinh Nguyen , Guo Ren , Helge Deller , Huacai Chen , "James E.J. Bottomley" , Max Filippov , Mike Rapoport , Thomas Bogendoerfer , linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-xtensa@linux-xtensa.org, loongarch@lists.linux.dev Subject: Re: [PATCH 12/14] loongarch: drop definition of PGD_ORDER Message-ID: References: <20220703141203.147893-1-rppt@kernel.org> <20220703141203.147893-13-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656916656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=335UmeiO3X++BAhxT/4mcoK2xCDfMBXoqqFOFNSolWo=; b=QJwOE3SF70khorfsKrFNbUYGupN/k3WnUUQ3cf4gzvODcLU9hUhLdA1jhaqbJQSIOtQ58p 0rTrGnYSmTtsx5aWqDf6YFVi8HulkKor/hDigvD7ucnW2RmMupOU/IEwuUjM5SHdNQCYuU LLpQbzdqlun0BhJBcWBWBuyx5BmFOBg= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PFJVmhiY; spf=pass (imf31.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656916656; a=rsa-sha256; cv=none; b=pJXPPAxgxpt36Wn4DnwzFRPzcKX1Mb7RszmaQccaFJGnGzpTX9OWiGC15+gVU22HwzuRcC LFZkVeqo/8fbHOB0TNRn85NnSPUuF9nGlN+tExjESVjIulVMbZOp5mw/FzwagmvQlnL90W DrGJkU7mT08yqafqmufgfxKA+bCuWHI= X-Stat-Signature: zwcm71adp83f6p3r8sym7u1mxjz4m96n X-Rspamd-Queue-Id: 16FA32002C Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PFJVmhiY; spf=pass (imf31.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1656916655-566993 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 04, 2022 at 11:57:28AM +0800, WANG Xuerui wrote: > > On 2022/7/4 04:50, Matthew Wilcox wrote: > > On Sun, Jul 03, 2022 at 05:12:01PM +0300, Mike Rapoport wrote: > > > +++ b/arch/loongarch/kernel/asm-offsets.c > > > @@ -190,7 +190,6 @@ void output_mm_defines(void) > > > #endif > > > DEFINE(_PTE_T_LOG2, PTE_T_LOG2); > > > BLANK(); > > > - DEFINE(_PGD_ORDER, PGD_ORDER); > > > BLANK(); > > > DEFINE(_PMD_SHIFT, PMD_SHIFT); > > > DEFINE(_PGDIR_SHIFT, PGDIR_SHIFT); > > Should probably also drop one of these BLANK() lines too? > > > Agreed; IMO the blank lines can and should be removed because the > surrounding lines are also mm definitions. They are mm definitions, but still they are separated by blanks to have nice grouping in the generated asm-offsets.h. I suspect that there are more unused definitions in asm-offsets.c, worth taking a look. -- Sincerely yours, Mike.