From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D911EC433EF for ; Sun, 3 Jul 2022 22:55:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 267C76B0072; Sun, 3 Jul 2022 18:55:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 217B16B0073; Sun, 3 Jul 2022 18:55:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E0598E0001; Sun, 3 Jul 2022 18:55:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F062E6B0072 for ; Sun, 3 Jul 2022 18:55:42 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C1F5C3586B for ; Sun, 3 Jul 2022 22:55:42 +0000 (UTC) X-FDA: 79647297324.26.BBB2D6F Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf07.hostedemail.com (Postfix) with ESMTP id 60A8040013 for ; Sun, 3 Jul 2022 22:55:42 +0000 (UTC) Date: Sun, 3 Jul 2022 15:55:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1656888940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UsoL24ELETfF3MSNiDW9I/K0Flpmei9riTSH6+si7ig=; b=iUInCXasIip4wHrtoL/0lzsYtRCZFSsRqfLRPjoYwSOtiqscSWuPjZHfbG97LiaP3BzDIe 0ZXrzFwfVL/E2wq4AmYs4coUwxW0GVnJ6RLTvBjOWag7XFKXgSSe9R92erWjn2FlZkzP5K kLcNL3GRn8tg7m+p4Hc6FjL36mprR04= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Feng Tang Cc: Shakeel Butt , Eric Dumazet , Linux MM , Andrew Morton , Michal Hocko , Johannes Weiner , Muchun Song , Jakub Kicinski , Xin Long , Marcelo Ricardo Leitner , kernel test robot , Soheil Hassas Yeganeh , LKML , network dev , linux-s390@vger.kernel.org, MPTCP Upstream , "linux-sctp @ vger . kernel . org" , lkp@lists.01.org, kbuild test robot , Huang Ying , Xing Zhengjun , Yin Fengwei , Ying Xu Subject: Re: [net] 4890b686f4: netperf.Throughput_Mbps -69.4% regression Message-ID: References: <20220625023642.GA40868@shbuild999.sh.intel.com> <20220627023812.GA29314@shbuild999.sh.intel.com> <20220627123415.GA32052@shbuild999.sh.intel.com> <20220627144822.GA20878@shbuild999.sh.intel.com> <20220628034926.GA69004@shbuild999.sh.intel.com> <20220703104353.GB62281@shbuild999.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220703104353.GB62281@shbuild999.sh.intel.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656888942; a=rsa-sha256; cv=none; b=HakMhg5yzv/iKpV3/tvA81IrqpFiTYo11R+TISROyK4wXfRWalVjm761Dmc/YtwnVNxiwp VwDM7gCmSOvbSEY+iJyClXFiAY4DxWtkojIgC09EB9bvvMvNScDiytXuMnkjUtnNip6ZWc zgjZDlHx4EkbCvbCVqKpd1RBUQ6sYCY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iUInCXas; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656888942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UsoL24ELETfF3MSNiDW9I/K0Flpmei9riTSH6+si7ig=; b=S2uTUIae7F8U6Wmx648mwA1VuqWcZu96wpgVSF2lmXaQcV2+y7qV2hT648vCJl3C4PnEfA 410hxvgjlyXJSWjAWuu4E4D0X00Efw0cPdasBHeump8jWSiTDaBcn0qAh9yMAmd+NOh/ac 7oMP69DJZO8qaU/lnQ72meoRFkv9ego= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 60A8040013 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iUInCXas; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspam-User: X-Stat-Signature: m13sa8hp7hczadmpxc3de11b5ei4zexx X-HE-Tag: 1656888942-753986 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 03, 2022 at 06:43:53PM +0800, Feng Tang wrote: > Hi Shakeel, > > On Fri, Jul 01, 2022 at 08:47:29AM -0700, Shakeel Butt wrote: > > On Mon, Jun 27, 2022 at 8:49 PM Feng Tang wrote: > > > I just tested it, it does perform better (the 4th is with your patch), > > > some perf-profile data is also listed. > > > > > > 7c80b038d23e1f4c 4890b686f4088c90432149bd6de 332b589c49656a45881bca4ecc0 e719635902654380b23ffce908d > > > ---------------- --------------------------- --------------------------- --------------------------- > > > 15722 -69.5% 4792 -40.8% 9300 -27.9% 11341 netperf.Throughput_Mbps > > > > > > 0.00 +0.3 0.26 ± 5% +0.5 0.51 +1.3 1.27 ± 2%pp.self.__sk_mem_raise_allocated > > > 0.00 +0.3 0.32 ± 15% +1.7 1.74 ± 2% +0.4 0.40 ± 2% pp.self.propagate_protected_usage > > > 0.00 +0.8 0.82 ± 7% +0.9 0.90 +0.8 0.84 pp.self.__mod_memcg_state > > > 0.00 +1.2 1.24 ± 4% +1.0 1.01 +1.4 1.44 pp.self.try_charge_memcg > > > 0.00 +2.1 2.06 +2.1 2.13 +2.1 2.11 pp.self.page_counter_uncharge > > > 0.00 +2.1 2.14 ± 4% +2.7 2.71 +2.6 2.60 ± 2% pp.self.page_counter_try_charge > > > 1.12 ± 4% +3.1 4.24 +1.1 2.22 +1.4 2.51 pp.self.native_queued_spin_lock_slowpath > > > 0.28 ± 9% +3.8 4.06 ± 4% +0.2 0.48 +0.4 0.68 pp.self.sctp_eat_data > > > 0.00 +8.2 8.23 +0.8 0.83 +1.3 1.26 pp.self.__sk_mem_reduce_allocated > > > > > > And the size of 'mem_cgroup' is increased from 4224 Bytes to 4608. > > > > Hi Feng, can you please try two more configurations? Take Eric's patch > > of adding ____cacheline_aligned_in_smp in page_counter and for first > > increase MEMCG_CHARGE_BATCH to 64 and for second increase it to 128. > > Basically batch increases combined with Eric's patch. > > With increasing batch to 128, the regression could be reduced to -12.4%. If we're going to bump it, I wonder if we should scale it dynamically depending on the size of the memory cgroup? Thanks!